Page MenuHomePhabricator
Create Task
Maniphest T283003

beta votewiki: Fatal error: Uncaught ExtensionDependencyError: TheWikipediaLibrary requires CentralAuth to be installed.
Closed, ResolvedPublic
Actions

Description

taavi@deployment-deploy01:~$ mwscript shell.php --wiki=votewiki
Fatal error: Uncaught ExtensionDependencyError: TheWikipediaLibrary requires CentralAuth to be installed.
TheWikipediaLibrary requires GlobalPreferences to be installed.
 in /srv/mediawiki-staging/php-master/includes/registration/ExtensionRegistry.php:406
Stack trace:
#0 /srv/mediawiki-staging/php-master/includes/registration/ExtensionRegistry.php(230): ExtensionRegistry->readFromQueue(Array)
#1 /srv/mediawiki-staging/php-master/includes/Setup.php(166): ExtensionRegistry->loadFromQueue()
#2 /srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(90): require_once('/srv/mediawiki-...')
#3 /srv/mediawiki-staging/php-master/maintenance/shell.php(106): require_once('/srv/mediawiki-...')
#4 /srv/mediawiki-staging/multiversion/MWScript.php(116): require_once('/srv/mediawiki-...')
#5 {main}
  thrown in /srv/mediawiki-staging/php-master/includes/registration/ExtensionRegistry.php on line 406

started happening after 4fedb3b (T282143) was merged. Also reproducible when viewing https://vote.wikimedia.beta.wmflabs.org/

Details

SubjectRepoBranchLines +/-
[BETA CLUSTER] TheWikipediaLibrary requires CentralAuth and GlobalPreferencesoperations/mediawiki-configmaster+2 -1
[BETA CLUSTER] Disable `TheWikipediaLibrary` for votewikioperations/mediawiki-configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

taavi created this task.May 17 2021, 10:28 AM
jsn.sherman added a parent task: T132084: Notify editors that they are now eligible for the Wikipedia Library program.May 17 2021, 4:17 PM

Added this to the tracker task, since we should clearly only deploy this to projects with the listed dependencies available.

jsn.sherman claimed this task.May 17 2021, 4:29 PM
jsn.sherman added a subscriber: • Samwalton9-WMF.

@Samwalton9 Per https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Process, it looks like we're supposed to be white/blacklisting projects to deploy this to. Right now we have this set to deploy everywhere by default.

It looks like it's on us (The-Wikipedia-Library) to either choose whitelisted projects to deploy to start with or to identify the projects not using globalpreferences and centralauth and disable the extension in wmf-config. It should be a relatively small number.

gerritbot added a comment.May 17 2021, 4:48 PM

Change 692353 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[operations/mediawiki-config@master] [BETA CLUSTER] Disable `TheWikipediaLibrary` for votewiki

https://gerrit.wikimedia.org/r/692353

gerritbot added a project: Patch-For-Review.May 17 2021, 4:49 PM
jsn.sherman added a comment.May 17 2021, 4:50 PM

I'm not sure of the best way to go find which extensions are available for each project, so blacklisting this one seemed like a good place to start.

jsn.sherman added a comment.May 17 2021, 5:01 PM

oh, duh, the best place to look is probably the file I just edited.

Legoktm subscribed.May 17 2021, 5:03 PM

@jsn.sherman I would suggest doing something like https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/4f404f1d2864a7fe5984c7ab1c01943cf6defdab/wmf-config/CommonSettings.php#1856 to make sure you don't enable TheWikipediaLibrary on wikis without CentralAuth

gerritbot added a comment.May 17 2021, 5:11 PM

Change 692353 abandoned by Jsn.sherman:

[operations/mediawiki-config@master] [BETA CLUSTER] Disable `TheWikipediaLibrary` for votewiki

Reason:

taking a more general approach instead

https://gerrit.wikimedia.org/r/692353

jsn.sherman added a comment.May 17 2021, 5:11 PM

@Legoktm Helpful, thanks!

gerritbot added a comment.May 17 2021, 5:21 PM

Change 692356 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[operations/mediawiki-config@master] [BETA CLUSTER] TheWikipediaLibrary requires CentralAuth and GlobalPreferences

https://gerrit.wikimedia.org/r/692356

taavi merged a task: T283024: Beta is unable to update databases due to uncaught extensiondependencyerrors.May 17 2021, 5:34 PM
taavi added a subscriber: thcipriani.
RhinosF1 subscribed.May 17 2021, 9:10 PM
gerritbot added a comment.May 17 2021, 11:29 PM

Change 692356 merged by jenkins-bot:

[operations/mediawiki-config@master] [BETA CLUSTER] TheWikipediaLibrary requires CentralAuth and GlobalPreferences

https://gerrit.wikimedia.org/r/692356

Urbanecm closed this task as Resolved.May 17 2021, 11:38 PM
Urbanecm subscribed.
urbanecm@deployment-deploy01:~$ mwscript shell.php --wiki=votewiki
Psy Shell v0.10.5 (PHP 7.2.31-1+0~20200514.41+debian9~1.gbpe2a56b+wmf1+icu63 — cli) by Justin Hileman
>>> ^D
Exit:  Ctrl+D
urbanecm@deployment-deploy01:~$

Does what I would expect it to do.

Maintenance_bot removed a project: Patch-For-Review.May 18 2021, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits