Page MenuHomePhabricator

issue with having just one section/paragraph in SX
Closed, ResolvedPublic

Description

image.png (1×630 px, 120 KB)

  • once I click "apply" in the title, then the bottom buttons are blocked and the "loading gif" never finishes spinning

image.png (1×620 px, 117 KB)

  • the last call made was a "preflight" call, never saw this before
  • if I select an article with more content to translate, this issue doesn't happen, it seems to be related to the number of sentences/paragraphs

as referred T281739#7107699 here, it seems this is an issue with having just one section/paragraph, it doesn't happen when there's multiple paragraphs

Event Timeline

It seems that cxserver doesn't add "cx-segment" class to sentences when there is only one paragraph inside the segmented section contents. I guess that this used to make sense for Content Translation but doesn't suit our needs anymore. @santhosh
are my assumptions right?

Screenshot of segmented section contents for the article and section in the description below:

image.png (326×905 px, 119 KB)

Change 698739 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/services/cxserver@master] Fix missing sentence segmentation for single paragraphs with ref at end

https://gerrit.wikimedia.org/r/698739

Change 698739 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/services/cxserver@master] Fix missing sentence segmentation for single paragraphs with ref at end

https://gerrit.wikimedia.org/r/698739

This patch fixed the segmentation issue in cxserver, but in general sentence segmentation is not a perfect mechanism because of language/script related complications. It would be wise to have fallback logic to consider the parent element as segment in those cases.

Change 698739 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Fix missing sentence segmentation for single paragraphs with ref at end

https://gerrit.wikimedia.org/r/698739

Change 699089 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Add support for Elia MT to cxserver

https://gerrit.wikimedia.org/r/699089

Change 699089 merged by jenkins-bot:

[operations/deployment-charts@master] Add support for Elia MT to cxserver

https://gerrit.wikimedia.org/r/699089