Page MenuHomePhabricator
Create Task
Maniphest T283513

issue with having just one section/paragraph in SX
Closed, ResolvedPublic
Actions

Description

image.png (1×630 px, 120 KB)

  • once I click "apply" in the title, then the bottom buttons are blocked and the "loading gif" never finishes spinning

image.png (1×620 px, 117 KB)

  • the last call made was a "preflight" call, never saw this before
  • if I select an article with more content to translate, this issue doesn't happen, it seems to be related to the number of sentences/paragraphs

as referred T281739#7107699 here, it seems this is an issue with having just one section/paragraph, it doesn't happen when there's multiple paragraphs

Details

SubjectRepoBranchLines +/-
Add support for Elia MT to cxserveroperations/deployment-chartsmaster+12 -2
Fix missing sentence segmentation for single paragraphs with ref at endmediawiki/services/cxservermaster+24 -0
Customize query in gerrit

Related Objects

Event Timeline

• Jpita created this task.May 24 2021, 4:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2021, 4:01 PM
• Jpita mentioned this in T281739: “There is no section 1.” error when publishing a section translation.May 24 2021, 4:01 PM
Pginer-WMF added a project: Language-Team (Language-2021-April-June).May 28 2021, 9:14 AM
Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2021-April-June) board.
Pginer-WMF moved this task from Backlog to Mobile editor on the SectionTranslation board.
Pginer-WMF triaged this task as High priority.May 28 2021, 9:17 AM
ngkountas added subscribers: santhosh, ngkountas.Jun 3 2021, 12:54 PM

It seems that cxserver doesn't add "cx-segment" class to sentences when there is only one paragraph inside the segmented section contents. I guess that this used to make sense for Content Translation but doesn't suit our needs anymore. @santhosh
are my assumptions right?

Screenshot of segmented section contents for the article and section in the description below:

image.png (326×905 px, 119 KB)

santhosh claimed this task.Jun 8 2021, 8:03 AM
santhosh moved this task from Priority Backlog to In Progress on the Language-Team (Language-2021-April-June) board.
gerritbot added a comment.Jun 8 2021, 9:41 AM

Change 698739 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/services/cxserver@master] Fix missing sentence segmentation for single paragraphs with ref at end

https://gerrit.wikimedia.org/r/698739

gerritbot added a project: Patch-For-Review.Jun 8 2021, 9:41 AM
santhosh added a comment.Jun 8 2021, 9:43 AM
In T283513#7141526, @gerritbot wrote:

Change 698739 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/services/cxserver@master] Fix missing sentence segmentation for single paragraphs with ref at end

https://gerrit.wikimedia.org/r/698739

This patch fixed the segmentation issue in cxserver, but in general sentence segmentation is not a perfect mechanism because of language/script related complications. It would be wise to have fallback logic to consider the parent element as segment in those cases.

gerritbot added a comment.Jun 9 2021, 10:16 AM

Change 698739 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Fix missing sentence segmentation for single paragraphs with ref at end

https://gerrit.wikimedia.org/r/698739

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2021, 11:11 AM
gerritbot added a comment.Jun 10 2021, 5:23 AM

Change 699089 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Add support for Elia MT to cxserver

https://gerrit.wikimedia.org/r/699089

gerritbot added a project: Patch-For-Review.Jun 10 2021, 5:23 AM
santhosh moved this task from In Progress to In Review on the Language-Team (Language-2021-April-June) board.Jun 10 2021, 6:37 AM
gerritbot added a comment.Jun 21 2021, 5:20 AM

Change 699089 merged by jenkins-bot:

[operations/deployment-charts@master] Add support for Elia MT to cxserver

https://gerrit.wikimedia.org/r/699089

Stashbot mentioned this in T237028: Evaluate: <style> tag holding template definition.Jun 21 2021, 5:50 AM
Stashbot mentioned this in T276059: Section from the original article not showing either as missing or present.
Stashbot mentioned this in T255231: Integrate Elia (formerly itzultzailea) MT system.
Stashbot mentioned this in T276246: Create Wikipedia Kari Seediq.

Mentioned in SAL (#wikimedia-operations) [2021-06-21T05:50:31Z] <kart_> cxserver: Added support for Elia MT + Updated to 2021-06-10-074331-production (T276059, T275803, T276246, T283513, T255231, T237028)

Stashbot mentioned this in T275803: Create Wikipedia Atayal.Jun 21 2021, 5:50 AM
Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 8:17 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-July-September) board.
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-July-September) board.Jul 28 2021, 7:38 AM
• Jpita moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2021-July-September) board.Aug 1 2021, 4:50 PM
• Jpita moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-July-September) board.Aug 11 2021, 11:16 PM
Pginer-WMF closed this task as Resolved.Aug 31 2021, 10:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits