Page MenuHomePhabricator

[unusual] Replace LBFactory with injecting new Db-Service in Repo's DatabaseSchemaUpdater and its child classes ItemTermsRebuilder and PropertyTermsRebuilder
Closed, ResolvedPublic

Description

The DatabaseSchemaUpdater is called during runs of the update.php script.

This might be a somewhat more complex task as the two classes ItemTermsRebuilder and PropertyTermsRebuilder might need some refactoring to get rid of "unusual" calls like:

$this->loadBalancerFactory->rollbackMasterChanges( __METHOD__ );

See T283330 for thoughts on how to refactor these classes.

Changing ILBFactory in PropertyInfoTable is not part of this ticket as that class is very integrated in a lot of places and thus done as a task of its own: T283343.

Event Timeline

Change 700057 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] Use RepoDomainDb in ChangesSubscriptionTableBuilder

https://gerrit.wikimedia.org/r/700057

Change 700062 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] Migrate term rebuilders to use DomainDb

https://gerrit.wikimedia.org/r/700062

Change 700057 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use RepoDomainDb in ChangesSubscriptionTableBuilder

https://gerrit.wikimedia.org/r/700057

Change 700062 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate term rebuilders to use DomainDb

https://gerrit.wikimedia.org/r/700062