Page MenuHomePhabricator
Create Task
Maniphest T283946

Replace ILBFactory with the new Db-Service in Repo's CleanTermsIfUnusedJob and related classes
Closed, ResolvedPublic
Actions

Description

Replace usage of ILBFactory with RepoDomainDb in the following related classes:

  • CleanTermsIfUnusedJob
  • DatabaseInnerTermStoreCleaner
  • DatabaseUsageCheckingTermStoreCleaner

Note that DatabaseInnerTermStoreCleaner and DatabaseUsageCheckingTermStoreCleaner are also created and used in the RemoveDeletedItemsFromTermStore maintenance script, but that should be deleted in T283945.

Details

SubjectRepoBranchLines +/-
Update lb in DatabaseUsageCheckingTermStoreCleanermediawiki/extensions/Wikibasemaster+24 -14
Update lb in DatabaseUsageCheckingTermStoreCleanermediawiki/extensions/Wikibasemaster+24 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.May 28 2021, 3:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2021, 3:44 PM
Michael added a subtask: T283945: Remove RemoveDeletedItemsFromTermStore maintenance script.May 28 2021, 3:45 PM
Michael added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 11 2021, 7:45 PM
Lucas_Werkmeister_WMDE closed subtask T283945: Remove RemoveDeletedItemsFromTermStore maintenance script as Resolved.Jun 14 2021, 10:24 AM
dang claimed this task.Jun 14 2021, 2:36 PM
dang moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jun 14 2021, 3:50 PM

Change 699771 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] Update lb in DatabaseUsageCheckingTermStoreCleaner

https://gerrit.wikimedia.org/r/699771

gerritbot added a project: Patch-For-Review.Jun 14 2021, 3:50 PM
gerritbot added a comment.Jun 16 2021, 7:32 AM

Change 699949 had a related patch set uploaded (by Tobias Andersson; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] Update lb in DatabaseUsageCheckingTermStoreCleaner

https://gerrit.wikimedia.org/r/699949

gerritbot added a comment.Jun 16 2021, 10:09 AM

Change 699949 abandoned by Tobias Andersson:

[mediawiki/extensions/Wikibase@master] Update lb in DatabaseUsageCheckingTermStoreCleaner

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /699771

https://gerrit.wikimedia.org/r/699949

dang moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 16 2021, 12:13 PM
gerritbot added a comment.Jun 16 2021, 2:42 PM

Change 699771 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update lb in DatabaseUsageCheckingTermStoreCleaner

https://gerrit.wikimedia.org/r/699771

Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 16 2021, 2:45 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 16 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 16 2021, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits