Page MenuHomePhabricator

User links: Change button icon (logged-in only)
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

In T266536#7121021 there was a discussion on changing the user menu link icon to create more clarity that the menu is related to user-focused functionality.

Acceptance criteria

  • Change the user menu icon and user page link as follows for logged-in users only:

Screen Shot 2021-06-10 at 4.44.49 PM.png (488×1 px, 51 KB)

Prototype

https://di-toc-phase2.web.app/Hokusai

QA Results - Beta

ACStatusDetails
1T284748#7224457

Event Timeline

ovasileva added a subscriber: alexhollender_WMF.
alexhollender_WMF renamed this task from User links: Change button icon to User links: Change button icon (logged-in only).Jun 11 2021, 5:55 PM

Please note that there's ongoing conversations on the proposed items order and icon assignment.

Change 700412 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Update user menu icon and storybook

https://gerrit.wikimedia.org/r/700412

Change 700412 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update user menu icon and storybook

https://gerrit.wikimedia.org/r/700412

Jdlrobson updated Other Assignee, added: bwang.

Should be available on the beta cluster for design review shortly.

Please move to sign off when done (QA should be unnecessary here I think since the feature is flagged).

Looks good, resolving

ovasileva removed ovasileva as the assignee of this task.

Spoke too soon. This task was for logged-in users only, and is currently appearing for logged out folks as well:

Screen Shot 2021-06-23 at 4.15.20 PM.png (1×2 px, 570 KB)

Change 701450 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure userAvatar icon is only used in logged in users

https://gerrit.wikimedia.org/r/701450

Change 701990 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Update user menu icons for logged in/out states

https://gerrit.wikimedia.org/r/701990

cjming added a subscriber: bwang.

Change 701450 restored by Bernard Wang:

[mediawiki/skins/Vector@master] Ensure userAvatar icon is only used in logged in users

https://gerrit.wikimedia.org/r/701450

Change 701990 abandoned by Clare Ming:

[mediawiki/skins/Vector@master] Update user menu icons for logged in/out states

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/ /701450 should have more recent changes

https://gerrit.wikimedia.org/r/701990

Change 701450 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure userAvatar icon is only used in logged in users

https://gerrit.wikimedia.org/r/701450

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Change the user menu icon and user page link as follows for logged-in users only:

Screen Shot 2021-06-10 at 4.44.49 PM.png (488×1 px, 51 KB)

Screen Shot 2021-07-20 at 6.39.52 AM.png (173×387 px, 14 KB)