Page MenuHomePhabricator

Replace ILBFactory with the new Db-Service in Repo's WikibaseRepo.IdGenerator service and its IdGenerator classes
Closed, ResolvedPublic

Description

This conditionally uses again the ILoadBalancer::CONN_TRX_AUTOCOMMITflag, so it might be a bit unusual, but is already used in other contexts for example: https://github.com/wikimedia/Wikibase/blob/b6f6aaef23f28e163f0453fc5d6e9448b6367b5b/lib/includes/Store/Sql/Terms/Util/ReplicaMasterAwareRecordIdsAcquirer.php#L194

$flags = ( $this->separateDbConnection === true ) ? ILoadBalancer::CONN_TRX_AUTOCOMMIT : 0;
$database = $this->loadBalancer->getConnection( DB_PRIMARY, [], false, $flags );

Event Timeline

Change 700083 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Inject RepoDomainDb into IdGenerator classes

https://gerrit.wikimedia.org/r/700083

Change 700083 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Inject RepoDomainDb into IdGenerator classes

https://gerrit.wikimedia.org/r/700083