Page MenuHomePhabricator
Create Task
Maniphest T285073

Restore variant name translations
Closed, ResolvedPublicBUG REPORT
Actions

Description

What happens?:
The following files has been incorrectly deleted by L10n-bot in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/696351

  • languages/i18n/gan.json
  • languages/i18n/kk.json
  • languages/i18n/zh.json

The following files are deleted with purpose:

  • languages/i18n/ks.json
  • languages/i18n/zh-sg.json

What should have happened instead?:
Restore:

  • languages/i18n/gan.json
  • languages/i18n/zh.json

Restore and clean up (only keep variant name messages):

  • languages/i18n/kk.json

Stay deleted:

  • languages/i18n/ks.json
  • languages/i18n/zh-sg.json

Details

SubjectRepoBranchLines +/-
Revert "Localisation updates from https://translatewiki.net."mediawiki/coremaster+41 -0
Customize query in gerrit

Revisions and Commits

rMW MediaWiki
rMW648031f0114b Revert "Localisation updates from https://translatewiki.net."
rMW16bbfcf28875 Localisation updates from https://translatewiki.net.

Related Objects
Search...

Event Timeline

Winston_Sung created this task.Jun 17 2021, 4:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2021, 4:38 AM
Winston_Sung updated the task description. (Show Details)Jun 17 2021, 4:46 AM
Nikerabbit subscribed.Jun 17 2021, 7:44 AM

They were deleted on purpose: gan, kk, ks, zh use multiple scripts, and translations are in a specific script. Please explain what is the issue and not what happened.

Winston_Sung added a comment.Jun 17 2021, 7:48 AM

The variant label (variantname-* messages) are supposed not being changed when changing the current display variant (?variant=).

Winston_Sung added a comment.Jun 17 2021, 7:50 AM

https://zh.wikipedia.org/wiki/Wikipedia:互助客栈/技术?oldid=66124050#為甚麼選擇地區詞那邊的「繁體」選項都變了簡體字呢？

Winston_Sung added a comment.Jun 17 2021, 7:51 AM

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/696351/1/languages/i18n/zh.json

Nikerabbit added a comment.Jun 17 2021, 7:52 AM

I'm not sure how the variant translations are done for Chinese, but I think we can restore zh.json.

Nikerabbit renamed this task from Revert incorrectly deleted files by L10n-bot in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/696351 to Restore Chinese variant name translations.Jun 17 2021, 7:54 AM
Winston_Sung added a comment.Jun 17 2021, 7:55 AM

I'm not sure how the variant translations are done for zh.

All variantname-* messages should be kept in the base variant/language file to prevent being fallback to specific variant files.

Winston_Sung added a comment.Jun 17 2021, 7:56 AM

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/696351/1/languages/i18n/gan.json

Winston_Sung added a comment.Jun 17 2021, 7:57 AM

So only variantname-* messages should being kept in those json files.

Winston_Sung renamed this task from Restore Chinese variant name translations to Restore variant name translations.Jun 17 2021, 7:58 AM
Winston_Sung updated the task description. (Show Details)
Winston_Sung updated the task description. (Show Details)Jun 17 2021, 8:01 AM
Winston_Sung added a comment.Jun 17 2021, 8:04 AM

Also, if possible, please update variantname-zh-tw in languages/i18n/zh.json to "臺灣正體" according to the discussion: https://zh.wikipedia.org/w/index.php?oldid=53225398#「台灣」「正體」？

Nikerabbit claimed this task.Jun 21 2021, 10:40 AM
Nikerabbit edited projects, added Language-Team (Language-2021-April-June); removed Language-Team.
Nikerabbit mentioned this in T255350: Variants label on kk.wikipedia shows "disable" instead of currently chosen variant.Jun 21 2021, 1:52 PM
gerritbot added a comment.Jun 21 2021, 1:58 PM

Change 700626 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/core@master] Revert "Localisation updates from https://translatewiki.net."

https://gerrit.wikimedia.org/r/700626

gerritbot added a project: Patch-For-Review.Jun 21 2021, 1:58 PM
Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-April-June) board.Jun 22 2021, 8:23 AM
Shizhao added a project: Chinese-Sites.Jun 23 2021, 2:05 AM
gerritbot added a comment.Jun 23 2021, 6:33 AM

Change 700626 merged by jenkins-bot:

[mediawiki/core@master] Revert "Localisation updates from https://translatewiki.net."

https://gerrit.wikimedia.org/r/700626

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 23 2021, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 23 2021, 7:10 AM
Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-April-June) board.Jun 23 2021, 2:18 PM
Nikerabbit triaged this task as High priority.Jun 28 2021, 6:47 AM
Shizhao moved this task from Backlog to MediaWiki core on the Chinese-Sites board.Jul 7 2021, 2:38 AM
Nikerabbit closed this task as Resolved.Jul 7 2021, 8:01 AM
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-April-June) board.
Shizhao moved this task from MediaWiki core to Closed on the Chinese-Sites board.Jul 8 2021, 2:07 AM
Winston_Sung added a subtask: T255350: Variants label on kk.wikipedia shows "disable" instead of currently chosen variant.Nov 17 2021, 4:34 AM
Winston_Sung removed a subtask: T255350: Variants label on kk.wikipedia shows "disable" instead of currently chosen variant.
Winston_Sung added a parent task: T255350: Variants label on kk.wikipedia shows "disable" instead of currently chosen variant.
Winston_Sung added a subtask: T286291: Clean up, merge and update zh/zh-* translations.Nov 17 2021, 4:37 AM
Winston_Sung added commits: rMW16bbfcf28875: Localisation updates from https://translatewiki.net., rMW648031f0114b: Revert "Localisation updates from https://translatewiki.net.".Nov 17 2021, 5:09 AM
Winston_Sung changed the status of subtask T286291: Clean up, merge and update zh/zh-* translations from Open to In Progress.Nov 22 2021, 1:28 PM
Winston_Sung removed a subtask: T286291: Clean up, merge and update zh/zh-* translations.Feb 28 2023, 6:00 PM
Winston_Sung mentioned this in T66534: Remaining "disable"s in variantname-*.Mar 19 2023, 2:54 AM
Winston_Sung edited parent tasks, added: T66534: Remaining "disable"s in variantname-*; removed: T255350: Variants label on kk.wikipedia shows "disable" instead of currently chosen variant.
Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptMar 19 2023, 2:54 AM
Winston_Sung added a subtask: T332465: Reimplement: disable display of language variants in variant menu without using CSS custmization.Mar 19 2023, 2:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL