Page MenuHomePhabricator

Add Qunit tests for AddLinkArticleTarget.prototype.annotateSuggestions
Closed, ResolvedPublic

Description

The goal of these tests is to catch regressions with the phrase matching approach. We'd probably want an example from an RTL language, an LTR language, an example where a partial phrase match exists e.g. the link should be "book" but the second instance of it exists (the first instance is in a phrase like "book fair").

Event Timeline

kostajh triaged this task as Medium priority.Jun 28 2021, 9:14 AM
kostajh created this task.

Change 722361 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] QUnit: Add basic test for AddLinkArticleTarget.annotateSuggestions()

https://gerrit.wikimedia.org/r/722361

Change 722361 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] QUnit: Add basic test for AddLinkArticleTarget.annotateSuggestions()

https://gerrit.wikimedia.org/r/722361

kostajh claimed this task.

I'm resolving, as there are some more tests added in T283985: Add Link: word substrings are turned into links.