Page MenuHomePhabricator
Create Task
Maniphest T285811

Mentee overview module: Run updateMenteeData.php regularly
Closed, ResolvedPublic
Actions

Description

According to the specs at T278971: Mentor dashboard: M1 mentee overview module , the table in mentee overview module is supposed to be updated daily.

This means we have to add updateMenteeData.php as a regular job run by the maintenance server. Code for the script itself was already merged to master in the parent task, and will ship to prod with wmf.14.

Checklist
  • Test updateMenteeData.php works as intended in the beta cluster
  • Wait for deployment to production (wmf.14)
  • Test updateMenteeData.php works as intended in production (at least the pilots), check the numbers are correct
  • Write a Puppet patch to run updateMenteeData.php daily in production and beta
  • Ask a SRE to deploy the puppet patch
  • Observe the script for a while (check logs, check numbers stay right)

Details

SubjectRepoBranchLines +/-
mediawiki/maintenance/growthexperiments.pp: Run updateMenteeData every dayoperations/puppetproduction+6 -0
labs: Enable mentor dashboard backend everywhereoperations/mediawiki-configmaster+3 -0
Set wgGEMentorDashboardBackendEnabled properlyoperations/mediawiki-configmaster+16 -0
updateMenteeData: Make it possible to disable script per-wikimediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.15+9 -0
updateMenteeData: Make it possible to disable script per-wikimediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.14+9 -0
updateMenteeData: Make it possible to disable script per-wikimediawiki/extensions/GrowthExperimentsmaster+9 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Jun 29 2021, 9:42 PM
Restricted Application added projects: Growth-Team, User-Urbanecm_WMF. · View Herald TranscriptJun 29 2021, 9:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Stashbot added a comment.Jun 29 2021, 9:45 PM

Mentioned in SAL (#wikimedia-releng) [2021-06-29T21:45:33Z] <urbanecm> urbanecm@deployment-deploy01:~$ mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=cswiki # T285811

Urbanecm_WMF added a comment.Jun 29 2021, 9:49 PM

For the beta cluster part:

urbanecm@deployment-deploy01:~$ sql cswiki
MariaDB [cswiki]> select * from growthexperiments_mentee_data;
Empty set (0.00 sec)

MariaDB [cswiki]> Bye
urbanecm@deployment-deploy01:~$ mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=cswiki # T285811
urbanecm@deployment-deploy01:~$ sql cswiki
MariaDB [cswiki]> select mentee_data from growthexperiments_mentee_data\G
*************************** 1. row ***************************
mentee_data: {"username":"Martin Urbanec","reverted":0,"questions":1,"editcount":20,"registration":"20191102161354","last_active":"20210428160314","blocks":0}
*************************** 2. row ***************************
mentee_data: {"username":"Tgr","reverted":0,"questions":0,"editcount":5,"registration":"20191102161411","last_active":"20210503074638","blocks":1}
*************************** 3. row ***************************
mentee_data: {"username":"ET221","reverted":0,"questions":0,"editcount":3,"registration":"20191105021347","last_active":"20210226022321","blocks":0}
*************************** 4. row ***************************
mentee_data: {"username":"ET10","reverted":0,"questions":1,"editcount":68,"registration":"20191211231919","last_active":"20210319003956","blocks":0}
*************************** 5. row ***************************
mentee_data: {"username":"Rho2017","reverted":0,"questions":4,"editcount":26,"registration":"20191212120813","last_active":"20210408155334","blocks":0}
*************************** 6. row ***************************
mentee_data: {"username":"ET18","reverted":0,"questions":0,"editcount":17,"registration":"20200114223640","last_active":"20210315222330","blocks":0}
*************************** 7. row ***************************
mentee_data: {"username":"ET13","reverted":8,"questions":16,"editcount":69,"registration":"20200225202255","last_active":"20210526012903","blocks":0}
*************************** 8. row ***************************
mentee_data: {"username":"Bluedot","reverted":0,"questions":1,"editcount":5,"registration":"20200316144201","last_active":"20210407203150","blocks":0}
*************************** 9. row ***************************
mentee_data: {"username":"ET271","reverted":0,"questions":0,"editcount":3,"registration":"20200520002139","last_active":"20210319234051","blocks":0}
*************************** 10. row ***************************
mentee_data: {"username":"ET370","reverted":0,"questions":4,"editcount":10,"registration":"20200920201304","last_active":"20210126011724","blocks":0}
*************************** 11. row ***************************
mentee_data: {"username":"ET7","reverted":0,"questions":0,"editcount":3,"registration":"20201023224437","last_active":"20210319004934","blocks":0}
*************************** 12. row ***************************
mentee_data: {"username":"ET1002","reverted":0,"questions":0,"editcount":1,"registration":"20201103221119","last_active":"20210305200704","blocks":0}
*************************** 13. row ***************************
mentee_data: {"username":"ET1005","reverted":0,"questions":0,"editcount":3,"registration":"20201104212539","last_active":"20210123012413","blocks":0}
*************************** 14. row ***************************
mentee_data: {"username":"ET2015","reverted":0,"questions":0,"editcount":1,"registration":"20210109014257","last_active":"20210109020618","blocks":0}
*************************** 15. row ***************************
mentee_data: {"username":"ET73","reverted":0,"questions":0,"editcount":2,"registration":"20210202193519","last_active":"20210202193745","blocks":0}
*************************** 16. row ***************************
mentee_data: {"username":"Patrik L.","reverted":0,"questions":0,"editcount":1,"registration":"20210203080502","last_active":"20210428164823","blocks":1}
*************************** 17. row ***************************
mentee_data: {"username":"ET1001","reverted":0,"questions":0,"editcount":1,"registration":"20210218220322","last_active":"20210218222743","blocks":0}
*************************** 18. row ***************************
mentee_data: {"username":"ET217","reverted":0,"questions":0,"editcount":1,"registration":"20210301212132","last_active":"20210305195950","blocks":0}
*************************** 19. row ***************************
mentee_data: {"username":"ET195","reverted":0,"questions":0,"editcount":2,"registration":"20210317174259","last_active":"20210319002748","blocks":0}
*************************** 20. row ***************************
mentee_data: {"username":"ET1951","reverted":0,"questions":0,"editcount":4,"registration":"20210318151350","last_active":"20210318200905","blocks":0}
*************************** 21. row ***************************
mentee_data: {"username":"MMiller Beta cs 01","reverted":0,"questions":0,"editcount":1,"registration":"20210322210738","last_active":"20210322211031","blocks":0}
21 rows in set (0.00 sec)

MariaDB [cswiki]> Bye
urbanecm@deployment-deploy01:~$

It did generate some data, and the format looks expected. Spot checking the data, I indeed have 20 edits, last one is from April 28, Tgr and Patrik L. indeed were blocked two times. So far so good. I'll do a more thorough check when we're in prod.

Urbanecm_WMF mentioned this in T280007: Create MentorData{Uncached}Provider to provide data about mentor's mentees.Jun 30 2021, 12:20 PM
Urbanecm_WMF moved this task from Untriaged to Engineering on the User-Urbanecm_WMF board.Jun 30 2021, 12:24 PM
Urbanecm_WMF edited projects, added User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF.
Urbanecm_WMF moved this task from Backlog to Blocked on the User-Urbanecm_WMF (Engineering) board.
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jul 2 2021, 8:16 AM
kostajh subscribed.

@Urbanecm_WMF I'm assuming this should be in current sprint; moving the task there.

Stashbot added a comment.Jul 14 2021, 9:27 AM

Mentioned in SAL (#wikimedia-operations) [2021-07-14T09:27:17Z] <urbanecm> [urbanecm@mwmaint2002 /srv/mediawiki/php-1.37.0-wmf.14]$ time mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=testwiki # T285811

Urbanecm_WMF added a comment.Jul 14 2021, 9:32 AM

Now that wmf.14 is at testwikis, I ran the script manually for testwiki. Here is what I can see quickly:

[urbanecm@mwmaint2002 /srv/mediawiki/php-1.37.0-wmf.14]$ sql testwiki --cluster=extension1
wikiadmin@10.192.48.134(testwiki)> select count(*) from growthexperiments_mentee_data;
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0.00 sec)

wikiadmin@10.192.48.134(testwiki)> select count(*) from growthexperiments_mentor_mentee;
+----------+
| count(*) |
+----------+
|      512 |
+----------+
1 row in set (0.00 sec)

wikiadmin@10.192.48.134(testwiki)> Bye
[urbanecm@mwmaint2002 /srv/mediawiki/php-1.37.0-wmf.14]$ time mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=testwiki                                                                                         
real    0m1.666s
user    0m0.508s
sys     0m0.072s
[urbanecm@mwmaint2002 /srv/mediawiki/php-1.37.0-wmf.14]$ sql testwiki --cluster=extension1
wikiadmin@10.192.48.134(testwiki)> select count(*) from growthexperiments_mentee_data;
+----------+
| count(*) |
+----------+
|       80 |
+----------+
1 row in set (0.00 sec)

wikiadmin@10.192.48.134(testwiki)> select count(*) from growthexperiments_mentor_mentee;
+----------+
| count(*) |
+----------+
|      512 |
+----------+
1 row in set (0.00 sec)

wikiadmin@10.192.48.134(testwiki)> select * from growthexperiments_mentee_data limit 10;
+-----------+--------------------------------------------------------------------------------------------------------------------------------------------------------+
| mentee_id | mentee_data                                                                                                                                            |
+-----------+--------------------------------------------------------------------------------------------------------------------------------------------------------+
|       254 | {"username":"Tgr","reverted":0,"questions":0,"editcount":28,"registration":"20060713135958","last_active":"20210711111411","blocks":0}                 |
|       752 | {"username":"Geraki","reverted":0,"questions":0,"editcount":16,"registration":"20070412102512","last_active":"20210511101928","blocks":0}              |
|      2279 | {"username":"Kanashimi","reverted":65,"questions":0,"editcount":266,"registration":"20080621052148","last_active":"20210705060500","blocks":0}         |
|      2565 | {"username":"Catrope","reverted":0,"questions":0,"editcount":91,"registration":"20080714110313","last_active":"20210225210739","blocks":0}             |
|      3312 | {"username":"Iniquity","reverted":1,"questions":2,"editcount":262,"registration":"20080905091652","last_active":"20210201112736","blocks":2}           |
|      6151 | {"username":"HenkvD","reverted":0,"questions":0,"editcount":7,"registration":"20090226192251","last_active":"20210610144634","blocks":0}               |
|     12061 | {"username":"Suffusion of Yellow","reverted":1,"questions":1,"editcount":77,"registration":"20091213124416","last_active":"20210619191506","blocks":0} |
|     16861 | {"username":"DonRumata","reverted":8,"questions":0,"editcount":218,"registration":"20110621181207","last_active":"20210313121935","blocks":0}          |
|     19016 | {"username":"Jdlrobson","reverted":0,"questions":0,"editcount":346,"registration":"20120309182458","last_active":"20210130182015","blocks":0}          |
|     23278 | {"username":"Dyolf77","reverted":0,"questions":0,"editcount":1,"registration":"20130822011838","last_active":"20210330184032","blocks":0}              |
+-----------+--------------------------------------------------------------------------------------------------------------------------------------------------------+
10 rows in set (0.00 sec)

wikiadmin@10.192.48.134(testwiki)> Bye
[urbanecm@mwmaint2002 /srv/mediawiki/php-1.37.0-wmf.14]$

Format is expected. A second for 512 mentees is an okay time for a background maintenance script. I'll measure it at a pilot wiki too, when the train will ship the code there.

I'll start writing a notebook to validate the numbers it generated, in order to make sure I don't have any mistake in the queries in the code.

Urbanecm_WMF triaged this task as Medium priority.Jul 14 2021, 9:33 AM
gerritbot added a comment.Jul 14 2021, 9:39 AM

Change 704506 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/puppet@production] mediawiki/maintenance/growthexperiments.pp: Run updateMenteeData every day

https://gerrit.wikimedia.org/r/704506

gerritbot added a project: Patch-For-Review.Jul 14 2021, 9:39 AM
Urbanecm_WMF added a comment.Jul 14 2021, 2:18 PM

testwiki data looks OK, tested it via https://people.wikimedia.org/~urbanecm/growth-team/updateMenteeData-validation-T285811/testwiki_update_mentee_data_validation.html. Let's see how will it work in the pilot wikis.

Stashbot added a comment.Jul 15 2021, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-15T20:11:00Z] <urbanecm> [urbanecm@mwmaint2002 /srv/mediawiki/php]$ time mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=cswiki # T285811

Stashbot added a comment.Jul 15 2021, 8:26 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-15T20:26:13Z] <urbanecm> [urbanecm@mwmaint2002 /srv/mediawiki/php]$ time mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=bnwiki # T285811

Urbanecm_WMF added a comment.Jul 15 2021, 8:43 PM

Ran and checked for cswiki and bnwiki, via the same notebook:

  • cswiki: ERROR: Found 3 mismatched IDs: {397014: ['editcount', 'last_active'], 463649: ['editcount', 'last_active'], 544633: ['editcount', 'last_active']}
  • bnwiki: All ok

I'll look into the three wrong users soon.

Stashbot added a comment.Jul 15 2021, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-15T20:44:15Z] <urbanecm> [urbanecm@mwmaint2002 /srv/mediawiki/php]$ time mwscript extensions/GrowthExperiments/maintenance/updateMenteeData.php --wiki=viwiki # T285811

Urbanecm_WMF updated the task description. (Show Details)Jul 16 2021, 1:38 PM
Urbanecm_WMF added a comment.Jul 16 2021, 2:56 PM
In T285811#7216106, @Urbanecm_WMF wrote:

Ran and checked for cswiki and bnwiki, via the same notebook:

  • cswiki: ERROR: Found 3 mismatched IDs: {397014: ['editcount', 'last_active'], 463649: ['editcount', 'last_active'], 544633: ['editcount', 'last_active']}
  • bnwiki: All ok

I'll look into the three wrong users soon.

The three users just happened to edit while the script was running, which is normal and can happen. Otherwise the cswiki data is correct.

Urbanecm_WMF added a comment.Jul 16 2021, 4:57 PM

I finished running it for all the four pilot wikis (arwiki, bnwiki, cswiki and viwiki).

arwiki took 102 minutes, which is understandable, as it has 221193 mentees (out of which 22444 meets the conditions to be included in the module).

This is the list of top 10 GE wikis in terms of number of mentees:

dbname mentees
enwiki259752
arwiki221193
frwiki173907
ruwiki105211
ptwiki98318
viwiki70833
fawiki65471
trwiki50960
kowiki43922
cswiki29598

(generated via P16829)

I'm bit unsure if enabling the script at enwiki is going to work fine -- it has over 250k mentees in 2.5 months and grows about 100k mentees/month. Maybe we should add a config variable to turn the script off on enwiki for this timebeing?

gerritbot added a comment.Jul 20 2021, 11:47 AM

Change 705658 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] updateMenteeData: Make it possible to disable script per-wiki

https://gerrit.wikimedia.org/r/705658

gerritbot added a comment.Jul 20 2021, 7:59 PM

Change 705658 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] updateMenteeData: Make it possible to disable script per-wiki

https://gerrit.wikimedia.org/r/705658

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 20 2021, 8:00 PM
gerritbot added a comment.Jul 20 2021, 8:05 PM

Change 705748 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.14] updateMenteeData: Make it possible to disable script per-wiki

https://gerrit.wikimedia.org/r/705748

gerritbot added a comment.Jul 20 2021, 8:06 PM

Change 705749 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.15] updateMenteeData: Make it possible to disable script per-wiki

https://gerrit.wikimedia.org/r/705749

gerritbot added a comment.Jul 20 2021, 8:40 PM

Change 705748 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.14] updateMenteeData: Make it possible to disable script per-wiki

https://gerrit.wikimedia.org/r/705748

gerritbot added a comment.Jul 20 2021, 8:40 PM

Change 705749 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.15] updateMenteeData: Make it possible to disable script per-wiki

https://gerrit.wikimedia.org/r/705749

gerritbot added a comment.Jul 20 2021, 8:47 PM

Change 705740 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Set wgGEMentorDashboardBackendEnabled properly

https://gerrit.wikimedia.org/r/705740

Stashbot added a comment.Jul 20 2021, 8:49 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T20:49:40Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.14/extensions/GrowthExperiments/maintenance/updateMenteeData.php: dafd953eb5cd35bddbd2fd348b03066420a42362: updateMenteeData: Make it possible to disable script per-wiki (T285811) (duration: 00m 58s)

gerritbot added a comment.Jul 20 2021, 8:50 PM

Change 705740 merged by jenkins-bot:

[operations/mediawiki-config@master] Set wgGEMentorDashboardBackendEnabled properly

https://gerrit.wikimedia.org/r/705740

Stashbot added a comment.Jul 20 2021, 8:53 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T20:53:16Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: caa5a076f39b051b01622aa3e4c9d716a8643eef: Set wgGEMentorDashboardBackendEnabled properly (T285811) (duration: 00m 57s)

Urbanecm_WMF added a project: SRE.Jul 20 2021, 8:57 PM

Tagging SRE, as I need someone to merge https://gerrit.wikimedia.org/r/c/operations/puppet/+/704506 in puppet for me :-).

gerritbot added a comment.Jul 20 2021, 8:59 PM

Change 705742 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] labs: Enable mentor dashboard backend everywhere

https://gerrit.wikimedia.org/r/705742

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 20 2021, 9:00 PM
gerritbot added a comment.Jul 20 2021, 9:00 PM

Change 705742 merged by jenkins-bot:

[operations/mediawiki-config@master] labs: Enable mentor dashboard backend everywhere

https://gerrit.wikimedia.org/r/705742

Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 20 2021, 9:03 PM
Urbanecm_WMF moved this task from Blocked to In progress on the User-Urbanecm_WMF (Engineering) board.Jul 20 2021, 9:09 PM
gerritbot added a comment.Jul 21 2021, 3:55 PM

Change 704506 merged by RLazarus:

[operations/puppet@production] mediawiki/maintenance/growthexperiments.pp: Run updateMenteeData every day

https://gerrit.wikimedia.org/r/704506

Urbanecm_WMF updated the task description. (Show Details)Jul 21 2021, 4:39 PM
Urbanecm_WMF removed a project: SRE.Jul 21 2021, 4:42 PM
Stashbot added a comment.Jul 21 2021, 4:49 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-21T16:49:59Z] <urbanecm> [urbanecm@mwmaint2002 ~]$ time /usr/local/bin/mw-cli-wrapper /usr/local/bin/foreachwikiindblist /srv/mediawiki/dblists/growthexperiments.dblist extensions/GrowthExperiments/maintenance/updateMenteeData.php # T285811

Urbanecm_WMF added a comment.Jul 21 2021, 4:53 PM

updateMenteeData.php was deployed as a regular job by the SREs, logs will be at mwmaint2002:/var/log/mediawiki/mediawiki_job_growthexperiments-updateMenteeData (scheduled to run at 4:15 UTC). I just ran it as an oneoff to see how fast that will be when ran sequentially.

I'll look tomorrow to make sure everything works as intended.

Urbanecm_WMF closed this task as Resolved.Jul 22 2021, 2:12 PM
In T285811#7228092, @Urbanecm_WMF wrote:

updateMenteeData.php was deployed as a regular job by the SREs, logs will be at mwmaint2002:/var/log/mediawiki/mediawiki_job_growthexperiments-updateMenteeData (scheduled to run at 4:15 UTC). I just ran it as an oneoff to see how fast that will be when ran sequentially.

I'll look tomorrow to make sure everything works as intended.

I verified the job got dispatched, that the logs look sane and that the cswiki numbers are correct. I think this can be now called resolved.

Urbanecm_WMF added a project: GrowthExperiments-Mentorship.Jul 4 2024, 5:58 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 8:47 PM
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Jul 9 2024, 9:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits