Page MenuHomePhabricator

Add parameter that allows user links menu to be seen across all wikis
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

We would like to flag potential issues on the pilot wikis for the desktop improvements project with the new user menu. One way to do this would be to add a query parameter that shows the menu across all wikis.

Acceptance criteria

explore adding a parameter that shows the user links menu across all wikis regardless of whether the features is enabled everywhere.

Developer notes

Since this is becoming a common request, I suggest we generalize languageinheader=0 and make it possible for FeatureManagement Requirement class to define a query string parameter override. Suggested parameter for user links would be vector-userlinks=0.

Let's make sure to mark this as temporary in the code so we remember to remove it in future. << forgot about this so threw a ticket in the backlog for the future (T286737)

QA instructions

Screen Shot 2021-07-15 at 1.39.54 PM.png (634×2 px, 248 KB)

Screen Shot 2021-07-15 at 1.40.08 PM.png (618×2 px, 235 KB)

QA Results - Beta

ACStatusDetails
1T285855#7231580

Event Timeline

Change 704193 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Add querystring parameter override for consolidated user links.

https://gerrit.wikimedia.org/r/704193

cjming added a subscriber: cjming.
Jdlrobson added a subscriber: Jdlrobson.

Change 704193 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add querystring parameter override for user links, language in header.

https://gerrit.wikimedia.org/r/704193

Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Navigate to the beta cluster and test the query string parameter overrides.
✅ AC1: Add ?vectoruserlinks=0 to see old treatment regardless of config i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?vectoruserlinks=0

Screen Shot 2021-07-22 at 3.30.40 PM.png (323×1 px, 77 KB)

✅ AC2: Add ?vectoruserlinks=1 to see new treatment regardless of config i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?vectoruserlinks=1

Screen Shot 2021-07-22 at 3.30.51 PM.png (334×1 px, 79 KB)

And now on production:

Screen Shot 2021-07-23 at 10.35.34 AM.png (1×2 px, 413 KB)

Resolving!