Page MenuHomePhabricator

set Japanese monthly convert variant 11 to default
Closed, ResolvedPublic

Description

the variant 11 has a wording that may work better with Japanese donors. Advancement would like this to be the default in in all countries. However translations seem stuck at the moment.

Step 1: figure out how to update the translations for this variant. Something is up with the bot that manages this.
Step 2: make variant 11 default for all countries.

Event Timeline

DStrine created this task.

Thanks David! Adding the translations here for reference:

MediaWiki:Donate interface-monthly-convert-yes-button-variant-011/ja
はい、毎月<span class="mc-convert-ask"></span>を寄付します。

MediaWiki:Donate interface-monthly-convert-no-button-variant-011/ja
いいえ、今回はやめておきます。
(translation is closer to "No, not this time." instead of "No thanks!")

Hi! Just to confirm, the automated translation update from Translate Wiki to DonationInterface has happened now, and I'm able to see the fully translated Monthly convert variant 011 in my local setup.

So, we should be fine to deploy on Monday! :)

Thanks!!

Thanks @AndyRussG!
Please let us know after translations are deployed, as we would like to proof it before we making the switch.

Hi @DStrine, clarifying question when you have a mo: when we make the switch, variant 11 be live at the country level for Japan (en and ja), right?

And it would not affect the variant live right now for en6C pre-tests?

@HNordeenWMF we'll have to make sure that's the case.

One small update: the translations should be on production now. So you can QA it.

Great, thanks @DStrine! Camille has them for proofing.

I don't think it'd be a big issue if this became the control for en6C as well, but it would be good to know either way!
I'm guessing we'd rather set up a test of control vs 011 for en6C vs changing right away if possible.

There's something a little funky happening with the "No" button's padding

jaJP monthly convert.png (1×1 px, 163 KB)

FWIW we're ok with this being in 6C (English) too for now.

But yes; we do want to confirm whether any changes are country-only (for example, English could appear differently in 6C than in Japan)?

Just to update no variant changes have been deployed. 011 has not been set to the default.

The variant= in the url will cache so it can get confusing when switching between variants in the same browser session. Opening the link in a new incognito tab will behave more like expected with testing.

I updated this task per standup today. We want all countries to see variant 11 until the japan campaign is done. I will probably make another task to switch back after that.

DStrine raised the priority of this task from Medium to High.Aug 2 2021, 6:35 PM

Change 709549 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Configurable default monthly convert module

https://gerrit.wikimedia.org/r/709549

Change 709553 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Monthy convert variant 11 - replace text in JS

https://gerrit.wikimedia.org/r/709553

Change 709564 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Use flexbox for MC button text alignment

https://gerrit.wikimedia.org/r/709564

Change 709549 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Configurable default monthly convert module

https://gerrit.wikimedia.org/r/709549

Change 709553 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Monthly convert variant 11 - replace text in JS

https://gerrit.wikimedia.org/r/709553

Change 709564 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Use flexbox for MC button text alignment

https://gerrit.wikimedia.org/r/709564

This is now set to the default (for all countries where MC is on by default). The padding issue with the 'no' button is also fixed.