Page MenuHomePhabricator

When closing the Quick View, the image selected is out of the screen
Closed, ResolvedPublicBUG REPORT

Description

**Video of the issue: https://www.loom.com/share/72702336ff334c1a8bb84dacc22f950c?focus_title=1&muted=1&from_recorder=1

List of steps to reproduce (step by step, including full links if applicable):

  • Access the media search
  • Search for an image
  • Scroll to the bottom and load a couple of pages
  • Click on one of the image
  • Click the X to close the Quick View

What happens?:

  • The page scroll to the bottom, and even trigger a new image search

What should have happened instead?:

  • The scroll position of the images should go back to what it was before the quick view was clicked, or at least ahve the selected image on screen

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

I did more testing on the issue
(1) the issue is based on the initial number of images displayed in the viewport, e.g.

with zoom 150% click on an image (partially displayed) in the bottom row (partially displayed)the next row of images after viewing in QuickView will display the issue described in the ticket - scroll out of the view after closing QuickView
Screen Shot 2021-08-16 at 4.34.12 PM.png (851×1 px, 1 MB)
Screen Shot 2021-08-16 at 4.36.47 PM.png (881×1 px, 1 MB)
with zoom 100% click on an image (partially displayed) in the bottom rowthe next row of images after viewing in QuickView will display the issue described in the ticket - scroll out of the view after closing QuickView
Screen Shot 2021-08-16 at 4.40.20 PM.png (833×1 px, 1 MB)
notice that it's not the next row as it was for 150% scale, but the second row
Screen Shot 2021-08-16 at 4.43.37 PM.png (848×1 px, 1 MB)

when that additional scrolling would require fetching additional results, the results will be loaded automatically. It doesn't looks like a bug although it might look confusing.

(2) Another scrolling issue is related to scrolling while viewing an image in the QuickView

  • I click on the first image in the fetched results
  • while the image is displayed in the QuickView, I scroll to a different image (not clicking on it).
  • click to close the QuickView - should I be brought back to the image I clicked on or to the images that I scrolled to? Currently is neither.

The exception: if while viewing an image in the QuickView, I scroll to the very top or to the very bottom, then closing the QuickView will keep me at the scrolled position.

Re-checked - the issue is still present - re-open the task.

@Etonkovidova I cannot replicate this anymore (and I was the one opening the ticket, so I knew how to replicate it! lol)

Look I am recorded a quick video: https://www.loom.com/share/0349896d505e4c3398eda893e3f8e8c8

Any chance you can record a video too, so that I understand if there are any settle difference between the way you do it and the way I do it..

Etonkovidova claimed this task.

@Etonkovidova I cannot replicate this anymore (and I was the one opening the ticket, so I knew how to replicate it! lol)

Look I am recorded a quick video: https://www.loom.com/share/0349896d505e4c3398eda893e3f8e8c8

Any chance you can record a video too, so that I understand if there are any settle difference between the way you do it and the way I do it..

Thanks for the video, @SimoneThisDot! I re-checked few test cases (including the cases that were reported in my comment - https://phabricator.wikimedia.org/T287464#7287164) and the issue is not present anymore. Closing as Resolved.