Page MenuHomePhabricator
Create Task
Maniphest T287514

Handle old (non-current) ZObject pages, or at least warn the user that they're looking at the current version despite their request
Closed, ResolvedPublic
Actions

Description

Right now we just fetch the latest revision, always.

  • Add ability in MW layer
  • Expose ability in MW APIs
  • Plumb into the UX

Details

SubjectRepoBranchLines +/-
Handle oldid url param to view a particular revisionmediawiki/extensions/WikiLambdawmf/1.41.0-wmf.19+208 -7
Handle oldid url param to view a particular revisionmediawiki/extensions/WikiLambdamaster+208 -7
APIs: Add ability to fetch old revisions on ZObjectsmediawiki/extensions/WikiLambdamaster+45 -1
ZObjectStore::fetchZObjectByTitle: Allow fetching non-current revisionsmediawiki/extensions/WikiLambdamaster+20 -3
ZObjectContentHandler::getExternalRepresentation: Support revisionsmediawiki/extensions/WikiLambdamaster+5 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Jul 27 2021, 6:26 PM
DVrandecic claimed this task.Aug 11 2021, 4:51 PM
DVrandecic moved this task from To triage to To triage: Un-phased work on the Abstract Wikipedia team board.
Jdforrester-WMF moved this task from To triage: Un-phased work to Phase θ – Throttling on the Abstract Wikipedia team board.Sep 14 2021, 8:15 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Needs discussion/DoD on the Abstract Wikipedia team (Phase θ – Throttling) board.Mar 8 2022, 11:04 PM
gerritbot added a comment.Jul 26 2022, 8:17 PM

Change 817375 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjectStore::fetchZObjectByTitle: Allow fetching non-current revisions

https://gerrit.wikimedia.org/r/817375

gerritbot added a project: Patch-For-Review.Jul 26 2022, 8:17 PM

Change 817376 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjectContentHandler::getExternalRepresentation: Support revisions

https://gerrit.wikimedia.org/r/817376

gerritbot added a comment.Jul 26 2022, 8:17 PM

Change 817377 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] APIs: Add ability to fetch old revisions on ZObjects

https://gerrit.wikimedia.org/r/817377

• JKieserman subscribed.Jul 26 2022, 11:26 PM

@Jdforrester-WMF should there be a related gerrit task (probably for the backlog) for the UI work that would support/show this?

gerritbot added a comment.Jul 26 2022, 11:34 PM

Change 817375 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectStore::fetchZObjectByTitle: Allow fetching non-current revisions

https://gerrit.wikimedia.org/r/817375

gerritbot added a comment.Jul 26 2022, 11:35 PM

Change 817376 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectContentHandler::getExternalRepresentation: Support revisions

https://gerrit.wikimedia.org/r/817376

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 27 2022, 12:00 AM
Jdforrester-WMF added a comment.Jul 29 2022, 8:53 PM
In T287514#8106758, @JKieserman wrote:

@Jdforrester-WMF should there be a related gerrit task (probably for the backlog) for the UI work that would support/show this?

I was thinking that this task would cover all of it. Do you think it'd be better to split it out?

gerritbot added a comment.Aug 23 2022, 10:31 AM

Change 817377 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] APIs: Add ability to fetch old revisions on ZObjects

https://gerrit.wikimedia.org/r/817377

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.27; 2022-08-29); removed MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 23 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 23 2022, 11:30 AM
Jdforrester-WMF updated the task description. (Show Details)Aug 24 2022, 10:16 AM
DVrandecic removed DVrandecic as the assignee of this task.Sep 1 2022, 12:05 AM
DVrandecic subscribed.
DVrandecic moved this task from Needs discussion/DoD to Ready: G6. Stable & secure on the Abstract Wikipedia team (Phase θ – Throttling) board.Jan 10 2023, 7:54 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 9:32 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 9:41 AM
Jdforrester-WMF renamed this task from Decide whether, when we fetch ZIDs to render on old pages, we should try to fetch and render the old content, or just warn the user that we don't to Handle old (non-current) ZObject pages, or at least warn the user that they're looking at the current version despite their request.Jun 20 2023, 7:20 PM
Jdforrester-WMF added a parent task: T335713: View history Undo action silently fails .
DVrandecic added a parent task: T340775: Launch-blocking bugs.Jul 25 2023, 3:19 AM
Jdforrester-WMF changed the task status from Open to In Progress.Jul 25 2023, 3:17 PM
Jdforrester-WMF assigned this task to gengh.
Jdforrester-WMF moved this task from Engineering tasks to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.
gerritbot added a comment.Jul 25 2023, 6:58 PM

Change 941482 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Handle oldid url param to view a particular revision

https://gerrit.wikimedia.org/r/941482

gerritbot added a project: Patch-For-Review.Jul 25 2023, 6:58 PM
gengh updated the task description. (Show Details)Jul 25 2023, 7:08 PM
Jdforrester-WMF moved this task from In progress to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 25 2023, 7:24 PM
gerritbot added a comment.Jul 25 2023, 7:26 PM

Change 941482 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Handle oldid url param to view a particular revision

https://gerrit.wikimedia.org/r/941482

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2023, 7:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 25 2023, 8:00 PM
DVrandecic closed this task as Resolved.Jul 26 2023, 1:16 AM

I was expecting some text saying "warning, you are looking at an outdated version!" - but instead, hey, it seems all fixed, and able to show previous versions! WoW!

gerritbot added a comment.Jul 26 2023, 9:15 AM

Change 941850 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] Handle oldid url param to view a particular revision

https://gerrit.wikimedia.org/r/941850

gerritbot added a project: Patch-For-Review.Jul 26 2023, 9:15 AM
gerritbot added a comment.Jul 26 2023, 12:41 PM

Change 941850 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] Handle oldid url param to view a particular revision

https://gerrit.wikimedia.org/r/941850

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 26 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 26 2023, 1:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL