HomepageModuleRegistry shouldn't have MediaWikiServices as a parameter
Open, MediumPublic
Actions

Assigned To

None

Authored By

	DannyS712
	Jul 30 2021, 5:21 AM

Description

HomepageModuleRegistry gets an entire MediaWikiServices object injected into it, which goes against the documentation and can lead to stale reference. Per Injection.md documentation: "Do not however inject the MediaWikiServices object!"

The new MentorDashboardModuleRegistry in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/685111/ (T278971) is doing this too, pointing to HomepageModuleRegistry as precedent.

Both should probably use ObjectFactory instead.

Related Objects

Mentioned Here: T278971: Mentor dashboard: M1 mentee overview module

Event Timeline

DannyS712 created this task.Jul 30 2021, 5:21 AM

Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptJul 30 2021, 5:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Jul 30 2021, 5:21 AM

• mewoph moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 30 2021, 9:12 PM

The purpose of registries is to do open-ended object instantiation, so it's only natural they hold an instance of MediaWikiServices. I don't see what the benefit of holding it indirectly via ObjectFactory would be.

daniel triaged this task as Medium priority.Aug 19 2021, 10:54 AM

daniel edited projects, added Platform Team Workboards (MW Expedition); removed Platform Engineering.

@daniel I see you've put this as medium priority and tagged Platform Team Workboards (MW Expedition), does that signify that Platform Engineering may look at this?

HomepageModuleRegistry shouldn't have MediaWikiServices as a parameterOpen, MediumPublicActions

Description

Related Objects

Event Timeline

HomepageModuleRegistry shouldn't have MediaWikiServices as a parameter
Open, MediumPublic
Actions