Page MenuHomePhabricator

Remove all references to "concept chips"
Closed, ResolvedPublic

Description

The "concept chips" feature never ended up getting shipped, but there are several places in the code where we had been preparing to enable it.

Some examples of code that can be removed:

  • The ConceptChips.vue component itself and accompanying stylesheet
  • The relatedConcepts state, mutations, and actions and their mapped usages in App.vue
  • Any related tests in the actions.test.js file
  • The entire <transition-group> component that wraps the search results in the App.vue file (the usage of this transition component will block Vue 3 migration, see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaSearch/+/714102 and T289019
  • Any config code in extension.json to support this feature
  • Possibly other places in PHP as well

Event Timeline

Change 716438 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/MediaSearch@master] Remove all references to \"related concepts\" feature

https://gerrit.wikimedia.org/r/716438

Can product confirm that we will not be resurrecting this anytime soon?

Change 716438 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Remove all references to \"related concepts\" feature

https://gerrit.wikimedia.org/r/716438

Can product confirm that we will not be resurrecting this anytime soon?

It's not on the roadmap at all for this FY.

matthiasmullie claimed this task.

Re-opening because there's orphaned related code in WikibaseMediaInfo (API endpoint) left. Patch incoming.

Change 737374 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/WikibaseMediaInfo@master] Remove all references to \"related concepts\" feature

https://gerrit.wikimedia.org/r/737374

Change 737374 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Remove all references to \"related concepts\" feature

https://gerrit.wikimedia.org/r/737374