Sticky header: Sticky header should not appear on certain namespaces
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	Sep 3 2021, 5:56 PM

Description

Background

The sticky header provides a certain set of tools focused on article pages and other mainspaces focused on content creation. At this point, we will not support special use cases for the set of pages listed below, however, we will iterate on this in the future

Acceptance criteria

Sticky header should be disabled on the following namespaces and pages:
Talk
File
Special
TimedText
Diff pages
History pages
Wikitext editor
VE
Enabled on
Main
User
Wikipedia
Template
Module
Help
Category
Portal
If the namespace above is not listed, it should be disabled
Checks are hardcoded and performed in JavaScript (for now)

Developer notes

Configuration can be expensive, so for now I would recommend hard coding this behaviour inside the JavaScript. Namespace is available in mw.config.get('wgNamespaceNumber') and action in mw.config.get('wgAction')

In future if we want/need to generalize this, I'd suggest refactoring and generalising the existing code relating to max width, but that should be considered out of scope for now.

QA Results - Beta

AC	Status	Details
1	✅	T290347#7378054
2	✅	T290347#7378054

QA Results - Prod

AC	Status	Details
1	✅	T290347#7378072
2	❌	T290347#7378072

Details

	Subject	Repo	Branch	Lines +/-
	Restrict sticky header to specified namespaces	mediawiki/skins/Vector	master	+29 -1

Customize query in gerrit

Related Objects

Mentioned In: T300612: Sticky header: sticky header "gap" appearing on diffs of pages with other sticky elements
T289721: [Goal] Sticky header is enabled for logged in users on the beta cluster

Event Timeline

ovasileva created this task.Sep 3 2021, 5:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2021, 5:56 PM

ovasileva triaged this task as High priority.Sep 3 2021, 5:56 PM

ovasileva moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.

Jdlrobson claimed this task.Sep 7 2021, 5:08 PM

Sticky header should be disabled on the following namespaces and pages:

@alexhollender @ovasileva Is there any correlation between this feature request and the existing max-width?

For example, looking at Module and TimedText I'm now wondering if the max-width makes sense on those namespaces:
https://en.wikipedia.org/wiki/TimedText:Requiem_for_a_Dream_rapid_cuts.ogv.en.srt

The max-width is already disabled on all those pages except talk, file

I ask, as I wonder if the existing config could be reused here, with some additional overrides for talk, file, and main page.

Jdlrobson reassigned this task from • alexhollender_WMF to ovasileva.Sep 9 2021, 5:15 PM

In T290347#7339899, @Jdlrobson wrote:

Sticky header should be disabled on the following namespaces and pages:

@alexhollender @ovasileva Is there any correlation between this feature request and the existing max-width?
For example, looking at Module and TimedText I'm now wondering if the max-width makes sense on those namespaces:
https://en.wikipedia.org/wiki/TimedText:Requiem_for_a_Dream_rapid_cuts.ogv.en.srt

The max-width is already disabled on all those pages except talk, file

I ask, as I wonder if the existing config could be reused here, with some additional overrides for talk, file, and main page.

I think the current correlation is mostly circumstantial. In the future, our plan would be to have most or all pages fit within the max width, although that might not be the case for the sticky header. That said, I think re-using could potentially be an option so long as we can easily make overrides in the future of moving certain namespaces into and out of the two individual groups.

Jdlrobson removed ovasileva as the assignee of this task.Sep 10 2021, 8:20 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Sep 14 2021, 5:15 PM

Jdlrobson moved this task from Code Review to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

ovasileva updated the task description. (Show Details)Sep 14 2021, 5:20 PM

ovasileva updated the task description. (Show Details)Sep 14 2021, 5:23 PM

ovasileva updated the task description. (Show Details)

LGoto set the point value for this task to 2.Sep 14 2021, 5:24 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming claimed this task.Sep 15 2021, 12:06 AM

cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

hi @ovasileva -- Module is listed in both enable + disable lists in the task description -- can you clarify which one it should be?

Change 721404 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Restrict sticky header to specified namespaces

https://gerrit.wikimedia.org/r/721404

gerritbot added a project: Patch-For-Review.Sep 15 2021, 9:23 PM

In T290347#7357109, @cjming wrote:

hi @ovasileva -- Module is listed in both enable + disable lists in the task description -- can you clarify which one it should be?

Fixed now. Module should be enabled.

cjming removed cjming as the assignee of this task.Sep 15 2021, 9:28 PM

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming subscribed.

cjming claimed this task.Sep 15 2021, 9:30 PM

cjming moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

thanks @ovasileva -- one more Q -- should sticky header be visible on Edit pages?

In T290347#7357288, @cjming wrote:

thanks @ovasileva -- one more Q -- should sticky header be visible on Edit pages?

Hi @cjming - no, no sticky header in either the text editor or VE (cc @alexhollender on what the transition there should look like)

ovasileva updated the task description. (Show Details)Sep 16 2021, 8:09 PM

cjming removed cjming as the assignee of this task.Sep 16 2021, 10:03 PM

cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson assigned this task to Edtadros.Sep 17 2021, 3:37 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 721404 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Restrict sticky header to specified namespaces

https://gerrit.wikimedia.org/r/721404

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 17 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2021, 8:10 PM

Please test this one on https://patchdemo.wmflabs.org/wikis/7d133396d0/wiki/New_York_Yankees

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Sticky header should be disabled on the following namespaces and pages:

Talk
File
Special
TimedText
Diff pages
History pages
Wikitext editor
VE

✅ AC1: Sticky header should be enabled on the following namespaces and pages:

Main
User
Wikipedia
Template
Module
Help
Category
Portal

Test Result - Prod

Status: ❌ Fail
Environment: enwiki, commons
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Sticky header should be disabled on the following namespaces and pages:

Talk
File
Special
TimedText
Diff pages
History pages
Wikitext editor
VE

❌ AC1: Sticky header should be enabled on the following namespaces and pages:

Main
User
❌ Wikipedia	Article Wizard fails
Template
Module
Help
Category
Portal

@Jdlrobson The sticky header does show up, but the text is not what is expected. If the text is not in scope of this task I can pass this and move it to Ready for Signoff, assuming there is (or will be) a task for the header text.

Edtadros updated the task description. (Show Details)Sep 25 2021, 7:47 PM

@Edtadros this can't be tested on production, only on https://patchdemo.wmflabs.org/wikis/7d133396d0/wiki/New_York_Yankees

The querystring flag trumps all the logic here.

Looks good, resolving

Jdlrobson mentioned this in T289721: [Goal] Sticky header is enabled for logged in users on the beta cluster.Sep 30 2021, 8:42 PM

Jdlrobson mentioned this in T300612: Sticky header: sticky header "gap" appearing on diffs of pages with other sticky elements.Jul 22 2022, 7:37 PM

	F34654502: Screen Recording 2021-09-25 at 12.38.45 PM.mov.gif
	Sep 25 2021, 7:45 PM

	F34654478: Screen Recording 2021-09-25 at 12.28.41 PM.mov.gif
	Sep 25 2021, 7:45 PM

	F34654498: Screen Recording 2021-09-25 at 12.37.22 PM.mov.gif
	Sep 25 2021, 7:45 PM

	F34654490: Screen Recording 2021-09-25 at 12.33.50 PM.mov.gif
	Sep 25 2021, 7:45 PM

	F34654510: Screen Recording 2021-09-25 at 12.43.03 PM.mov.gif
	Sep 25 2021, 7:45 PM

	F34654474: Screen Recording 2021-09-25 at 12.26.40 PM.mov.gif
	Sep 25 2021, 7:45 PM

	F34654486: Screen Recording 2021-09-25 at 12.32.10 PM.mov.gif
	Sep 25 2021, 7:45 PM

	F34654512: Screen Recording 2021-09-25 at 12.43.19 PM.mov.gif
	Sep 25 2021, 7:45 PM

Sticky header: Sticky header should not appear on certain namespacesClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Background

Acceptance criteria

Developer notes

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Sticky header: Sticky header should not appear on certain namespaces
Closed, ResolvedPublic2 Estimated Story Points
Actions