Page MenuHomePhabricator
Create Task
Maniphest T290597

Add history and talk page icons to sticky header
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The sticky header, should have links to the talk and history page. Ideally they should be rendered as part of the initial server side rendered template. This could require some refactoring of core Skin code (see associated T283184) to reduce us acquiring technical debt, so please consider implications on skin architecture when making this change.

acceptance criteria

Add the following icons and links to the sticky header as per the prototype below:

  • History
  • Talk

QA Results - Beta

ACStatusDetails
1✅T290597#7388578
2✅T290597#7388578

QA Results - Prod

ACStatusDetails
1✅T290597#7388583
2✅T290597#7388583

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add history and talk page icons to sticky headerJdlrobsonmediawiki/skins/Vectormaster+80 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 8 2021, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2021, 5:20 PM
Jdlrobson updated the task description. (Show Details)Sep 8 2021, 5:39 PM
Jdlrobson triaged this task as High priority.Sep 8 2021, 6:55 PM
LGoto set the point value for this task to 3.Sep 9 2021, 5:25 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Sep 13 2021, 5:39 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson removed Jdlrobson as the assignee of this task.Sep 14 2021, 4:44 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
• nray subscribed.Sep 14 2021, 4:52 PM

Is there a patch for this ticket?

gerritbot added a comment.Sep 14 2021, 4:55 PM

Change 721026 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Add history and talk page icons to sticky header

https://gerrit.wikimedia.org/r/721026

gerritbot added a project: Patch-For-Review.Sep 14 2021, 4:55 PM
LGoto assigned this task to cjming.Sep 14 2021, 5:08 PM
cjming reassigned this task from cjming to Edtadros.Sep 14 2021, 11:10 PM
cjming moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
cjming subscribed.
gerritbot added a comment.Sep 14 2021, 11:26 PM

Change 721026 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add history and talk page icons to sticky header

https://gerrit.wikimedia.org/r/721026

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 15 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 15 2021, 12:10 AM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Sep 29 2021, 4:29 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Add the following icons and links to the sticky header as per the prototype below:
✅ AC1: History
✅ AC2: Talk

Screen Shot 2021-09-29 at 9.28.59 AM.png (1,047×419 px, 104 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Sep 29 2021, 4:31 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Add the following icons and links to the sticky header as per the prototype below:
✅ AC1: History
✅ AC2: Talk

Screen Shot 2021-09-29 at 9.29.42 AM.png (1,047×419 px, 157 KB)

Edtadros updated the task description. (Show Details)Sep 29 2021, 4:32 PM
ovasileva closed this task as Resolved.Sep 30 2021, 9:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits