Maniphest T290907

Add an image: create skeleton for inspector
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mewoph
	Sep 13 2021, 6:34 PM

Tags

Referenced Files

	F34642157: Screen Shot 2021-09-13 at 12.19.33 PM.png
	Sep 13 2021, 7:23 PM

Subscribers

Description

Create a bare-bone inspector with the following elements:

Yes button (for T290781: Add an image: captions)
No button (for T290046: Add an image: rejection dialog)
Fullscreen button (for T290540: Add an image: image viewer)

This will unblock other tasks which have these buttons as entry points.

Details

	Subject	Repo	Branch	Lines +/-
	Add an image: Create basic elements for image inspector	mediawiki/extensions/GrowthExperiments	master	+291 -32

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		MMiller_WMF	T285587 [EPIC] "Add an image" Iteration 1
		Resolved		DMburugu	T289823 Add an image: frontend tasks for initial release
		Resolved		• mewoph	T290045 Add an image: image inspector
		Resolved		• mewoph	T290907 Add an image: create skeleton for inspector

Event Timeline

• mewoph created this task.Sep 13 2021, 6:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2021, 6:34 PM

• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 13 2021, 6:34 PM

• mewoph triaged this task as High priority.Sep 13 2021, 6:47 PM

Change 720805 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: Create basic elements for image inspector

https://gerrit.wikimedia.org/r/720805

gerritbot added a project: Patch-For-Review.Sep 13 2021, 7:22 PM

With latest changes:

Screen Shot 2021-09-13 at 12.19.33 PM.png (570×750 px, 38 KB)

Tgr mentioned this in T290761: Add an image: Create class for task-agnostic concerns for inspector.Sep 14 2021, 5:28 AM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 14 2021, 6:50 AM

Change 720805 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: Create basic elements for image inspector

https://gerrit.wikimedia.org/r/720805

Maintenance_bot removed a project: Patch-For-Review.Sep 14 2021, 7:10 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 14 2021, 8:00 AM

QutieBot added a project: QTE-TestingOverview.Nov 17 2021, 6:16 PM

Etonkovidova closed this task as Resolved.Dec 2 2021, 10:55 PM