Page MenuHomePhabricator
Create Task
Maniphest T291021

Make the UX for creating a user-defined type straightforward
Closed, ResolvedPublic
Actions

Description

The current workflow makes the creation of user-defined types a bit difficult, because we need to select a validator while creating the type, but the validator cannot be defined yet until the type is there.

We could resolve in a number of ways:

  1. pre-select the object validator as the validator (Z101)
  2. create a validator function during type creation, with an implementation calling the object validator (Z101)

I would prefer option 2, but if too hard to implement I take option 1.

Details

SubjectRepoBranchLines +/-
Add a "create type" button on the Special:CreateZObject pagemediawiki/extensions/WikiLambdamaster+13 -4
Enable FE to search for Function that return Typemediawiki/extensions/WikiLambdamaster+62 -0
Make the UX for creating a user-defined type straightforwardmediawiki/extensions/WikiLambdamaster+86 -27
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 ResolvedcmassaroT291026 Let user implementations throw a user-defined error during a user-defined validation
 ResolvedNoneT291027 Users can create error types
 ResolvedDVrandecicT293423 Create a function that turns an error type into a type
 ResolvedcmassaroT289687 Allow users to create instances of errors in composition
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedNoneT273124 Use evaluation for validation
 ResolvedSimoneThisDotT291022 Validators for user-defined types can be defined and linked
 ResolvedSimoneThisDotT291021 Make the UX for creating a user-defined type straightforward
 ResolvedSimoneThisDotT292891 Provide a custom UX for Z4/Type

Event Timeline

DVrandecic created this task.Sep 15 2021, 12:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2021, 12:40 AM
DVrandecic added a parent task: T291022: Validators for user-defined types can be defined and linked.Sep 15 2021, 12:43 AM
Jdforrester-WMF renamed this task from User-defined types can be created straightforward to Make the UX for creating a user-defined type straightforward.Oct 6 2021, 4:47 PM
Jdforrester-WMF added a project: WikiLambda Front-end.
DVrandecic triaged this task as Medium priority.Oct 6 2021, 4:48 PM
DVrandecic added a subtask: T292891: Provide a custom UX for Z4/Type.Oct 20 2021, 11:05 PM
Jdforrester-WMF closed subtask T292891: Provide a custom UX for Z4/Type as Resolved.Oct 27 2021, 4:18 PM
DVrandecic added a comment.Oct 27 2021, 4:46 PM

Use also a typed list of keys instead of a generic list. And then let's call this done.

DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Oct 27 2021, 4:46 PM
SimoneThisDot claimed this task.Nov 3 2021, 2:53 PM
SimoneThisDot moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
gerritbot added a comment.Nov 9 2021, 9:24 AM

Change 737624 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Make the UX for creating a user-defined type straightforward

https://gerrit.wikimedia.org/r/737624

gerritbot added a project: Patch-For-Review.Nov 9 2021, 9:25 AM
SimoneThisDot moved this task from In progress to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Nov 9 2021, 9:26 AM
gerritbot added a comment.Nov 9 2021, 9:12 PM

Change 737624 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Make the UX for creating a user-defined type straightforward

https://gerrit.wikimedia.org/r/737624

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 9 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 9 2021, 10:10 PM
DVrandecic moved this task from QA / Ready to close to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Nov 17 2021, 5:18 PM
SimoneThisDot added a comment.Nov 18 2021, 10:55 AM

@DVrandecic This is actually done for my point of view. The Backend is actually failing if we send a typed list instead than a normal list for the keys, but the FE is all set to do what you suggested.

please let me know if you need further updates on this task, so far, when an user select a TYPE in the object creator the following happens:

  • The UI does not show Unrelevant information to the user
  • The key is preselected to be a typed list of type keys
  • The validator is preset to be Z101
Jdforrester-WMF subscribed.Nov 24 2021, 5:54 PM

Hey Simone, this was moved back because we wanted to add Type as a default prompt on Special:CreateZObject alongside Function.

DVrandecic raised the priority of this task from Medium to High.Dec 8 2021, 11:34 PM
gerritbot added a comment.Jan 5 2022, 11:17 AM

Change 751705 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Enable FE to search for Function that return Type

https://gerrit.wikimedia.org/r/751705

gerritbot added a project: Patch-For-Review.Jan 5 2022, 11:17 AM

Change 751705 abandoned by Simone Cuomo:

[mediawiki/extensions/WikiLambda@master] Enable FE to search for Function that return Type

Reason:

Wrong ID again!

https://gerrit.wikimedia.org/r/751705

SimoneThisDot changed the task status from Open to In Progress.Jan 5 2022, 11:20 AM
SimoneThisDot moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
gerritbot added a comment.Jan 5 2022, 11:32 AM

Change 751712 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Add a \"create type\" button on the Special:CreateZObject page

https://gerrit.wikimedia.org/r/751712

Jdforrester-WMF moved this task from In progress to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Jan 5 2022, 3:15 PM
gerritbot added a comment.Jan 5 2022, 3:26 PM

Change 751712 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add a \"create type\" button on the Special:CreateZObject page

https://gerrit.wikimedia.org/r/751712

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.17; 2022-01-10); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Jan 5 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 5 2022, 4:10 PM
DVrandecic closed this task as Resolved.Jan 11 2022, 5:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL