Page MenuHomePhabricator

Make the UX for creating a user-defined type straightforward
Closed, ResolvedPublic

Description

The current workflow makes the creation of user-defined types a bit difficult, because we need to select a validator while creating the type, but the validator cannot be defined yet until the type is there.

We could resolve in a number of ways:

  1. pre-select the object validator as the validator (Z101)
  2. create a validator function during type creation, with an implementation calling the object validator (Z101)

I would prefer option 2, but if too hard to implement I take option 1.

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedNone
ResolvedDVrandecic
OpenNone
StalledNone
ResolvedDVrandecic
Resolvedgengh
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
ResolvedSimoneThisDot
ResolvedSimoneThisDot

Event Timeline

Jdforrester-WMF renamed this task from User-defined types can be created straightforward to Make the UX for creating a user-defined type straightforward.Oct 6 2021, 4:47 PM
DVrandecic triaged this task as Medium priority.Oct 6 2021, 4:48 PM

Use also a typed list of keys instead of a generic list. And then let's call this done.

Change 737624 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Make the UX for creating a user-defined type straightforward

https://gerrit.wikimedia.org/r/737624

Change 737624 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Make the UX for creating a user-defined type straightforward

https://gerrit.wikimedia.org/r/737624

@DVrandecic This is actually done for my point of view. The Backend is actually failing if we send a typed list instead than a normal list for the keys, but the FE is all set to do what you suggested.

please let me know if you need further updates on this task, so far, when an user select a TYPE in the object creator the following happens:

  • The UI does not show Unrelevant information to the user
  • The key is preselected to be a typed list of type keys
  • The validator is preset to be Z101

Hey Simone, this was moved back because we wanted to add Type as a default prompt on Special:CreateZObject alongside Function.

DVrandecic raised the priority of this task from Medium to High.Dec 8 2021, 11:34 PM

Change 751705 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Enable FE to search for Function that return Type

https://gerrit.wikimedia.org/r/751705

Change 751705 abandoned by Simone Cuomo:

[mediawiki/extensions/WikiLambda@master] Enable FE to search for Function that return Type

Reason:

Wrong ID again!

https://gerrit.wikimedia.org/r/751705

Change 751712 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Add a \"create type\" button on the Special:CreateZObject page

https://gerrit.wikimedia.org/r/751712

Change 751712 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add a \"create type\" button on the Special:CreateZObject page

https://gerrit.wikimedia.org/r/751712