Page MenuHomePhabricator
Create Task
Maniphest T289687

Allow users to create instances of errors in composition
Closed, ResolvedPublic
Actions

Description

It seems I cannot create instances of errors.

(Which kinda makes sense, since error types are not types).

There are a few possible approaches to that:
a) bespoke implementation to make this happen
b) create a function that takes an error type and returns a type, which then is used

On first thought, I prefer b over a.

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (0d127c2)mediawiki/services/function-evaluatormaster+147 -188
Update function-schemata sub-module to HEAD (0d127c2)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (0d127c2)mediawiki/extensions/WikiLambdamaster+1 -1
definitions: Add Z820/Trigger Metadata and built-in implementationmediawiki/services/function-schematamaster+77 -0
Add builtin throw function to allow user definition of errors in compositions.mediawiki/services/function-orchestratormaster+201 -8
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedcmassaroT288555 Support serialisation/deserialisation of user-defined types
 ResolvedBUG REPORTcmassaroT290122 "Could not deserialize input ZObject type: Z86"
 ResolvedcmassaroT287263 Deserialize Objects in Evaluator Based on Z7K1.Z8K2
 ResolvedNoneT275941 Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types")
 ResolvedgenghT277000 Validate a Z7/Function call in the wiki
 ResolvedgenghT281386 Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code
 DeclinedLindsaykwardellT282745 Add function-schemata to frontend in order to remedy hybrid forms
 ResolvedLindsaykwardellT282816 Use canonicalizer to display JSON
 ResolvedcmassaroT284474 Add tests for normalize/canonicalize code in frontend.
 ResolvedcmassaroT284764 Fix Canonicalization Code in Frontend to Handle Z6s That Masquerade as Z9s
 ResolvedNoneT291033 A function call used as an argument should validate its return type against the expected type of the argument
 ResolvedNoneT291034 Every argument of a function call with a literal or reference should be of a type compatible for that argument
 ResolvedcmassaroT291032 Arguments taking a function should validate functions as values
 ResolvedNoneT291040 Generic functions
 InvalidNoneT291037 Function model: update functions to the new generic types
 InvalidgenghT291038 Function model: updates to the data model to implement generic types
 ResolvedDVrandecicT287196 Update Pre-Generic Function Model
 ResolvedDVrandecicT287195 Function model: Z21 should be updated to be the null value of Unit
 ResolvedDVrandecicT287194 Function model: Z8K5 is a Z8/Function not a Z6/String, regardless of what our code says
 ResolvedSimoneThisDotT303302 Validate that the UX works with typed list for core types (e.g. Z4 has a typed list of Z3s)
 ResolvedSimoneThisDotT304101 Change the Type UX so that it works (viewing/creating/editing) with a typed list of Z3s for Z4K2
Resolved• JKiesermanT303303 Change the pre-defined core types to use typed lists and not general lists
 ResolvedNoneT291039 Functions using generic types as input types or output type can be defined and implemented
 ResolvedNoneT291045 Function created by a generic function call can be evaluated
 ResolvedJdforrester-WMFT291046 Generic functions can be evaluated
 ResolvedNoneT291047 Generic functions can be implemented
 ResolvedNoneT291048 Generic functions can be defined
 DeclinedNoneT291036 Function model: Z8 should change from a type to a function taking a type and a list of types and returning a type
 ResolvedSimoneThisDotT291041 Instances of a generic type are displayed correctly
 ResolvedSimoneThisDotT291042 Instances of generic types can be edited
 ResolvedcmassaroT291044 Instances of generic types are being validated
 ResolvedcmassaroT285260 Orchestrator Top-Level Validation Should Check Z1K1
 ResolvedSimoneThisDotT297244 Let front-end users create and edit instances of any generic type
 ResolvedSimoneThisDotT291043 Instances of generic typed lists can be created
 ResolvedcmassaroT266241 Normalizer and canonicalizer should deal with local and global keys
 ResolvedcmassaroT289681 Composition creating a type doesn't evaluate
 ResolvedBUG REPORTJdforrester-WMFT292890 Trying to create a Z14 throws "Cannot read properties of undefined (reading 'filter')" in Vue code
 ResolvedSimoneThisDotT295470 Change the type search API to allow users to search for functions returning a type in addition to instances of that type
 ResolvedgenghT262089 Store type identity output in wikilambda_zobject_labels table
ResolvedgenghT297925 Change object search API to optionally include functions' return types as the 'type' filter
 ResolvedcmassaroT286975 Make it possible to define the Typed List function fully
 ResolvedcmassaroT287102 Resolve Z18s Wherever They Occur
 ResolvedJdforrester-WMFT291049 Function that takes a type and returns a type can be evaluated
 ResolvedDVrandecicT291050 Functions that take a type and return a type can be implemented
 ResolvedDVrandecicT291051 Functions that take a type and return a type can be defined
 ResolvedJdforrester-WMFT293663 Fix instancePath vs. dataPath in function-schemata, Add Tests
 ResolvedcmassaroT292808 Use type inference logic to serialize the return type of functions which return a generic ZObject (Z8K2 === Z1)
 ResolvedSimoneThisDotT291023 Instances of user-defined types can be entered using the default component
 ResolvedJdforrester-WMFT291029 Instances of a user-defined type can be edited
 ResolvedDVrandecicT291025 Make it possible to define and implement functions using user-defined types as output or an input type
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 ResolvedNoneT273124 Use evaluation for validation
 ResolvedcmassaroT260321 Allow users to trigger function calls for built-in functions (orchestrator-only)
 ResolvedDVrandecicT261964 Agree on architecture for first evaluation engine
 ResolvedLindsaykwardellT280558 Normalize Inputs to Orchestrator
 ResolvedarthurlorenziT275095 Move normalization and canonicalization code to function-schemata
 ResolvedNoneT262770 Normalize ZObjects
 InvalidNoneT280559 Retrieve Function Signature from Orchestrator
 ResolvedcmassaroT282843 Hook up orchestrator to the evaluator and pass through appropriately-dereferenced Z7 calls
 ResolvedcmassaroT271762 Create initial Function Evaluator service
 ResolvedcmassaroT269697 Turn Function Evaluator into a service
 ResolvedcmassaroT269698 Make Function Evaluator work async
 ResolvedcmassaroT272630 Define interface for the function-evaluator
 ResolvedJdforrester-WMFT276478 Provide "semantically peel-able" list of programming languages that we allow
 ResolvedcmassaroT273515 Create Execution Environments for Supported Languages
 ResolvedcmassaroT273517 Create Execution Environment for Python
 ResolvedcmassaroT275944 Create Execution Environment for JavaScript
 ResolvedNoneT261470 Sandboxing and monitoring of evaluations
 ResolvedSimoneThisDotT291022 Validators for user-defined types can be defined and linked
 ResolvedJdforrester-WMFT291031 Validator implementations can call Z101/object validator, and then add to it
 ResolvedcmassaroT262997 Validate the values on the keys on a user-defined type
 ResolvedcmassaroT291030 Validator of a user-defined type can be implemented
 ResolvedcmassaroT291026 Let user implementations throw a user-defined error during a user-defined validation
 Resolved• AdesojiThisDotT293742 Navigate to "provide tests" after user define function, instead than to the newly defined object
 ResolvedgenghT287746 Update meta page about representation of errors with all the latest conversation/decisions
ResolvedgenghT288123 Re-work Z5/Error model and handling
 ResolvedgenghT287734 Replace wikilambda extension php validation code with call to schemata validation
 ResolvedcmassaroT276369 Create PHP bindings for function-schemata
 ResolvedcmassaroT289687 Allow users to create instances of errors in composition
 ResolvedgenghT287700 Make error generation code produce an understandable result when called with non-existent arguments

Event Timeline

DVrandecic created this task.Aug 25 2021, 1:59 PM
Jdforrester-WMF renamed this task from Need to create instances of errors in composition to Allow users to create instances of errors in composition.Aug 25 2021, 4:42 PM
DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Aug 25 2021, 4:43 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
Jdforrester-WMF added a parent task: T288123: Re-work Z5/Error model and handling.Sep 15 2021, 8:13 PM
DVrandecic triaged this task as Medium priority.Oct 6 2021, 4:39 PM
Jdforrester-WMF assigned this task to DVrandecic.Oct 27 2021, 4:54 PM
Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.
DVrandecic removed DVrandecic as the assignee of this task.Nov 3 2021, 4:21 PM
DVrandecic moved this task from QA / Ready to close to Needs discussion/DoD on the Abstract Wikipedia team (Phase η – Generic types) board.
Jdforrester-WMF added a parent task: T291026: Let user implementations throw a user-defined error during a user-defined validation.Nov 10 2021, 5:44 PM
DVrandecic moved this task from Needs discussion/DoD to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Nov 10 2021, 5:44 PM
Jdforrester-WMF subscribed.Jan 24 2022, 8:45 PM

Is this ready to do? I think this needs definition of what changes and what the DoD is.

Jdforrester-WMF added a comment.Jan 25 2022, 7:01 PM

In discussion with Cory, I think we should make this as a Z820/Raise metadata function that takes a Z6 and a Z1, and if the Z6 is 'error' injects the Z1 (a Z5) into the Z22K2 return value.

gerritbot added a comment.Jan 26 2022, 5:08 PM

Change 757096 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Add builtin throw function to allow user definition of errors in compositions.

https://gerrit.wikimedia.org/r/757096

gerritbot added a project: Patch-For-Review.Jan 26 2022, 5:08 PM
gerritbot added a comment.Jan 26 2022, 5:14 PM

Change 757096 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Add builtin throw function to allow user definition of errors in compositions.

https://gerrit.wikimedia.org/r/757096

cmassaro mentioned this in rMSFOa58ab3286ef9: Add builtin throw function to allow user definition of errors in compositions..Jan 26 2022, 5:15 PM
Jdforrester-WMF changed the task status from Open to In Progress.Jan 26 2022, 5:19 PM
Jdforrester-WMF assigned this task to cmassaro.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
Maintenance_bot removed a project: Patch-For-Review.Jan 26 2022, 6:11 PM
cmassaro moved this task from In progress to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Jan 26 2022, 8:19 PM
DVrandecic moved this task from QA / Ready to close to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Feb 8 2022, 5:27 PM
gerritbot added a comment.Feb 8 2022, 8:05 PM

Change 761041 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/services/function-schemata@master] definitions: Add Z820/Trigger Metadata and built-in implementation

https://gerrit.wikimedia.org/r/761041

gerritbot added a project: Patch-For-Review.Feb 8 2022, 8:05 PM
gerritbot added a comment.Feb 8 2022, 8:15 PM

Change 761041 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] definitions: Add Z820/Trigger Metadata and built-in implementation

https://gerrit.wikimedia.org/r/761041

Jdforrester-WMF mentioned this in rMSFS0d127c27192d: definitions: Add Z820/Trigger Metadata and built-in implementation.Feb 8 2022, 8:15 PM
Jdforrester-WMF updated the task description. (Show Details)Feb 8 2022, 8:33 PM
Jdforrester-WMF moved this task from Ready to do to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.
Maintenance_bot removed a project: Patch-For-Review.Feb 8 2022, 9:11 PM
gerritbot added a comment.Feb 9 2022, 9:50 PM

Change 761474 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (0d127c2)

https://gerrit.wikimedia.org/r/761474

gerritbot added a project: Patch-For-Review.Feb 9 2022, 9:50 PM

Change 761475 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (0d127c2)

https://gerrit.wikimedia.org/r/761475

gerritbot added a comment.Feb 9 2022, 9:52 PM

Change 761476 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (0d127c2)

https://gerrit.wikimedia.org/r/761476

gerritbot added a comment.Feb 10 2022, 4:10 PM

Change 761475 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (0d127c2)

https://gerrit.wikimedia.org/r/761475

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 10 2022, 5:00 PM
gerritbot added a comment.Feb 11 2022, 4:07 AM

Change 761474 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (0d127c2)

https://gerrit.wikimedia.org/r/761474

Jdforrester-WMF mentioned this in rMSFO630893949880: Update function-schemata sub-module to HEAD (0d127c2).Feb 11 2022, 4:07 AM
Jdforrester-WMF closed this task as Resolved.Feb 16 2022, 5:56 PM
gerritbot added a comment.Feb 17 2022, 9:20 PM

Change 761476 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (0d127c2)

https://gerrit.wikimedia.org/r/761476

cmassaro mentioned this in rMSFEa04ac6f67caf: Update function-schemata sub-module to HEAD (0d127c2).Feb 17 2022, 9:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL