Page MenuHomePhabricator
Create Task
Maniphest T275095

Move normalization and canonicalization code to function-schemata
Closed, ResolvedPublic
Actions

Description

The code for canonicalization currently lives both in PHP and JS, and the normalization code is in JS. It should both be moved to function-schemata and be hooked up with the tests for normalization and canonicalization there, and removed from the wiki and the orchestrator.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove canonicalization/normalization code that was moved to schematamediawiki/services/function-orchestratormaster+48 -193
Move canonicalization and normalization to function-schematamediawiki/services/function-schematamaster+336 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedNoneT273124 Use evaluation for validation
 OpenNoneT278201 Provide a "magic" UX mode
 OpenNoneT278202 Alter the function model to have optional "fromString" and "toString" functions for Types, to allow easier input/output&debugging
 ResolvedSimoneThisDotT261471 Provide Special:Evaluate (or similar title) special page where users can trigger a function evaluation
 ResolvedcmassaroT260321 Allow users to trigger function calls for built-in functions (orchestrator-only)
 ResolvedLindsaykwardellT280558 Normalize Inputs to Orchestrator
 ResolvedarthurlorenziT275095 Move normalization and canonicalization code to function-schemata
 ResolvedNoneT262770 Normalize ZObjects

Event Timeline

DVrandecic created this task.Feb 18 2021, 1:13 AM
DVrandecic moved this task from To Triage to Phase δ on the Abstract Wikipedia team board.Feb 24 2021, 5:16 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase δ); removed Abstract Wikipedia team.
arthurlorenzi claimed this task.Mar 31 2021, 5:40 PM
DVrandecic added a subtask: T262770: Normalize ZObjects.Apr 6 2021, 2:29 AM
DVrandecic triaged this task as High priority.Apr 7 2021, 4:50 AM
gerritbot added a comment.Apr 7 2021, 5:15 PM

Change 677596 had a related patch set uploaded (by Jforrester; author: Arthur Lorenzi):

[mediawiki/services/function-schemata@master] Move canonicalization and normalization to function-schemata

https://gerrit.wikimedia.org/r/677596

gerritbot added a project: Patch-For-Review.Apr 7 2021, 5:15 PM

Change 677600 had a related patch set uploaded (by Jforrester; author: Arthur Lorenzi):

[mediawiki/services/function-orchestrator@master] Remove canonicalization/normalization code that was moved to schemata

https://gerrit.wikimedia.org/r/677600

cmassaro added a parent task: T280558: Normalize Inputs to Orchestrator.Apr 19 2021, 4:02 PM
gerritbot added a comment.Apr 29 2021, 6:07 PM

Change 677596 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Move canonicalization and normalization to function-schemata

https://gerrit.wikimedia.org/r/677596

arthurlorenzi mentioned this in rMSFSfe73887775ca: Move canonicalization and normalization to function-schemata.Apr 29 2021, 6:32 PM
Jdforrester-WMF closed this task as Resolved.Apr 29 2021, 6:46 PM
gerritbot added a comment.Apr 29 2021, 6:47 PM

Change 677600 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Remove canonicalization/normalization code that was moved to schemata

https://gerrit.wikimedia.org/r/677600

arthurlorenzi mentioned this in rMSFOf259d1cfe1f7: Remove canonicalization/normalization code that was moved to schemata.Apr 29 2021, 6:52 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 29 2021, 7:11 PM
DVrandecic closed subtask T262770: Normalize ZObjects as Resolved.May 5 2021, 4:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits