Page MenuHomePhabricator
Create Task
Maniphest T260321

Allow users to trigger function calls for built-in functions (orchestrator-only)
Closed, ResolvedPublic
Actions

Description

Introduce the ability to write function calls and thus evaluate built-in functions. Unlike in Phase gamma, where we statically store the functions, here they actually need to be evaluated.

Details

SubjectRepoBranchLines +/-
Allow users to make API calls to the function orchestratormediawiki/extensions/WikiLambdamaster+786 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedNoneT273124 Use evaluation for validation
 OpenNoneT278201 Provide a "magic" UX mode
 OpenNoneT278202 Alter the function model to have optional "fromString" and "toString" functions for Types, to allow easier input/output&debugging
 ResolvedSimoneThisDotT261471 Provide Special:Evaluate (or similar title) special page where users can trigger a function evaluation
 ResolvedcmassaroT260321 Allow users to trigger function calls for built-in functions (orchestrator-only)
 ResolvedDVrandecicT261964 Agree on architecture for first evaluation engine
 ResolvedLindsaykwardellT280558 Normalize Inputs to Orchestrator
 ResolvedarthurlorenziT275095 Move normalization and canonicalization code to function-schemata
 ResolvedNoneT262770 Normalize ZObjects
 InvalidNoneT280559 Retrieve Function Signature from Orchestrator

Event Timeline

DVrandecic created this task.Aug 13 2020, 2:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2020, 2:09 AM
DVrandecic triaged this task as Low priority.Aug 20 2020, 12:33 AM
DVrandecic raised the priority of this task from Low to Medium.Aug 27 2020, 9:53 PM
DVrandecic updated the task description. (Show Details)Aug 27 2020, 10:31 PM
DVrandecic renamed this task from Function calls to Function calls (epic).Feb 27 2021, 12:47 AM
DVrandecic renamed this task from Function calls (epic) to Function calls.
DVrandecic raised the priority of this task from Medium to High.
DVrandecic added a project: Epic.
DVrandecic raised the priority of this task from High to Unbreak Now!.Feb 27 2021, 12:51 AM
tstarling subscribed.Mar 2 2021, 5:36 AM

Please do not use the Unbreak Now priority for things that are not actually urgent. I am reviewing all tasks with this priority every day.

thiemowmde lowered the priority of this task from Unbreak Now! to Needs Triage.Mar 2 2021, 8:43 AM
DVrandecic added a comment.Mar 10 2021, 1:18 AM
In T260321#6873427, @tstarling wrote:

Please do not use the Unbreak Now priority for things that are not actually urgent. I am reviewing all tasks with this priority every day.

Apologies! Won't do that anymore. Thanks for telling me.

DVrandecic triaged this task as High priority.Mar 24 2021, 1:52 PM
DVrandecic added a parent task: T273124: Use evaluation for validation.
DVrandecic added a parent task: T278202: Alter the function model to have optional "fromString" and "toString" functions for Types, to allow easier input/output&debugging.Mar 24 2021, 2:12 PM
Jdforrester-WMF renamed this task from Function calls to Function calls for built-in functions (orchestrator-only).Mar 30 2021, 6:05 PM
Jdforrester-WMF added projects: WikiLambda, function-orchestrator.
DVrandecic closed subtask T261964: Agree on architecture for first evaluation engine as Resolved.Mar 31 2021, 4:49 PM
DVrandecic lowered the priority of this task from High to Medium.Apr 7 2021, 4:08 PM
Jdforrester-WMF subscribed.Apr 13 2021, 7:48 PM

Testing this automatically in CI would be blocked by T280070: Provide a CI mechanism by which we can test end-to-end integration between MW and back-end services, e.g. via docker-compose.

cmassaro closed subtask T280559: Retrieve Function Signature from Orchestrator as Invalid.Apr 20 2021, 6:05 PM
cmassaro claimed this task.Apr 21 2021, 4:28 PM
DVrandecic raised the priority of this task from Medium to High.Apr 21 2021, 4:28 PM
gerritbot added a comment.Apr 29 2021, 11:06 PM

Change 679375 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Allow users to make API calls to the function orchestrator

https://gerrit.wikimedia.org/r/679375

gerritbot added a project: Patch-For-Review.Apr 29 2021, 11:06 PM
gerritbot added a comment.Apr 29 2021, 11:18 PM

Change 679375 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Allow users to make API calls to the function orchestrator

https://gerrit.wikimedia.org/r/679375

Maintenance_bot removed a project: Patch-For-Review.Apr 30 2021, 12:10 AM
Jdforrester-WMF added a comment.Apr 30 2021, 12:24 AM

@cmassaro, are you thinking that we want to close out the "blocker" tasks (T280558 and its sub-tasks) before we call this done?

cmassaro added a comment.May 3 2021, 4:43 PM
In T260321#7047832, @Jdforrester-WMF wrote:

@cmassaro, are you thinking that we want to close out the "blocker" tasks (T280558 and its sub-tasks) before we call this done?

Yes. While this is technically done--you can call built-in functions within the orchestrator--it's prohibitively difficult to actually do so until the blockers are done.

Maybe we can change the title to "Call built-in functions via MediaWiki API" or something?

Jdforrester-WMF renamed this task from Function calls for built-in functions (orchestrator-only) to Allow users to trigger function calls for built-in functions (orchestrator-only).May 3 2021, 6:26 PM
In T260321#7053935, @cmassaro wrote:
In T260321#7047832, @Jdforrester-WMF wrote:

@cmassaro, are you thinking that we want to close out the "blocker" tasks (T280558 and its sub-tasks) before we call this done?

Yes. While this is technically done--you can call built-in functions within the orchestrator--it's prohibitively difficult to actually do so until the blockers are done.

Maybe we can change the title to "Call built-in functions via MediaWiki API" or something?

I think it's fine to keep this open until those bits are done, no worries. I've re-titled it to follow our naming conventions more clearly.

Jdforrester-WMF added a parent task: T261471: Provide Special:Evaluate (or similar title) special page where users can trigger a function evaluation.May 6 2021, 4:18 PM
Jdforrester-WMF closed subtask T280558: Normalize Inputs to Orchestrator as Resolved.May 6 2021, 8:13 PM
Jdforrester-WMF closed this task as Resolved.May 7 2021, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL