Page MenuHomePhabricator

Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code
Closed, ResolvedPublic

Description

… instead of local bespoke stuff.

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
StalledNone
Resolvedcmassaro
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
Resolvedcmassaro
OpenNone
ResolvedNone
ResolvedNone
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
Resolvedgengh
Resolvedgengh
DeclinedLindsaykwardell
ResolvedLindsaykwardell
Resolvedcmassaro
Resolvedcmassaro
ResolvedSimoneThisDot
ResolvedJdforrester-WMF
ResolvedDVrandecic
ResolvedNone
ResolvedNone
Resolvedcmassaro
ResolvedDVrandecic
ResolvedLindsaykwardell
Resolvedarthurlorenzi
ResolvedNone
InvalidNone
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedgengh
Resolvedcmassaro
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedDVrandecic
Resolvedcmassaro
Resolvedarthurlorenzi
ResolvedAdesojiThisDot

Event Timeline

Jdforrester-WMF added a subscriber: cmassaro.

This would involve pulling in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/function-schemata/+/refs/heads/master as a git submodule and using the PHP bindings that @cmassaro put there to validate inputs from the json-schema files.

(This probably means we'll need to change our CI to use the local composer rather than production vendor quibble jobs.)

DVrandecic triaged this task as Medium priority.May 5 2021, 4:49 PM

Change 706380 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Inherit the composer dependencies from function-schemata sub-module

https://gerrit.wikimedia.org/r/706380

Change 706380 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Inherit the composer dependencies from function-schemata sub-module

https://gerrit.wikimedia.org/r/706380