Page MenuHomePhabricator
Create Task
Maniphest T281386

Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code
Closed, ResolvedPublic
Actions

Description

… instead of local bespoke stuff.

Details

SubjectRepoBranchLines +/-
Inherit the composer dependencies from function-schemata sub-modulemediawiki/extensions/WikiLambdamaster+9 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedcmassaroT290898 Implement (De)Serialization for Generic/Compound Types
 DeclinedNoneT287608 Reconsider dropping Nothing and Unit in favor of Maybe
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedcmassaroT288555 Support serialisation/deserialisation of user-defined types
 ResolvedcmassaroT287263 Deserialize Objects in Evaluator Based on Z7K1.Z8K2
 ResolvedNoneT275941 Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types")
 ResolvedgenghT277000 Validate a Z7/Function call in the wiki
 ResolvedgenghT281386 Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code
 DeclinedLindsaykwardellT282745 Add function-schemata to frontend in order to remedy hybrid forms
 ResolvedLindsaykwardellT282816 Use canonicalizer to display JSON
 ResolvedcmassaroT284474 Add tests for normalize/canonicalize code in frontend.
 ResolvedcmassaroT284764 Fix Canonicalization Code in Frontend to Handle Z6s That Masquerade as Z9s
 ResolvedSimoneThisDotT291023 Instances of user-defined types can be entered using the default component
 ResolvedJdforrester-WMFT291029 Instances of a user-defined type can be edited
 ResolvedDVrandecicT291025 Make it possible to define and implement functions using user-defined types as output or an input type
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 ResolvedNoneT273124 Use evaluation for validation
 ResolvedcmassaroT260321 Allow users to trigger function calls for built-in functions (orchestrator-only)
 ResolvedDVrandecicT261964 Agree on architecture for first evaluation engine
 ResolvedLindsaykwardellT280558 Normalize Inputs to Orchestrator
 ResolvedarthurlorenziT275095 Move normalization and canonicalization code to function-schemata
 ResolvedNoneT262770 Normalize ZObjects
 InvalidNoneT280559 Retrieve Function Signature from Orchestrator
 ResolvedcmassaroT282843 Hook up orchestrator to the evaluator and pass through appropriately-dereferenced Z7 calls
 ResolvedcmassaroT271762 Create initial Function Evaluator service
 ResolvedcmassaroT269697 Turn Function Evaluator into a service
 ResolvedcmassaroT269698 Make Function Evaluator work async
 ResolvedcmassaroT272630 Define interface for the function-evaluator
 ResolvedJdforrester-WMFT276478 Provide "semantically peel-able" list of programming languages that we allow
 ResolvedcmassaroT273515 Create Execution Environments for Supported Languages
 ResolvedcmassaroT273517 Create Execution Environment for Python
 ResolvedcmassaroT275944 Create Execution Environment for JavaScript
 ResolvedNoneT261470 Sandboxing and monitoring of evaluations
 ResolvedSimoneThisDotT291022 Validators for user-defined types can be defined and linked
 ResolvedSimoneThisDotT291021 Make the UX for creating a user-defined type straightforward
 ResolvedSimoneThisDotT292891 Provide a custom UX for Z4/Type
 ResolvedJdforrester-WMFT291031 Validator implementations can call Z101/object validator, and then add to it
 ResolvedcmassaroT262997 Validate the values on the keys on a user-defined type
 ResolvedgenghT287734 Replace wikilambda extension php validation code with call to schemata validation
 ResolvedcmassaroT276369 Create PHP bindings for function-schemata
 ResolvedJdforrester-WMFT293831 WikiLambda documentation should explain how to get composer dependencies installed, lest users have missing ISchemaLoader fatals
 ResolvedcmassaroT291030 Validator of a user-defined type can be implemented
 ResolvedcmassaroT291026 Let user implementations throw a user-defined error during a user-defined validation
 ResolvedNoneT291027 Users can create error types
 ResolvedDVrandecicT293423 Create a function that turns an error type into a type
 ResolvedcmassaroT289687 Allow users to create instances of errors in composition
 ResolvedarthurlorenziT290346 Function model: Change the signature of validators from Type -> List to Type -> Type (pass-through)
 Resolved• AdesojiThisDotT293742 Navigate to "provide tests" after user define function, instead than to the newly defined object

Event Timeline

Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.Apr 28 2021, 4:29 PM
Jdforrester-WMF created this task.
Jdforrester-WMF added a subtask: T276369: Create PHP bindings for function-schemata.Apr 28 2021, 8:14 PM
Jdforrester-WMF added a subscriber: cmassaro.

This would involve pulling in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/function-schemata/+/refs/heads/master as a git submodule and using the PHP bindings that @cmassaro put there to validate inputs from the json-schema files.

Jdforrester-WMF added a comment.Apr 28 2021, 8:16 PM

(This probably means we'll need to change our CI to use the local composer rather than production vendor quibble jobs.)

Jdforrester-WMF moved this task from Phase δ to To triage: Un-phased work on the Abstract Wikipedia team board.May 5 2021, 4:01 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase δ).
DVrandecic triaged this task as Medium priority.May 5 2021, 4:49 PM
Jdforrester-WMF added a subtask: T282745: Add function-schemata to frontend in order to remedy hybrid forms.Jun 1 2021, 11:51 PM
Jdforrester-WMF mentioned this in T277000: Validate a Z7/Function call in the wiki.Jun 7 2021, 8:54 PM
DVrandecic closed subtask T282745: Add function-schemata to frontend in order to remedy hybrid forms as Declined.Jun 9 2021, 4:27 PM
gerritbot added a comment.Jul 22 2021, 11:07 AM

Change 706380 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Inherit the composer dependencies from function-schemata sub-module

https://gerrit.wikimedia.org/r/706380

gerritbot added a project: Patch-For-Review.Jul 22 2021, 11:07 AM
gerritbot added a comment.Jul 26 2021, 4:17 PM

Change 706380 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Inherit the composer dependencies from function-schemata sub-module

https://gerrit.wikimedia.org/r/706380

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2021, 5:11 PM
Jdforrester-WMF removed a parent task: T279590: Define Z13/Empty list with special handling.Aug 4 2021, 5:10 PM
Jdforrester-WMF added a subtask: T287734: Replace wikilambda extension php validation code with call to schemata validation.
Jdforrester-WMF removed a subtask: T276369: Create PHP bindings for function-schemata.
Jdforrester-WMF added a parent task: T277000: Validate a Z7/Function call in the wiki.
Jdforrester-WMF moved this task from To triage: Un-phased work to Phase η – Generic types on the Abstract Wikipedia team board.Sep 14 2021, 8:12 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
gengh claimed this task.Sep 15 2021, 2:58 PM
Jdforrester-WMF changed the status of subtask T287734: Replace wikilambda extension php validation code with call to schemata validation from Open to In Progress.Sep 15 2021, 7:17 PM
Jdforrester-WMF closed subtask T287734: Replace wikilambda extension php validation code with call to schemata validation as Resolved.Oct 19 2021, 7:46 PM
Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Oct 25 2021, 5:46 PM
DVrandecic closed this task as Resolved.Oct 27 2021, 4:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits