Page MenuHomePhabricator
Create Task
Maniphest T282816

Use canonicalizer to display JSON
Closed, ResolvedPublic
Actions

Description

The front end displays JSON to the end-user in JSON mode and other places.

This JSON should be in the canonical format to make it a bit easier to read.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedcmassaroT290898 Implement (De)Serialization for Generic/Compound Types
 DeclinedNoneT287608 Reconsider dropping Nothing and Unit in favor of Maybe
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedcmassaroT288555 Support serialisation/deserialisation of user-defined types
 ResolvedcmassaroT287263 Deserialize Objects in Evaluator Based on Z7K1.Z8K2
 ResolvedNoneT275941 Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types")
 ResolvedgenghT277000 Validate a Z7/Function call in the wiki
 ResolvedgenghT281386 Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code
 ResolvedSimoneThisDotT291023 Instances of user-defined types can be entered using the default component
 ResolvedJdforrester-WMFT291029 Instances of a user-defined type can be edited
 ResolvedDVrandecicT291025 Make it possible to define and implement functions using user-defined types as output or an input type
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 ResolvedNoneT273124 Use evaluation for validation
 ResolvedcmassaroT260321 Allow users to trigger function calls for built-in functions (orchestrator-only)
 ResolvedDVrandecicT261964 Agree on architecture for first evaluation engine
 ResolvedLindsaykwardellT280558 Normalize Inputs to Orchestrator
 ResolvedarthurlorenziT275095 Move normalization and canonicalization code to function-schemata
 ResolvedNoneT262770 Normalize ZObjects
 InvalidNoneT280559 Retrieve Function Signature from Orchestrator
 ResolvedcmassaroT282843 Hook up orchestrator to the evaluator and pass through appropriately-dereferenced Z7 calls
 ResolvedcmassaroT271762 Create initial Function Evaluator service
 ResolvedcmassaroT269697 Turn Function Evaluator into a service
 ResolvedcmassaroT269698 Make Function Evaluator work async
 ResolvedcmassaroT272630 Define interface for the function-evaluator
 ResolvedJdforrester-WMFT276478 Provide "semantically peel-able" list of programming languages that we allow
 ResolvedcmassaroT273515 Create Execution Environments for Supported Languages
 ResolvedcmassaroT273517 Create Execution Environment for Python
 ResolvedcmassaroT275944 Create Execution Environment for JavaScript
 ResolvedNoneT261470 Sandboxing and monitoring of evaluations
 ResolvedSimoneThisDotT291022 Validators for user-defined types can be defined and linked
 ResolvedSimoneThisDotT291021 Make the UX for creating a user-defined type straightforward
 ResolvedSimoneThisDotT292891 Provide a custom UX for Z4/Type
 ResolvedJdforrester-WMFT291031 Validator implementations can call Z101/object validator, and then add to it
 ResolvedcmassaroT262997 Validate the values on the keys on a user-defined type
 ResolvedgenghT287734 Replace wikilambda extension php validation code with call to schemata validation
 ResolvedcmassaroT276369 Create PHP bindings for function-schemata
 ResolvedJdforrester-WMFT293831 WikiLambda documentation should explain how to get composer dependencies installed, lest users have missing ISchemaLoader fatals
 ResolvedcmassaroT291030 Validator of a user-defined type can be implemented
 ResolvedcmassaroT291026 Let user implementations throw a user-defined error during a user-defined validation
 ResolvedNoneT291027 Users can create error types
 ResolvedDVrandecicT293423 Create a function that turns an error type into a type
 ResolvedcmassaroT289687 Allow users to create instances of errors in composition
 ResolvedarthurlorenziT290346 Function model: Change the signature of validators from Type -> List to Type -> Type (pass-through)
 Resolved• AdesojiThisDotT293742 Navigate to "provide tests" after user define function, instead than to the newly defined object
 ResolvedNoneT277925 Provide a validator for Z14/Implementation in the editing experience
 DeclinedLindsaykwardellT282745 Add function-schemata to frontend in order to remedy hybrid forms
 DeclinedNoneT282815 Make function schemata available to the front-end
 ResolvedLindsaykwardellT282816 Use canonicalizer to display JSON
 ResolvedcmassaroT284474 Add tests for normalize/canonicalize code in frontend.
 ResolvedcmassaroT284764 Fix Canonicalization Code in Frontend to Handle Z6s That Masquerade as Z9s

Event Timeline

DVrandecic created this task.May 13 2021, 7:10 PM
DVrandecic renamed this task from Use the canonicalizer to display the JSON to Use canonicalizer to display JSON.May 13 2021, 8:09 PM
DVrandecic added a project: WikiLambda Front-end.
DVrandecic updated the task description. (Show Details)
DVrandecic added a parent task: T282815: Make function schemata available to the front-end.
DVrandecic moved this task from To triage to To triage: Un-phased work on the Abstract Wikipedia team board.May 26 2021, 4:46 PM
Jdforrester-WMF added a project: WikiLambda.May 26 2021, 4:47 PM
Lindsaykwardell subscribed.Jun 7 2021, 2:56 PM

This task is mostly complete, as I have a canonicalize function in the UI that performs this task. It is not reliant on the function-schemata at this time. I'm unsure whether the two canonicalize functions can be combined, as they handle different use cases (the canonicalizer in the frontend also handles undefined keys, for example, and has no additional validation/error reporting).

Lindsaykwardell claimed this task.Jun 7 2021, 2:57 PM
Lindsaykwardell added a comment.Jun 8 2021, 1:47 PM

Based on our meeting yesterday, and Cory's work on implementing the schemata tests in the UI, I think we can safely say that this task is complete once the tests are in place.

Lindsaykwardell added a subtask: T284474: Add tests for normalize/canonicalize code in frontend..Jun 8 2021, 1:49 PM
Lindsaykwardell added a parent task: T282745: Add function-schemata to frontend in order to remedy hybrid forms.
Lindsaykwardell closed subtask T284474: Add tests for normalize/canonicalize code in frontend. as Resolved.Jun 22 2021, 6:34 PM
Lindsaykwardell closed this task as Resolved.Jun 23 2021, 9:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL