Page MenuHomePhabricator
Create Task
Maniphest T277000

Validate a Z7/Function call in the wiki
Closed, ResolvedPublic
Actions

Description

Z7 is a bit different than the others, in particular it has keys that are defined on the Function instead of the Type. It would be good to check that.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT278321 Provide a special page listing invalid ZObjects
 OpenNoneT278318 Let users validate an unstored ZObject / edit on a ZObject
 StalledNoneT269177 ZObject DAO should have a isWellFormed method
 ResolvedcmassaroT260861 Use the orchestrator/evaluator to validate instances of each Z4/Type using on-wiki defined Z8/Functions instead of hard-coded
OpenNoneT278316 Provide a validation API endpoint for arbitrary ZObjects from both MediaWiki and the orchestrator
 OpenNoneT292240 Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not
 OpenNoneT278325 Store that a page contains an invalid ZObject in a tracking table
 OpenNoneT278320 Allow to store an invalid ZObject explicitly, so we can have failure examples for Validator functions' Testers
 OpenNoneT294045 Create a "Validate" Endpoint in Orchestrator
 DuplicateNoneT273125 Migrate hard-coded validators to validation defined on-wiki
 OpenNoneT278319 Provide functionality for users to trigger a re-validation of a stored object
 ResolvedcmassaroT290898 Implement (De)Serialization for Generic/Compound Types
 DeclinedNoneT287608 Reconsider dropping Nothing and Unit in favor of Maybe
 ResolvedNoneT290119 Phase η root task
 ResolvedNoneT290118 User-defined types work with validation
 ResolvedcmassaroT288555 Support serialisation/deserialisation of user-defined types
 ResolvedcmassaroT287263 Deserialize Objects in Evaluator Based on Z7K1.Z8K2
 ResolvedNoneT275941 Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types")
 ResolvedgenghT277000 Validate a Z7/Function call in the wiki
 ResolvedgenghT281386 Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code
 DeclinedLindsaykwardellT282745 Add function-schemata to frontend in order to remedy hybrid forms
 ResolvedLindsaykwardellT282816 Use canonicalizer to display JSON
 ResolvedcmassaroT284474 Add tests for normalize/canonicalize code in frontend.
 ResolvedcmassaroT284764 Fix Canonicalization Code in Frontend to Handle Z6s That Masquerade as Z9s
 ResolvedNoneT291033 A function call used as an argument should validate its return type against the expected type of the argument
 ResolvedNoneT291034 Every argument of a function call with a literal or reference should be of a type compatible for that argument
 ResolvedgenghT287700 Make error generation code produce an understandable result when called with non-existent arguments
 ResolvedcmassaroT291032 Arguments taking a function should validate functions as values
 ResolvedNoneT291040 Generic functions
 InvalidNoneT291037 Function model: update functions to the new generic types
 InvalidgenghT291038 Function model: updates to the data model to implement generic types
 ResolvedDVrandecicT287196 Update Pre-Generic Function Model
 ResolvedDVrandecicT287195 Function model: Z21 should be updated to be the null value of Unit
 ResolvedDVrandecicT287194 Function model: Z8K5 is a Z8/Function not a Z6/String, regardless of what our code says
 ResolvedSimoneThisDotT303302 Validate that the UX works with typed list for core types (e.g. Z4 has a typed list of Z3s)
 ResolvedSimoneThisDotT304101 Change the Type UX so that it works (viewing/creating/editing) with a typed list of Z3s for Z4K2
Resolved• JKiesermanT303303 Change the pre-defined core types to use typed lists and not general lists
 ResolvedNoneT291039 Functions using generic types as input types or output type can be defined and implemented
 ResolvedNoneT291045 Function created by a generic function call can be evaluated
 ResolvedJdforrester-WMFT291046 Generic functions can be evaluated
 ResolvedNoneT291047 Generic functions can be implemented
 ResolvedNoneT291048 Generic functions can be defined
 DeclinedNoneT291036 Function model: Z8 should change from a type to a function taking a type and a list of types and returning a type
 ResolvedSimoneThisDotT291041 Instances of a generic type are displayed correctly
 ResolvedSimoneThisDotT291042 Instances of generic types can be edited
 ResolvedcmassaroT291044 Instances of generic types are being validated
 ResolvedcmassaroT285260 Orchestrator Top-Level Validation Should Check Z1K1
 ResolvedSimoneThisDotT297244 Let front-end users create and edit instances of any generic type
 ResolvedSimoneThisDotT291043 Instances of generic typed lists can be created
 ResolvedcmassaroT266241 Normalizer and canonicalizer should deal with local and global keys
 ResolvedcmassaroT289681 Composition creating a type doesn't evaluate
 ResolvedBUG REPORTJdforrester-WMFT292890 Trying to create a Z14 throws "Cannot read properties of undefined (reading 'filter')" in Vue code
 ResolvedSimoneThisDotT295470 Change the type search API to allow users to search for functions returning a type in addition to instances of that type
 ResolvedgenghT262089 Store type identity output in wikilambda_zobject_labels table
ResolvedgenghT297925 Change object search API to optionally include functions' return types as the 'type' filter
 ResolvedcmassaroT286975 Make it possible to define the Typed List function fully
 ResolvedcmassaroT287102 Resolve Z18s Wherever They Occur
 ResolvedJdforrester-WMFT291049 Function that takes a type and returns a type can be evaluated
 ResolvedDVrandecicT291050 Functions that take a type and return a type can be implemented
 ResolvedDVrandecicT291051 Functions that take a type and return a type can be defined
 ResolvedJdforrester-WMFT293663 Fix instancePath vs. dataPath in function-schemata, Add Tests
 ResolvedSimoneThisDotT291023 Instances of user-defined types can be entered using the default component
 ResolvedJdforrester-WMFT291029 Instances of a user-defined type can be edited
 ResolvedDVrandecicT291025 Make it possible to define and implement functions using user-defined types as output or an input type
 ResolvedNoneT291028 Instances of a user-defined type which should not validate indeed do not validate
 ResolvedNoneT273124 Use evaluation for validation
 ResolvedcmassaroT260321 Allow users to trigger function calls for built-in functions (orchestrator-only)
 ResolvedDVrandecicT261964 Agree on architecture for first evaluation engine
 ResolvedLindsaykwardellT280558 Normalize Inputs to Orchestrator
 ResolvedarthurlorenziT275095 Move normalization and canonicalization code to function-schemata
 ResolvedNoneT262770 Normalize ZObjects
 InvalidNoneT280559 Retrieve Function Signature from Orchestrator
 ResolvedcmassaroT282843 Hook up orchestrator to the evaluator and pass through appropriately-dereferenced Z7 calls
 ResolvedcmassaroT271762 Create initial Function Evaluator service
 ResolvedcmassaroT269697 Turn Function Evaluator into a service
 ResolvedcmassaroT269698 Make Function Evaluator work async
 ResolvedcmassaroT272630 Define interface for the function-evaluator
 ResolvedJdforrester-WMFT276478 Provide "semantically peel-able" list of programming languages that we allow
 ResolvedcmassaroT273515 Create Execution Environments for Supported Languages
 ResolvedcmassaroT273517 Create Execution Environment for Python
 ResolvedcmassaroT275944 Create Execution Environment for JavaScript
 ResolvedNoneT261470 Sandboxing and monitoring of evaluations
 ResolvedSimoneThisDotT291022 Validators for user-defined types can be defined and linked
 ResolvedSimoneThisDotT291021 Make the UX for creating a user-defined type straightforward
 ResolvedSimoneThisDotT292891 Provide a custom UX for Z4/Type
 ResolvedJdforrester-WMFT291031 Validator implementations can call Z101/object validator, and then add to it
 ResolvedcmassaroT262997 Validate the values on the keys on a user-defined type
 ResolvedgenghT287734 Replace wikilambda extension php validation code with call to schemata validation
 ResolvedcmassaroT276369 Create PHP bindings for function-schemata
 ResolvedJdforrester-WMFT293831 WikiLambda documentation should explain how to get composer dependencies installed, lest users have missing ISchemaLoader fatals
 ResolvedcmassaroT291030 Validator of a user-defined type can be implemented
 ResolvedcmassaroT291026 Let user implementations throw a user-defined error during a user-defined validation
 ResolvedNoneT291027 Users can create error types
 ResolvedDVrandecicT293423 Create a function that turns an error type into a type
 ResolvedcmassaroT289687 Allow users to create instances of errors in composition
 ResolvedarthurlorenziT290346 Function model: Change the signature of validators from Type -> List to Type -> Type (pass-through)
 Resolved• AdesojiThisDotT293742 Navigate to "provide tests" after user define function, instead than to the newly defined object

Event Timeline

DVrandecic created this task.Mar 10 2021, 1:39 AM
DVrandecic moved this task from To triage to Phase δ on the Abstract Wikipedia team board.Mar 10 2021, 5:26 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase δ); removed Abstract Wikipedia team.
Jdforrester-WMF added a project: WikiLambda.Mar 24 2021, 8:30 PM
DVrandecic triaged this task as Lowest priority.Apr 7 2021, 4:51 AM
DVrandecic moved this task from Phase δ to Phase ε on the Abstract Wikipedia team board.May 5 2021, 1:03 AM
DVrandecic edited projects, added Abstract Wikipedia team (Phase ε); removed Abstract Wikipedia team (Phase δ).
DVrandecic moved this task from Phase ε to To triage: Un-phased work on the Abstract Wikipedia team board.May 5 2021, 7:52 PM
DVrandecic edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase ε).
SimoneThisDot claimed this task.May 19 2021, 7:21 AM
SimoneThisDot added a comment.May 24 2021, 8:28 AM

@DVrandecic Can you please check that the above is not fulfilled?

Due to a recent patch we merged in, when selecting a Function within a Function Call component will automatically PREFILL all the types and argument required by that fuction!

Doing so is like "validating" the function as the type are preset and cannot be changed.

Not sure if you also want to add extra validation before sending it over to the functionEvaluator

Lindsaykwardell added subscribers: Jdforrester-WMF, Lindsaykwardell.Jun 7 2021, 8:48 PM

I believe we determined that this was sufficient validation for the UI, and that this task can be closed. Can you confirm @DVrandecic @Jdforrester-WMF?

Jdforrester-WMF added a comment.Jun 7 2021, 8:54 PM

We don't validate Z7s when we try to save them, however (so API edits could be constructed that are invalid), so not sure if this counts as done yet. When we switch the PHP validation over to use schemata's code, which is T281386, this will be done there; I think we can wait for that?

Jdforrester-WMF added a subtask: T281386: Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code.Aug 4 2021, 5:11 PM
Jdforrester-WMF removed SimoneThisDot as the assignee of this task.Sep 14 2021, 8:12 PM
Jdforrester-WMF moved this task from To triage: Un-phased work to Phase η – Generic types on the Abstract Wikipedia team board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
Jdforrester-WMF added a subscriber: SimoneThisDot.
Jdforrester-WMF added a parent task: T291033: A function call used as an argument should validate its return type against the expected type of the argument.Sep 15 2021, 9:43 PM
Jdforrester-WMF edited parent tasks, added: T275941: Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types"); removed: T291033: A function call used as an argument should validate its return type against the expected type of the argument.
Jdforrester-WMF added a subtask: T291033: A function call used as an argument should validate its return type against the expected type of the argument.
DVrandecic added subtasks: T291034: Every argument of a function call with a literal or reference should be of a type compatible for that argument, T291032: Arguments taking a function should validate functions as values.Sep 15 2021, 9:46 PM
Jdforrester-WMF added a subtask: T293663: Fix instancePath vs. dataPath in function-schemata, Add Tests.Oct 20 2021, 11:01 PM
DVrandecic closed subtask T281386: Use the formal ZObject validation definitions from the function-schemata repo in the ZObjectFactory validation code as Resolved.Oct 27 2021, 4:15 PM
Jdforrester-WMF closed subtask T293663: Fix instancePath vs. dataPath in function-schemata, Add Tests as Resolved.Feb 16 2022, 6:03 PM
Jdforrester-WMF closed this task as Resolved.Mar 1 2022, 7:05 PM
Jdforrester-WMF assigned this task to gengh.
Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.

This is over-taken by events, with Geno's work on moving to orchestrator-based validation.

DVrandecic closed subtask T291032: Arguments taking a function should validate functions as values as Resolved.Mar 8 2022, 5:22 PM
DVrandecic closed subtask T291033: A function call used as an argument should validate its return type against the expected type of the argument as Resolved.Mar 8 2022, 5:25 PM
DVrandecic closed subtask T291034: Every argument of a function call with a literal or reference should be of a type compatible for that argument as Resolved.Mar 8 2022, 5:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL