Page MenuHomePhabricator

Validate a Z7/Function call in the wiki
Closed, ResolvedPublic

Description

Z7 is a bit different than the others, in particular it has keys that are defined on the Function instead of the Type. It would be good to check that.

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
StalledNone
Resolvedcmassaro
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
Resolvedcmassaro
OpenNone
ResolvedNone
ResolvedNone
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
Resolvedgengh
Resolvedgengh
DeclinedLindsaykwardell
ResolvedLindsaykwardell
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedNone
Resolvedgengh
Resolvedcmassaro
ResolvedNone
InvalidNone
Invalidgengh
ResolvedDVrandecic
ResolvedDVrandecic
ResolvedDVrandecic
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedJKieserman
ResolvedNone
ResolvedNone
ResolvedJdforrester-WMF
ResolvedNone
ResolvedNone
DeclinedNone
ResolvedSimoneThisDot
ResolvedSimoneThisDot
Resolvedcmassaro
Resolvedcmassaro
ResolvedSimoneThisDot
ResolvedSimoneThisDot
Resolvedcmassaro
Resolvedcmassaro
ResolvedBUG REPORTJdforrester-WMF
ResolvedSimoneThisDot
Resolvedgengh
Resolvedgengh
Resolvedcmassaro
Resolvedcmassaro
ResolvedJdforrester-WMF
ResolvedDVrandecic
ResolvedDVrandecic
ResolvedJdforrester-WMF
ResolvedSimoneThisDot
ResolvedJdforrester-WMF
ResolvedDVrandecic
ResolvedNone
ResolvedNone
Resolvedcmassaro
ResolvedDVrandecic
ResolvedLindsaykwardell
Resolvedarthurlorenzi
ResolvedNone
InvalidNone
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedSimoneThisDot
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedgengh
Resolvedcmassaro
ResolvedJdforrester-WMF
Resolvedcmassaro
Resolvedcmassaro
ResolvedNone
ResolvedDVrandecic
Resolvedcmassaro
Resolvedarthurlorenzi
ResolvedAdesojiThisDot

Event Timeline

DVrandecic triaged this task as Lowest priority.Apr 7 2021, 4:51 AM

@DVrandecic Can you please check that the above is not fulfilled?

Due to a recent patch we merged in, when selecting a Function within a Function Call component will automatically PREFILL all the types and argument required by that fuction!

Doing so is like "validating" the function as the type are preset and cannot be changed.

Not sure if you also want to add extra validation before sending it over to the functionEvaluator

I believe we determined that this was sufficient validation for the UI, and that this task can be closed. Can you confirm @DVrandecic @Jdforrester-WMF?

We don't validate Z7s when we try to save them, however (so API edits could be constructed that are invalid), so not sure if this counts as done yet. When we switch the PHP validation over to use schemata's code, which is T281386, this will be done there; I think we can wait for that?

Jdforrester-WMF assigned this task to gengh.

This is over-taken by events, with Geno's work on moving to orchestrator-based validation.