Page MenuHomePhabricator

Drop PreferenceMentorStore
Closed, ResolvedPublic

Description

Since we use DatabaseMentorStore for quite some time now, there should be no need for PreferenceMentorStore. The migration happened in MW-1.37-release, so we should be free to do incompatible changes (after all, GE is likely unused outside of WMF).

This will make implementation of backup mentors for T280307 easier.

Event Timeline

Change 721577 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] ApiSetMentorTest: Do not use PreferenceMentorStore

https://gerrit.wikimedia.org/r/721577

Change 721578 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Hard deprecate PreferenceMentorStore load/save methods

https://gerrit.wikimedia.org/r/721578

Change 721579 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Require $wgGEMentorshipMigrationStage to be SCHEMA_COMPAT_NEW

https://gerrit.wikimedia.org/r/721579

Change 721584 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Hard-deprecate GrowthExperimentsServices::getPreferenceMentorStore

https://gerrit.wikimedia.org/r/721584

Change 721584 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] Hard-deprecate GrowthExperimentsServices::getPreferenceMentorStore

Reason:

https://gerrit.wikimedia.org/r/721584

Change 721588 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Drop PreferenceMentorStore

https://gerrit.wikimedia.org/r/721588

Change 721781 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Remove MigrateMentorMenteeRelationship from SchemaHooks

https://gerrit.wikimedia.org/r/721781

Change 721583 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Stop using MultiWriteMentorStore

https://gerrit.wikimedia.org/r/721583

Change 721783 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Hard deprecate PreferenceMentorStore service

https://gerrit.wikimedia.org/r/721783

Change 721943 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] tests: Do not directly save MENTOR_PREF in integration tests

https://gerrit.wikimedia.org/r/721943

The code should be ready now (assuming Jenkins approves of it :)). The plan is to:

  1. First, merge all patches but the dropping one (721588)
  2. Inform train conductors about a risky patch running the train, and ask for any deprecation relating to GrowthExperiments' own code to block current train (that'd mean something still calls preference mentor store for some weird reason; should not happen)
  3. Wait for a train to deploy them to production
  4. Fix any issues appearing in production logs relating to this action
  5. Merge the dropping patch (721588)
  6. Declare this task done

I'm marking this task as blocking to T280307, as it is not worth our time to implement backup mentor in PreferenceMentorStore.

Change 721577 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ApiSetMentorTest: Do not use PreferenceMentorStore

https://gerrit.wikimedia.org/r/721577

Change 721943 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Do not directly save MENTOR_PREF in integration tests

https://gerrit.wikimedia.org/r/721943

Change 721579 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Require $wgGEMentorshipMigrationStage to be SCHEMA_COMPAT_NEW

https://gerrit.wikimedia.org/r/721579

Change 721578 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Hard deprecate PreferenceMentorStore load/save methods

https://gerrit.wikimedia.org/r/721578

Change 721583 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Stop using MultiWriteMentorStore

https://gerrit.wikimedia.org/r/721583

Change 721781 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove MigrateMentorMenteeRelationship from SchemaHooks

https://gerrit.wikimedia.org/r/721781

Change 721783 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Hard deprecate PreferenceMentorStore service

https://gerrit.wikimedia.org/r/721783

kostajh added a subscriber: kostajh.

@Urbanecm_WMF could you please comment about what type of QA, if any, should happen next?

@Urbanecm_WMF could you please comment about what type of QA, if any, should happen next?

Basically make sure there are no new deprecated messages about GrowthExperiments. I think releng would already catch that though.

Change 721588 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Drop PreferenceMentorStore and MultiWriteMentorStore

https://gerrit.wikimedia.org/r/721588

Urbanecm_WMF removed a project: Patch-For-Review.

Nothing broke, code is removed => calling this resolved.