Page MenuHomePhabricator
Create Task
Maniphest T291188

Drop PreferenceMentorStore
Closed, ResolvedPublic
Actions

Description

Since we use DatabaseMentorStore for quite some time now, there should be no need for PreferenceMentorStore. The migration happened in MW-1.37-release, so we should be free to do incompatible changes (after all, GE is likely unused outside of WMF).

This will make implementation of backup mentors for T280307 easier.

Details

SubjectRepoBranchLines +/-
Drop PreferenceMentorStore and MultiWriteMentorStoremediawiki/extensions/GrowthExperimentsmaster+1 -483
Hard deprecate PreferenceMentorStore servicemediawiki/extensions/GrowthExperimentsmaster+7 -1
Remove MigrateMentorMenteeRelationship from SchemaHooksmediawiki/extensions/GrowthExperimentsmaster+0 -6
Hard deprecate PreferenceMentorStore load/save methodsmediawiki/extensions/GrowthExperimentsmaster+12 -0
Stop using MultiWriteMentorStoremediawiki/extensions/GrowthExperimentsmaster+10 -10
Require $wgGEMentorshipMigrationStage to be SCHEMA_COMPAT_NEWmediawiki/extensions/GrowthExperimentsmaster+4 -16
tests: Do not directly save MENTOR_PREF in integration testsmediawiki/extensions/GrowthExperimentsmaster+18 -19
ApiSetMentorTest: Do not use PreferenceMentorStoremediawiki/extensions/GrowthExperimentsmaster+12 -6
Hard-deprecate GrowthExperimentsServices::getPreferenceMentorStoremediawiki/extensions/GrowthExperimentsmaster+5 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Sep 16 2021, 2:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2021, 2:18 PM
gerritbot added a comment.Sep 16 2021, 4:39 PM

Change 721577 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] ApiSetMentorTest: Do not use PreferenceMentorStore

https://gerrit.wikimedia.org/r/721577

gerritbot added a project: Patch-For-Review.Sep 16 2021, 4:39 PM

Change 721578 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Hard deprecate PreferenceMentorStore load/save methods

https://gerrit.wikimedia.org/r/721578

gerritbot added a comment.Sep 16 2021, 4:41 PM

Change 721579 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Require $wgGEMentorshipMigrationStage to be SCHEMA_COMPAT_NEW

https://gerrit.wikimedia.org/r/721579

gerritbot added a comment.Sep 16 2021, 4:46 PM

Change 721584 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Hard-deprecate GrowthExperimentsServices::getPreferenceMentorStore

https://gerrit.wikimedia.org/r/721584

Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 16 2021, 5:01 PM
gerritbot added a comment.Sep 16 2021, 5:29 PM

Change 721584 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] Hard-deprecate GrowthExperimentsServices::getPreferenceMentorStore

Reason:

https://gerrit.wikimedia.org/r/721584

gerritbot added a comment.Sep 16 2021, 5:39 PM

Change 721588 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Drop PreferenceMentorStore

https://gerrit.wikimedia.org/r/721588

Urbanecm_WMF triaged this task as Medium priority.Sep 16 2021, 6:58 PM
Urbanecm_WMF moved this task from Backlog to In progress on the User-Urbanecm_WMF (Engineering) board.
gerritbot added a comment.Sep 17 2021, 10:44 AM

Change 721781 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Remove MigrateMentorMenteeRelationship from SchemaHooks

https://gerrit.wikimedia.org/r/721781

gerritbot added a comment.Sep 17 2021, 10:46 AM

Change 721583 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Stop using MultiWriteMentorStore

https://gerrit.wikimedia.org/r/721583

gerritbot added a comment.Sep 17 2021, 10:46 AM

Change 721783 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Hard deprecate PreferenceMentorStore service

https://gerrit.wikimedia.org/r/721783

gerritbot added a comment.Sep 18 2021, 12:30 PM

Change 721943 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] tests: Do not directly save MENTOR_PREF in integration tests

https://gerrit.wikimedia.org/r/721943

Urbanecm_WMF added a comment.Sep 18 2021, 12:46 PM

The code should be ready now (assuming Jenkins approves of it :)). The plan is to:

  1. First, merge all patches but the dropping one (721588)
  2. Inform train conductors about a risky patch running the train, and ask for any deprecation relating to GrowthExperiments' own code to block current train (that'd mean something still calls preference mentor store for some weird reason; should not happen)
  3. Wait for a train to deploy them to production
  4. Fix any issues appearing in production logs relating to this action
  5. Merge the dropping patch (721588)
  6. Declare this task done

I'm marking this task as blocking to T280307, as it is not worth our time to implement backup mentor in PreferenceMentorStore.

Urbanecm_WMF added a parent task: T280307: Mentor dashboard: M2 mentor tools/settings.Sep 18 2021, 12:46 PM
Urbanecm_WMF moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Moving to CR -- no more code to write on my end :).

Urbanecm_WMF edited parent tasks, added: T291327: Assign backup mentors to users; removed: T280307: Mentor dashboard: M2 mentor tools/settings.Sep 18 2021, 1:39 PM
gerritbot added a comment.Sep 19 2021, 7:27 PM

Change 721577 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ApiSetMentorTest: Do not use PreferenceMentorStore

https://gerrit.wikimedia.org/r/721577

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 19 2021, 8:00 PM
gerritbot added a comment.Sep 20 2021, 11:43 PM

Change 721943 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Do not directly save MENTOR_PREF in integration tests

https://gerrit.wikimedia.org/r/721943

gerritbot added a comment.Sep 20 2021, 11:49 PM

Change 721579 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Require $wgGEMentorshipMigrationStage to be SCHEMA_COMPAT_NEW

https://gerrit.wikimedia.org/r/721579

gerritbot added a comment.Sep 20 2021, 11:53 PM

Change 721578 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Hard deprecate PreferenceMentorStore load/save methods

https://gerrit.wikimedia.org/r/721578

gerritbot added a comment.Sep 20 2021, 11:53 PM

Change 721583 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Stop using MultiWriteMentorStore

https://gerrit.wikimedia.org/r/721583

gerritbot added a comment.Sep 21 2021, 6:05 AM

Change 721781 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove MigrateMentorMenteeRelationship from SchemaHooks

https://gerrit.wikimedia.org/r/721781

gerritbot added a comment.Sep 21 2021, 6:05 AM

Change 721783 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Hard deprecate PreferenceMentorStore service

https://gerrit.wikimedia.org/r/721783

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.2; 2021-09-28); removed MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 21 2021, 4:00 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 6 2021, 11:53 AM
kostajh subscribed.

@Urbanecm_WMF could you please comment about what type of QA, if any, should happen next?

Urbanecm_WMF added a comment.Oct 6 2021, 11:59 AM
In T291188#7405250, @kostajh wrote:

@Urbanecm_WMF could you please comment about what type of QA, if any, should happen next?

Basically make sure there are no new deprecated messages about GrowthExperiments. I think releng would already catch that though.

gerritbot added a comment.Oct 6 2021, 12:13 PM

Change 721588 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Drop PreferenceMentorStore and MultiWriteMentorStore

https://gerrit.wikimedia.org/r/721588

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.4; 2021-10-12); removed MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Oct 6 2021, 1:00 PM
Urbanecm_WMF closed this task as Resolved.Oct 15 2021, 6:36 AM
Urbanecm_WMF removed a project: Patch-For-Review.

Nothing broke, code is removed => calling this resolved.

Urbanecm_WMF added a project: GrowthExperiments-Mentorship.Thu, Jul 4, 5:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits