Page MenuHomePhabricator

Help panel: guidance floating button appears over the Notifications mobile
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  • Go to the Userpage on mobile
  • Select the bell icon in the header to open the notifications drawer

What happens?:
The help/guidance panel floating button appears over the drawer.

screen_shot_2021-09-22_at_4.49.55_pm.png (681×389 px, 86 KB)

(thanks @alexhollender for noticing this issue and the screenshot)

What should have happened instead?:
Drawer should appear over the button, or else hide the button when the drawer is open per the fix on the related task T219966.

Event Timeline

(Please add project tags as project tags instead of subscribers. Thanks!)

Re-checked on testwiki wmf.7 - the help icon is smaller and is moved lower. But still - the help icon has not reason to be present in the notifications overlay.

Screen Shot 2021-11-10 at 1.40.04 PM.png (1×730 px, 164 KB)
Desktop on mobile
Screen Shot 2021-11-10 at 1.40.29 PM.png (1×782 px, 281 KB)

@Etonkovidova I could not reproduce the issue. On mobile the main header containing the notifications button is hidden while editing a article.

@Etonkovidova I could not reproduce the issue. On mobile the main header containing the notifications button is hidden while editing a article.

Interesting...I'm wondering if there was a separate bug that was causing the editor help button to show even when not in editing mode? I do remember seeing it a few days ago when not in editing mode (and imagine that was happening at the time when I reported this issue to @RHo), but that no longer seems to be the case.

In T291603#7617146, @alexhollender wrote:
Interesting...I'm wondering if there was a separate bug that was causing the editor help button to show even when not in editing mode? I do remember seeing it a few days ago when not in editing mode (and imagine that was happening at the time when I reported this issue to @RHo), but that no longer seems to be the case.

@alexhollender my bad, the issue is reproducible in the Userpage and Discussion namespaces. I updated the description. Moving it back to our backlog.

Change 753536 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Help panel: prevent guidance button floating over notifications mobile

https://gerrit.wikimedia.org/r/753536

I pushed a tentative fix. @RHo could you confirm that the help panel CTA needs to appear in User page and Discussion namespaces. Ty.

Change 753536 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Help panel: prevent guidance button floating over notifications mobile

https://gerrit.wikimedia.org/r/753536

I pushed a tentative fix. @RHo could you confirm that the help panel CTA needs to appear in User page and Discussion namespaces. Ty.

Yes thanks @Sgs

Checked on testwiki wmf.20 - the Help panel is not present on the Notification drawer and Special:Notifications page.

@Etonkovidova I could not reproduce the issue. On mobile the main header containing the notifications button is hidden while editing a article.

Interesting...I'm wondering if there was a separate bug that was causing the editor help button to show even when not in editing mode? I do remember seeing it a few days ago when not in editing mode (and imagine that was happening at the time when I reported this issue to @RHo), but that no longer seems to be the case.

@alexhollender_WMF - The Help button is present in non-editing mode for the following cases

  • User and User talk, Wikipedia and Help namespaces
  • on Suggested edit articles (when a user gets to such articles from Special:Homepage)