Page MenuHomePhabricator

Transform JSON javascript parser errors to Z5 errors in function-schemata
Closed, ResolvedPublic

Event Timeline

Change 710571 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/services/function-schemata@master] Add error formatting to php validation

https://gerrit.wikimedia.org/r/710571

I have separated this task from the more general error identification one (https://phabricator.wikimedia.org/T287735), to separate the javascript work (taken by Arthur Lorenzi) and the PHP work, which might finally end in the WikiLambda extension anyway.

@arthurlorenzi Thanks a lot for your help on this patch!! I'm very sorry for the delay on the review.

  • I have removed the php changes from the patch you worked over, so that we can review and merge both things separately.
  • I have also rebased over the last function-schemata changes.

This patch is now active to review and test everything related to error handling on the nodeJS side of things. Yaaay!

Change 710571 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add error formatting to schemata validation

https://gerrit.wikimedia.org/r/710571

Change 727439 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (6a1cb35)

https://gerrit.wikimedia.org/r/727439

Change 727439 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (6a1cb35)

https://gerrit.wikimedia.org/r/727439

Change 727465 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (4fade3b)

https://gerrit.wikimedia.org/r/727465

Change 727467 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (4fade3b)

https://gerrit.wikimedia.org/r/727467

Change 728456 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (502042c) and make pass

https://gerrit.wikimedia.org/r/728456

Change 727467 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (4fade3b)

Reason:

Squashed into Geno's patch.

https://gerrit.wikimedia.org/r/727467

Change 728456 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (502042c) and make pass

https://gerrit.wikimedia.org/r/728456

Change 727465 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (4fade3b)

https://gerrit.wikimedia.org/r/727465

Change 730668 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (502042c)

https://gerrit.wikimedia.org/r/730668

Change 730668 abandoned by Cory Massaro:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (502042c)

Reason:

https://gerrit.wikimedia.org/r/730668