Page MenuHomePhabricator
Create Task
Maniphest T292804

Use Z5s from function-schemata in Evaluators
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456operations/deployment-chartsmaster+1 -1
Update function-schemata sub-module to HEAD (1a02a7d)mediawiki/extensions/WikiLambdamaster+2 -2
Update PHPUnit test value for evaluator error code changesmediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (47aa465)mediawiki/extensions/WikiLambdamaster+1 -1
wikifunctions: Bump evaluators to 2023-11-06-164826operations/deployment-chartsmaster+2 -2
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (1a02a7d)repos/abstract-wiki/wikifunctions/wikilambda-cli!25jforrestersync-function-schematamain
Update errors fn to produce legit Z5 objectsrepos/abstract-wiki/wikifunctions/function-evaluator!136dmartinT292804-2main
Update function-schemata sub-module to HEAD (5cbf409)repos/abstract-wiki/wikifunctions/function-orchestrator!119dmartinsync-function-schematamain
Update function-schemata sub-module to HEAD (5cbf409)repos/abstract-wiki/wikifunctions/function-evaluator!135dmartinsync-function-schematamain
Add new error type Z565 / Incomplete executor requestrepos/abstract-wiki/wikifunctions/function-schemata!70dmartinT292804-2main
Update function-schemata sub-module to HEAD (57b1cf7)repos/abstract-wiki/wikifunctions/function-evaluator!129jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (47aa465)repos/abstract-wiki/wikifunctions/function-orchestrator!107jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (47aa465)repos/abstract-wiki/wikifunctions/function-evaluator!125jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (47aa465)repos/abstract-wiki/wikifunctions/wikilambda-cli!23jforrestersync-function-schematamain
definitions: Add Z561–Z564 error types for certain evaluator errorsrepos/abstract-wiki/wikifunctions/function-schemata!61dmartinT292804main
Use appropriate error types in evaluator JavaScript filesrepos/abstract-wiki/wikifunctions/function-evaluator!122dmartinT292804main
Make general executor errors actually valid Z5srepos/abstract-wiki/wikifunctions/function-evaluator!80jforresterT292804main
Show related patches Customize query in GitLab

Related Objects
Search...

Event Timeline

cmassaro created this task.Oct 7 2021, 11:51 PM
DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Oct 13 2021, 4:17 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
DVrandecic renamed this task from Use Z5s from function-schemata in Executors to Use Z5s from function-schemata in Evaluators.Oct 20 2021, 11:07 PM
Jdforrester-WMF added a parent task: T288123: Re-work Z5/Error model and handling.Oct 20 2021, 11:07 PM
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Oct 27 2021, 4:40 PM
cmassaro added a subtask: T293915: Use function-schemata in Executors.Oct 27 2021, 4:41 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.Jan 24 2022, 6:07 PM
DVrandecic closed subtask T293915: Use function-schemata in Executors as Resolved.Jan 25 2022, 5:23 PM
Jdforrester-WMF removed a parent task: T288123: Re-work Z5/Error model and handling.Mar 2 2022, 10:16 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team (Phase η – Generic types).
cmassaro triaged this task as Medium priority.Mar 15 2022, 6:43 PM
Jdforrester-WMF added a parent task: T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator.Oct 18 2022, 6:59 PM
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:23 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:47 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Sep 25 2023, 5:42 PM
CodeReviewBot added a project: Patch-For-Review.Oct 23 2023, 3:06 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/80

Make general executor errors actually valid Z5s

CodeReviewBot added a comment.Oct 31 2023, 4:24 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/80

Make general executor errors actually valid Z5s

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2023, 4:31 PM
Jdforrester-WMF claimed this task.Oct 31 2023, 6:21 PM
Jdforrester-WMF moved this task from Backlog to To deploy on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.

Other than the directly-created code inside the executors, which is the topic of T350167: Consider Moving Error Creation out of Executors and into Executor Classes, we're now always using makeErrorInNormalForm.

gerritbot added a comment.Nov 6 2023, 5:29 PM

Change 971998 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Bump evaluators to 2023-11-06-164826

https://gerrit.wikimedia.org/r/971998

gerritbot added a project: Patch-For-Review.Nov 6 2023, 5:29 PM
gerritbot added a comment.Nov 7 2023, 1:23 PM

Change 971998 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Bump evaluators to 2023-11-06-164826

https://gerrit.wikimedia.org/r/971998

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 1:30 PM
DMartin-WMF mentioned this in T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.Nov 15 2023, 6:04 AM
Jdforrester-WMF closed this task as Resolved.Nov 20 2023, 7:22 PM
Jdforrester-WMF reopened this task as Open.
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.

Technology done but still using hard-coded English strings; re-opening.

Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.Nov 20 2023, 7:24 PM
Jdforrester-WMF moved this task from Verify in production to Backlog on the Abstract Wikipedia team board.
DMartin-WMF claimed this task.Nov 28 2023, 5:51 PM
DMartin-WMF changed the task status from Open to In Progress.Nov 28 2023, 5:59 PM
DMartin-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
CodeReviewBot added a project: Patch-For-Review.Dec 1 2023, 9:38 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/122

Draft: Use appropriate error types in evaluator JavaScript files

CodeReviewBot added a comment.Dec 4 2023, 5:58 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/61

definitions: Add 4 error types

CodeReviewBot added a comment.Dec 5 2023, 4:56 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/61

definitions: Add Z561–Z564 error types for certain evaluator errors

CodeReviewBot added a comment.Dec 5 2023, 8:12 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/23

Update function-schemata sub-module to HEAD (47aa465)

gerritbot added a comment.Dec 5 2023, 8:13 PM

Change 980462 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (47aa465)

https://gerrit.wikimedia.org/r/980462

CodeReviewBot added a comment.Dec 5 2023, 8:13 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/125

Update function-schemata sub-module to HEAD (47aa465)

CodeReviewBot added a comment.Dec 5 2023, 8:13 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/107

Update function-schemata sub-module to HEAD (47aa465)

CodeReviewBot added a comment.Dec 5 2023, 8:26 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/125

Update function-schemata sub-module to HEAD (47aa465)

CodeReviewBot added a comment.Dec 5 2023, 8:27 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/107

Update function-schemata sub-module to HEAD (47aa465)

gerritbot added a comment.Dec 5 2023, 10:07 PM

Change 980462 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (47aa465)

https://gerrit.wikimedia.org/r/980462

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 5 2023, 11:00 PM
CodeReviewBot added a comment.Dec 6 2023, 4:11 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/23

Update function-schemata sub-module to HEAD (47aa465)

CodeReviewBot added a comment.Dec 15 2023, 2:39 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/122

Use appropriate error types in evaluator JavaScript files

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2023, 3:10 PM
DMartin-WMF closed this task as Resolved.Dec 18 2023, 4:16 PM
gerritbot added a comment.Jan 3 2024, 4:52 AM

Change 987214 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Update PHPUnit test value for evaluator error code changes

https://gerrit.wikimedia.org/r/987214

gerritbot added a project: Patch-For-Review.Jan 3 2024, 4:52 AM
DMartin-WMF reopened this task as Open.Jan 3 2024, 6:57 PM

Reopening to handle a few more errors (those created using calls to error() in executor.js and executor.py)

CodeReviewBot added a comment.Jan 3 2024, 7:15 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/70

Add new error type Z565 / Incomplete executor request

CodeReviewBot added a comment.Jan 3 2024, 7:39 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/70

Add new error type Z565 / Incomplete executor request

CodeReviewBot added a comment.Jan 3 2024, 8:37 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/135

Update function-schemata sub-module to HEAD (5cbf409)

CodeReviewBot added a comment.Jan 3 2024, 8:40 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/119

Update function-schemata sub-module to HEAD (5cbf409)

CodeReviewBot added a comment.Jan 4 2024, 5:46 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/136

Update errors fn to produce legit Z5 objects

CodeReviewBot added a comment.Jan 4 2024, 12:36 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/119

Update function-schemata sub-module to HEAD (5cbf409)

CodeReviewBot added a comment.Jan 4 2024, 6:58 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/135

Update function-schemata sub-module to HEAD (5cbf409)

CodeReviewBot added a comment.Jan 8 2024, 1:49 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/136

Update errors fn to produce legit Z5 objects

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Jan 8 2024, 1:52 PM
gerritbot added a comment.Jan 9 2024, 5:24 AM

Change 988754 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (2a825b7)

https://gerrit.wikimedia.org/r/988754

gerritbot added a comment.Jan 9 2024, 7:01 PM

Change 987214 abandoned by David Martin:

[mediawiki/extensions/WikiLambda@master] Update PHPUnit test value for evaluator error code changes

Reason:

Covered by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/988754

https://gerrit.wikimedia.org/r/987214

gerritbot added a comment.Jan 9 2024, 7:03 PM

Change 988754 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (1a02a7d)

https://gerrit.wikimedia.org/r/988754

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2024, 7:31 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jan 11 2024, 5:25 PM
Jdforrester-WMF closed this task as Resolved.Jan 22 2024, 3:12 PM
gerritbot added a comment.Jan 22 2024, 6:45 PM

Change 992225 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456

https://gerrit.wikimedia.org/r/992225

gerritbot added a project: Patch-For-Review.Jan 22 2024, 6:45 PM
gerritbot added a comment.Jan 22 2024, 6:48 PM

Change 992227 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630

https://gerrit.wikimedia.org/r/992227

gerritbot added a comment.Jan 22 2024, 7:27 PM

Change 992225 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456

https://gerrit.wikimedia.org/r/992225

gerritbot added a comment.Jan 22 2024, 7:45 PM

Change 992229 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638

https://gerrit.wikimedia.org/r/992229

gerritbot added a comment.Jan 22 2024, 7:46 PM

Change 992229 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638

https://gerrit.wikimedia.org/r/992229

gerritbot added a comment.Jan 22 2024, 7:53 PM

Change 992227 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630

https://gerrit.wikimedia.org/r/992227

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2024, 8:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits