Page MenuHomePhabricator
Create Task
Maniphest T321115

Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones
Closed, ResolvedPublic
Actions

Description

Imperfect search via rg -U "makeErrorInNormalForm\(\s*error\..*,\s*\[\s'" src

  • src/ZWrapper.js: Generic type function did not return a Z4…
  • src/ZWrapper.js: ZObject does not have the key ...
  • src/builtins.js: Object did not contain key…
  • src/builtins.js: Object did not contain key(s)…
  • src/builtins.js: An empty list has no head…
  • src/builtins.js: An empty list has no tail…
  • src/builtins.js: Provided equality function did not return Boolean…
  • src/orchestrate.js: The provided object is not a function call…
  • src/execute.js: Function evaluation returned an empty object…
  • src/execute.js: Function evaluation returned both a value and an error…
  • src/execute.js: Aborting because argument resolution contains cyclical references: ... (Will be handled by T350608)
  • src/execute.js: Could not create an implementation for…
  • src/execute.js: Could not find any implementations for…
  • src/frame.js: No argument called ' + argumentName + ' in scope.
  • src/validation.js: Builtin validator "${validationFunction.Z8K5.Z9K1}" not found for ...

Note: T292804 will be used for similar work (eliminating English errors) in the evaluator.

Details

SubjectRepoBranchLines +/-
wikifunctions: Switch orchestrator to 2023-11-06-172159operations/deployment-chartsmaster+1 -7
Update function-schemata sub-module to HEAD (a3499c5)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Oct 18 2022, 6:52 PM
DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Oct 25 2022, 6:39 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready: Errors on the Abstract Wikipedia team (Phase θ – Throttling) board.Oct 25 2022, 6:40 PM
Jdforrester-WMF triaged this task as Medium priority.Jan 11 2023, 8:22 PM
DMartin-WMF claimed this task.May 17 2023, 11:46 PM
CodeReviewBot added a comment.May 22 2023, 3:13 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/15

Use proper errors when Head/Tail builtins get empty list

CodeReviewBot added a project: Patch-For-Review.May 22 2023, 3:13 AM
Jdforrester-WMF added a subtask: T337354: Revisit the type of Z516's 'argument' key.May 25 2023, 3:36 PM
Jdforrester-WMF updated the task description. (Show Details)May 31 2023, 3:10 PM
DMartin-WMF added a project: Abstract Wikipedia Fix-It tasks.May 31 2023, 7:38 PM
CodeReviewBot added a comment.Jun 1 2023, 5:23 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/15

Use proper errors when Head/Tail builtins get empty list

Jdforrester-WMF updated the task description. (Show Details)Jun 1 2023, 5:23 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 1 2023, 5:30 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 16 2023, 8:51 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).
CodeReviewBot added a project: Patch-For-Review.Sep 28 2023, 12:14 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/63

Change English-language errors to properly structured ones

CodeReviewBot added a comment.Sep 28 2023, 1:38 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/63

Change English-language errors to properly structured ones

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2023, 2:12 PM
CodeReviewBot added a project: Patch-For-Review.Sep 29 2023, 7:33 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/68

Change more English-language errors to structured ones

CodeReviewBot added a comment.Oct 1 2023, 7:24 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/69

Change 5 more English-language errors to structured ones

DMartin-WMF closed subtask T337354: Revisit the type of Z516's 'argument' key as Resolved.Oct 1 2023, 7:38 PM
CodeReviewBot added a comment.Oct 2 2023, 6:27 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/68

Change more English-language errors to structured ones

CodeReviewBot added a comment.Oct 2 2023, 7:22 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/69

Change 5 more English-language errors to structured ones

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 7:30 PM
DMartin-WMF updated the task description. (Show Details)Oct 3 2023, 4:07 AM
Jdforrester-WMF changed the task status from Open to In Progress.Oct 3 2023, 2:33 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to In Progress on the Abstract Wikipedia team board.
CodeReviewBot added a project: Patch-For-Review.Oct 16 2023, 3:19 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/73

Draft: Change some more English-language errors to structured ones

CodeReviewBot added a comment.Oct 17 2023, 1:26 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/73

Change some more English-language errors to structured ones

Jdforrester-WMF updated the task description. (Show Details)Oct 17 2023, 1:28 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 17 2023, 1:31 PM
CodeReviewBot added a project: Patch-For-Review.Oct 24 2023, 7:59 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/77

Change 2 hardcoded Z22-format errors to invalid_format error type

DMartin-WMF updated the task description. (Show Details)Oct 25 2023, 2:33 AM
DMartin-WMF updated the task description. (Show Details)Oct 25 2023, 4:53 AM
CodeReviewBot added a comment.Oct 25 2023, 5:32 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/78

Draft: Replace remaining hardcoded errors in ZWrapper.js

DMartin-WMF updated the task description. (Show Details)Oct 26 2023, 2:08 AM
DMartin-WMF updated the task description. (Show Details)Oct 26 2023, 2:18 AM
DMartin-WMF added a subscriber: cmassaro.Oct 26 2023, 7:30 PM

@cmassaro , @Jdforrester-WMF :
All the occurrences listed above have been covered now by the patches, except for one:

src/execute.js: Aborting because argument resolution contains cyclical references: ...

This one seems tough: it seems not to fit well with any of our existing error types, but also seems too specialized to warrant a new error type. Actually, the error type argument_value_error is appropriate in spirit, but it has 2 keys (key, bad value) whose values are not actually knowable. (The detected cycle could be caused by multiple keys, and the code doesn't know which keys are involved.)

One option is to keep the English string, but change the error type to unknown_type, so the use of the string would be formally legit. That's not ideal, but seems acceptable to me. Looking for input on this. If folks think this calls for a new error type, I'm happy to do it that way.

CodeReviewBot added a comment.Oct 31 2023, 5:01 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/78

Replace remaining hardcoded errors in ZWrapper.js

CodeReviewBot added a comment.Oct 31 2023, 6:01 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/77

Change 2 hardcoded Z22-format errors to invalid_format error type

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2023, 6:10 PM
Jdforrester-WMF updated the task description. (Show Details)Oct 31 2023, 7:00 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a comment.Oct 31 2023, 7:05 PM
In T321115#9285779, @DMartin-WMF wrote:

One option is to keep the English string, but change the error type to unknown_type, so the use of the string would be formally legit. That's not ideal, but seems acceptable to me. Looking for input on this. If folks think this calls for a new error type, I'm happy to do it that way.

The recursion limit one should be a bespoke type, alongside Z570/Z571 for exceeding the rate limit, I think.

CodeReviewBot added a project: Patch-For-Review.Nov 6 2023, 4:32 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/18

Update function-schemata sub-module to HEAD (a3499c5)

CodeReviewBot added a comment.Nov 6 2023, 4:32 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/80

Update function-schemata sub-module to HEAD (a3499c5)

gerritbot added a comment.Nov 6 2023, 4:32 PM

Change 971988 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a3499c5)

https://gerrit.wikimedia.org/r/971988

CodeReviewBot added a comment.Nov 6 2023, 4:33 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/18

Update function-schemata sub-module to HEAD (a3499c5)

CodeReviewBot added a comment.Nov 6 2023, 4:38 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/80

Update function-schemata sub-module to HEAD (a3499c5)

CodeReviewBot added a comment.Nov 6 2023, 4:48 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/98

Update function-schemata sub-module to HEAD (b392301)

CodeReviewBot added a comment.Nov 6 2023, 5:15 PM

jforrester updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/98

Update function-schemata sub-module to HEAD (b392301)

gerritbot added a comment.Nov 6 2023, 5:29 PM

Change 971999 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-06-172159

https://gerrit.wikimedia.org/r/971999

DMartin-WMF mentioned this in T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator).Nov 6 2023, 5:49 PM
DMartin-WMF closed this task as Resolved.Nov 8 2023, 3:28 PM

The remaining unchecked example in this ticket's description will be covered by T350608 (which is in progress). Closing.

DMartin-WMF updated the task description. (Show Details)Nov 8 2023, 3:29 PM
gerritbot added a comment.Nov 13 2023, 3:07 PM

Change 971988 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a3499c5)

https://gerrit.wikimedia.org/r/971988

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 13 2023, 4:00 PM
DMartin-WMF renamed this task from Don't hard-code English-language error messages in the back-end; have pre-defined custom ones to Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.Nov 15 2023, 6:04 AM
DMartin-WMF updated the task description. (Show Details)
DMartin-WMF mentioned this in T287919: Audit ad Hoc Error Types in Orchestrator.Nov 16 2023, 5:59 AM
Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Nov 16 2023, 7:42 PM
gerritbot added a comment.Nov 29 2023, 4:43 PM

Change 971999 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-06-172159

https://gerrit.wikimedia.org/r/971999

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Nov 29 2023, 4:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits