Page MenuHomePhabricator
Create Task
Maniphest T292910

mwcore-phpunit-coverage-master failing due to composer upgrade
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1693/console

16:00:56 Updating dependencies (including require-dev)
16:01:38 Dependency resolution completed in 0.019 seconds
16:01:38 Your requirements could not be resolved to an installable set of packages.
16:01:38 
16:01:38   Problem 1
16:01:38     - The requested package composer-plugin-api ^2.0 exists as composer-plugin-api[1.1.0] but these are rejected by your constraint.
16:01:38 
16:01:38 
16:01:38 Installation failed, reverting ./composer.json to its original content.
16:01:38 INFO:quibble.commands:<<< Finish: Install composer dev-requires for vendor.git, in 70.490 s

Details

SubjectRepoBranchLines +/-
jjb: Upgrade users of quibble-buster-php73-coverage to 1.1.1-s3integration/configmaster+8 -8
dockerfiles: [quibble-buster-php73-coverage] Re-fix composer to 2.1.8integration/configmaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Oct 9 2021, 3:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2021, 3:15 PM
Reedy added a subscriber: Jdforrester-WMF.Oct 9 2021, 3:15 PM
Reedy added a comment.Oct 9 2021, 3:18 PM

The image was bumped in rCICFa0e7e3ebe2a0: jjb: Switch everything to images using composer 2.x not 1.x... So something didn't quite work as expected

Reedy added a comment.Oct 9 2021, 3:36 PM
16:00:07 + exec docker run --volume /srv/git:/srv/git:ro --volume /srv/jenkins/workspace/workspace/mwcore-phpunit-coverage-master/cover:/workspace/cover --tmpfs /workspace/db:size=320M --volume /srv/jenkins/workspace/workspace/mwcore-phpunit-coverage-master/cache:/cache --volume /srv/jenkins/workspace/workspace/mwcore-phpunit-coverage-master/log:/workspace/log --security-opt seccomp=unconfined --init --rm --label jenkins.job=mwcore-phpunit-coverage-master --label jenkins.build=1693 --env-file /dev/fd/63 docker-registry.wikimedia.org/releng/quibble-buster-php73-coverage:1.1.1 --packages-source vendor --db sqlite --db-dir /workspace/db --commands=mediawiki-coverage

Shouldn't that image name have an -s suffix?

kostajh added a subscriber: hashar.Oct 11 2021, 9:41 AM
Jdforrester-WMF added a comment.Oct 12 2021, 4:26 PM
In T292910#7414677, @Reedy wrote:
16:00:07 + exec docker run --volume /srv/git:/srv/git:ro --volume /srv/jenkins/workspace/workspace/mwcore-phpunit-coverage-master/cover:/workspace/cover --tmpfs /workspace/db:size=320M --volume /srv/jenkins/workspace/workspace/mwcore-phpunit-coverage-master/cache:/cache --volume /srv/jenkins/workspace/workspace/mwcore-phpunit-coverage-master/log:/workspace/log --security-opt seccomp=unconfined --init --rm --label jenkins.job=mwcore-phpunit-coverage-master --label jenkins.build=1693 --env-file /dev/fd/63 docker-registry.wikimedia.org/releng/quibble-buster-php73-coverage:1.1.1 --packages-source vendor --db sqlite --db-dir /workspace/db --commands=mediawiki-coverage

Shouldn't that image name have an -s suffix?

Those were mis-numbered; the version tagged as 1.1.1-s2 from eb46b416171c1dfb3ea81c334c2871989af2e52e was actually based on quibble 1.0.1 so should have been an 1.0.1-sN. However, the latest patch eab549e4a5c352da27b4da2245fbf5a0d65a2213 bumping it to 'real' 1.1.1 (used here) should have pulled in composer 2.x?

Krinkle subscribed.Oct 22 2021, 8:47 PM
quibble-buster-php73
$ docker run --rm -it --entrypoint /bin/bash docker-registry.wikimedia.org/releng/quibble-buster-php73:1.1.1 
nobody@b41adaa0905b:/workspace$ cd /srv/composer/
nobody@b41adaa0905b:/srv/composer$ ls -halF
-rw-r--r-- 1 root root   80 Oct  4 18:12 composer.phar.sha256sum
-rwxr-xr-x 1 root root  470 Dec  3  2020 run-composer.sh*

nobody@b41adaa0905b:/srv/composer$ /usr/bin/composer --version
Composer version 2.1.8 2021-09-15 13:55:14
quibble-buster-php73-coverage
docker run --rm -it --entrypoint /bin/bash docker-registry.wikimedia.org/releng/quibble-buster-php73-coverage:1.1.1 
nobody@6c09282b91fd:/workspace$ cd /srv/composer/
nobody@6c09282b91fd:/srv/composer$ ls -halF
-rw-r--r-- 1 root root   79 Apr 27 16:35 composer.phar.sha256sum
-rwxr-xr-x 1 root root  470 Dec  3  2020 run-composer.sh*

nobody@6c09282b91fd:/srv/composer$ /usr/bin/composer --version
Composer version 1.10.22 2021-04-27 13:10:45
gerritbot added a comment.Oct 22 2021, 8:56 PM

Change 733072 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] dockerfiles: [quibble-buster-php73-coverage] Re-upgrade composer from 1.10.5 to 2.1.8

https://gerrit.wikimedia.org/r/733072

gerritbot added a project: Patch-For-Review.Oct 22 2021, 8:56 PM
gerritbot added a comment.Oct 22 2021, 9:16 PM

Change 733074 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Upgrade users of quibble-buster-php73-coverage to 1.1.1-s3

https://gerrit.wikimedia.org/r/733074

gerritbot added a comment.Oct 22 2021, 9:18 PM

Change 733072 merged by jenkins-bot:

[integration/config@master] dockerfiles: [quibble-buster-php73-coverage] Re-fix composer to 2.1.8

https://gerrit.wikimedia.org/r/733072

Stashbot added a comment.Oct 22 2021, 9:19 PM

Mentioned in SAL (#wikimedia-releng) [2021-10-22T21:19:02Z] <James_F> Docker: Publishing quibble-buster-php73-coverage:1.1.1-s3 with quibble 1.1.1 and composer 2.1.8 for a change T292910

Jdforrester-WMF added a comment.Oct 22 2021, 9:32 PM

https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1720/console now building with composer 2.x correctly.

Jdforrester-WMF closed this task as Resolved.Oct 22 2021, 9:35 PM
Jdforrester-WMF claimed this task.
gerritbot added a comment.Oct 22 2021, 9:37 PM

Change 733074 merged by jenkins-bot:

[integration/config@master] jjb: Upgrade users of quibble-buster-php73-coverage to 1.1.1-s3

https://gerrit.wikimedia.org/r/733074

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2021, 10:11 PM
hashar added a comment.Oct 24 2021, 8:50 AM

It later fails with:

00:10:56.776 ERROR: Step ‘Publish Clover PHP Coverage Report’ aborted due to exception: 
00:10:56.776 java.lang.NoClassDefFoundError: org/apache/commons/digester/Digester

Which is due to a change in Jenkins: https://github.com/jenkinsci/jenkins/pull/5320 solved by https://github.com/jenkinsci/cloverphp-plugin/pull/10 and requires an upgrade of the clover plugin.

Stashbot added a comment.Oct 24 2021, 8:52 AM

Mentioned in SAL (#wikimedia-releng) [2021-10-24T08:51:59Z] <hashar> CI Jenkins: update Clover PHP plugin from 0.5 to 0.6 to solve java.lang.NoClassDefFoundError: org/apache/commons/digester/Digester # T292910

hashar added a comment.Oct 24 2021, 9:13 AM

Fixed!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits