In T277277: Modernize icons used in SecurePoll ListPage and VotePage, the decision was made to change the red "x" indicating a failed CSRF check to the letters "CSRF", which is not really clear as to what this actually means. Perhaps it should be tweaked to "CSRF failed" or just "Failed", for example, to make this clearer to those scrutinising these votes.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| i18n: Changing 'CSRF' to 'Failed' to clarify why it's marked | mediawiki/extensions/SecurePoll | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | STran | T277277 Modernize icons used in SecurePoll ListPage and VotePage | |||
| Resolved | Tks4Fish | T294063 Consider changing the text "CSRF" to "Failed" or similar |
Event Timeline
Comment Actions
CSRF stands for https://en.wikipedia.org/wiki/Cross-site_request_forgery - it's mostly technical jargon that shouldn't normally be shown to users, typically we say something like "session failure".
Comment Actions
Yup, though it is seen by users scrutinising votes on votewiki (admittedly this will pretty much only ever be Stewards or staff looking at this stuff) but it could still be clearer. The four scrutinisers for the MCDC elections were pretty confused by the change.
Comment Actions
Change 739809 had a related patch set uploaded (by Tks4Fish; author: Tks4Fish):
[mediawiki/extensions/SecurePoll@master] i18n: Changing 'CSRF' to 'Failed' to clarify why it's marked
Comment Actions
Change 739809 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] i18n: Changing 'CSRF' to 'Failed' to clarify why it's marked