Page MenuHomePhabricator
Create Task
Maniphest T294452

Provide a 'map' type (object -> object)
Closed, ResolvedPublic
Actions

Description

  • Add to schemata definitions
  • Add to orchestrator
  • Add to evaluator
  • Add example call to MW

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Support serialization/deserialization of generic maps in executors.mediawiki/services/function-evaluatormaster+3 K -60
Update function-schemata sub-module to HEAD (b129836)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (b129836)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (b129836)mediawiki/services/function-orchestratormaster+1 -1
definitions: Add Z883/Typed Map and its implementation Z983mediawiki/services/function-schematamaster+146 -1
Add example function call using the generic Map function.mediawiki/extensions/WikiLambdamaster+128 -0
Add generic map type function.mediawiki/services/function-orchestratormaster+895 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Oct 27 2021, 4:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2021, 4:52 PM
Jdforrester-WMF moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Oct 27 2021, 4:53 PM
Jdforrester-WMF added a parent task: T290216: Add definition for pre-defined Z804/Get key references from object and its built-in implementation Z904.
cmassaro subscribed.Oct 27 2021, 7:02 PM

Seems like the most straightforward implementation would be a list of pairs (do we have a ZID for that yet?).
So this means that a Map is a generic type parametrized by a generic type parametrized by a generic type 😎

Let's assume the cast of characters is like this:
Z1010 -> Generic List
Z834 -> Generic Pair
Z836 -> Generic Map

So a Map ( String -> Bool ) would minimally be specified as

{
    Z1K1: Z7,
    Z7K1: Z836,
    Z836K1: Z6,
    Z836K2: Z40
}

and an instantiation representing the map

{ 'true': True } (https://www.youtube.com/watch?v=V4kWQSpCbvo)

would look like

{
  Z1K1: {
    Z1K1: Z7,
    Z7K1: Z836,
    Z836K1: Z6,
    Z836K2: Z40
  },
  K1: {
    Z1K1: {
      Z1K1: Z7,
      Z7K1: Z1010
      Z1010K1: {
        Z1K1: Z7,
        Z7K1: Z834,
        Z834K1: Z6,
        Z834K2: Z40
      },
      K1: {
        Z1K1: {
          Z1K1: Z7,
          Z7K1: Z834,
          Z834K1: Z6,
          Z834K2: Z40
        },
        K1: "true",
        K2: {
          Z1K1: Z40,
          Z40K1: Z41
        }
      }
      K2: <tail of the list, so same Z1K1, no K1 or K2>
    }
  }
}

Does that work?

gerritbot added a comment.Nov 22 2021, 7:30 PM

Change 740662 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Support serialization/deserialization of generic maps in executors.

https://gerrit.wikimedia.org/r/740662

gerritbot added a project: Patch-For-Review.Nov 22 2021, 7:30 PM

Change 740664 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Add example function call using the generic Map function.

https://gerrit.wikimedia.org/r/740664

gerritbot added a comment.Nov 22 2021, 7:34 PM

Change 740665 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Add generic map type function.

https://gerrit.wikimedia.org/r/740665

gerritbot added a comment.Nov 23 2021, 7:07 PM

Change 740665 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Add generic map type function.

https://gerrit.wikimedia.org/r/740665

cmassaro mentioned this in rMSFO7f5413afdbf6: Add generic map type function..Nov 23 2021, 7:09 PM
Jdforrester-WMF changed the task status from Open to In Progress.Nov 23 2021, 7:20 PM
Jdforrester-WMF reassigned this task from DVrandecic to cmassaro.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
Jdforrester-WMF added a subscriber: DVrandecic.
Jdforrester-WMF updated the task description. (Show Details)Nov 24 2021, 10:17 AM
gerritbot added a comment.Nov 24 2021, 10:30 AM

Change 740664 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add example function call using the generic Map function.

https://gerrit.wikimedia.org/r/740664

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 24 2021, 11:00 AM
gerritbot added a comment.Dec 1 2021, 2:15 PM

Change 742953 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/services/function-schemata@master] definitions: Add Z883/Typed Map and its implementation Z983

https://gerrit.wikimedia.org/r/742953

Jdforrester-WMF updated the task description. (Show Details)Dec 1 2021, 2:24 PM
gerritbot added a comment.Dec 1 2021, 2:25 PM

Change 742953 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] definitions: Add Z883/Typed Map and its implementation Z983

https://gerrit.wikimedia.org/r/742953

Jdforrester-WMF mentioned this in rMSFSb12983689516: definitions: Add Z883/Typed Map and its implementation Z983.Dec 1 2021, 2:25 PM
gerritbot added a comment.Dec 1 2021, 2:47 PM

Change 742971 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (b129836)

https://gerrit.wikimedia.org/r/742971

gerritbot added a comment.Dec 1 2021, 2:48 PM

Change 742972 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (b129836)

https://gerrit.wikimedia.org/r/742972

gerritbot added a comment.Dec 1 2021, 2:49 PM

Change 742974 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (b129836)

https://gerrit.wikimedia.org/r/742974

gerritbot added a comment.Dec 1 2021, 2:54 PM

Change 742972 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (b129836)

https://gerrit.wikimedia.org/r/742972

Jdforrester-WMF mentioned this in rMSFO372186bd31b0: Update function-schemata sub-module to HEAD (b129836).Dec 1 2021, 2:55 PM
gerritbot added a comment.Dec 1 2021, 2:57 PM

Change 742974 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (b129836)

https://gerrit.wikimedia.org/r/742974

Jdforrester-WMF mentioned this in rMSFE0895563d265f: Update function-schemata sub-module to HEAD (b129836).Dec 1 2021, 2:57 PM
gerritbot added a comment.Dec 1 2021, 3:02 PM

Change 742971 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (b129836)

https://gerrit.wikimedia.org/r/742971

gerritbot added a comment.Dec 1 2021, 8:20 PM

Change 740662 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Support serialization/deserialization of generic maps in executors.

https://gerrit.wikimedia.org/r/740662

cmassaro mentioned this in rMSFEfd40f1ed1b55: Support serialization/deserialization of generic maps in executors..Dec 1 2021, 8:20 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 1 2021, 8:21 PM

Resolved?

cmassaro added a comment.Dec 1 2021, 8:37 PM

Yep!

Jdforrester-WMF closed this task as Resolved.Dec 1 2021, 9:33 PM
Jdforrester-WMF removed a parent task: T289796: Function model: Create a type for a return value/meta-data blob.Mar 8 2022, 10:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits