Page MenuHomePhabricator
Create Task
Maniphest T294849

Port Dialog Component to WiKit
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

To make sure the components we create with Design System specifications are reusable for other hikes, we need to ensure that they are included in the WiKit Components Library. This task aims to move the Dialog component created in the Mismatch finder app to WiKit, and ensure that the wikit-Dialog component is the single source of truth.

AC

  • The Dialog component is included and documented in WiKit: i.e. each prop and event are documented and controllable in storybook.
  • The Dialog component's unit tests are moved to Wikit and adapted to pass
  • A WiKit release is published with the Dialog component
  • The Dialog Component is removed from Mismatch Finder
  • The WiKit Dialog is used in the Mismatch Finder app instead

Related Objects
Search...

Event Timeline

Sarai-WMDE created this task.Nov 2 2021, 4:15 PM
ItamarWMDE updated the task description. (Show Details)Nov 2 2021, 4:22 PM
ItamarWMDE moved this task from Backlog to Ready for estimating on the Mismatch Finder board.Nov 11 2021, 11:12 AM
• karapayneWMDE set the point value for this task to 8.Nov 16 2021, 2:46 PM
• karapayneWMDE moved this task from Ready for estimating to Mismatch Finder - sprint 11 on the Mismatch Finder board.
• karapayneWMDE edited projects, added Mismatch Finder (Mismatch Finder - sprint 11); removed Mismatch Finder.
ItamarWMDE moved this task from To Do to Parents / Waiting on the Mismatch Finder (Mismatch Finder - sprint 11) board.Nov 17 2021, 9:05 AM
Silvan_WMDE added subscribers: ItamarWMDE, Silvan_WMDE.EditedNov 17 2021, 9:42 AM

Notes from task breakdown

Copy-Paste: T295874: Copy Dialog Component Code to WiKit

Storybook: T295875: Add Storybook Documentation for Dialog Component

  • Structure: the Dialog component has its own section is Storybook, called "Dialog". The section contains a "Complex" section displaying the "Complex" dialog.
  • Documentation: each prop and event are documented and controllable in storybook.
  • Behavior: users should be able to interact with the dialog. A button with the text "Open dialog" should allow users to trigger the display of the Dialog in case they closed it. (The component should be displayed by default)
  • Controls: users should be able to modify the copy of the title, the body and the button labels of the dialog. A secondary button/action might be optional.
  • Copy: see Figma (to be editable by the user)

Testing: T295876: Add browser tests to WiKit Dialog component

  • Add suggested browser tests to wikit in order to test dialog behavior

Release: T295877: WiKit pre-release with Dialog component

  • Update Changelog: "New Complex Dialog Component" (in Added section)
  • A new WiKit pre-release is published with the Dialog component
  • The Dialog Component is replaced by the WiKit Dialog in Mismatch Finder
Lydia_Pintscher moved this task from Mismatch Finder - sprint 11 to Mismatch Finder - sprint 12 on the Mismatch Finder board.Nov 30 2021, 2:58 PM
Lydia_Pintscher edited projects, added Mismatch Finder (Mismatch Finder - sprint 12); removed Mismatch Finder (Mismatch Finder - sprint 11).
Lydia_Pintscher moved this task from To Do to Parents / Waiting on the Mismatch Finder (Mismatch Finder - sprint 12) board.
Silvan_WMDE updated the task description. (Show Details)Nov 30 2021, 3:05 PM
Silvan_WMDE removed a subtask: T295876: Add browser tests to WiKit Dialog component.
Lydia_Pintscher closed subtask T295874: Copy Dialog Component Code to WiKit as Resolved.Dec 1 2021, 5:26 PM
Lydia_Pintscher closed subtask T295875: Add Storybook Documentation for Dialog Component as Resolved.Dec 7 2021, 6:24 PM
ItamarWMDE moved this task from Parents / Waiting to Test (Verification) on the Mismatch Finder (Mismatch Finder - sprint 12) board.Dec 13 2021, 2:04 PM
Sarai-WMDE updated the task description. (Show Details)Dec 15 2021, 3:55 PM
Sarai-WMDE closed this task as Resolved.Dec 15 2021, 3:57 PM
Sarai-WMDE claimed this task.

Please note that the 3rd point "A WiKit release is published with the Dialog component" actually refers to a "pre-release" (T295877). The latest WiKit release will be handled separately.

Sarai-WMDE closed subtask T295877: WiKit pre-release with Dialog component as Resolved.Dec 15 2021, 4:03 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Mismatch Finder (Mismatch Finder - sprint 12) board.Dec 15 2021, 4:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL