Page MenuHomePhabricator
Create Task
Maniphest T295741

[betalabs] Add image - mediawiki Internal error when fetching suggested images
Closed, ResolvedPublic
Actions

Description

I encounter three mediawiki internal errors when testing in beta.

Here is a full back trace:

MediaWiki internal error.

Original exception: [YZMETHS5T@3y5Z-Bx2j9mQAAAAM] /w/index.php?title=Athletics_at_the_1988_Summer_Olympics_%E2%80%93_Men%27s_50_kilometres_walk&getasktype=image-recommendation&gesuggestededit=1&veaction=edit&section=all&geclickid=fuqbvo308uogq1tvt4m2tmq6dar2uhpj&genewcomertasktoken=1cda28d43c1a7b2fcad9 Error: Call to a member function getRepoName() on boolean
Backtrace:
from /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataService.php(107)
#0 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php(291): GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataService->getApiMetadata(string)
#1 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(237): GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataProvider->getMetadata(array)
#2 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(165): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider::processApiResponseData(Title, string, array, GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataProvider)
#3 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HomepageHooks.php(362): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider->get(Title, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType)
#4 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(160): GrowthExperiments\HomepageHooks->onBeforePageDisplay(OutputPage, SkinMinerva)
#5 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(935): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#6 /srv/mediawiki/php-master/includes/OutputPage.php(2686): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinMinerva)
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(939): OutputPage->output(boolean)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(952): MediaWiki::{closure}()
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(559): MediaWiki->main()
#10 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

Exception caught inside exception handler: [YZMETHS5T@3y5Z-Bx2j9mQAAAAM] /w/index.php?title=Athletics_at_the_1988_Summer_Olympics_%E2%80%93_Men%27s_50_kilometres_walk&getasktype=image-recommendation&gesuggestededit=1&veaction=edit&section=all&geclickid=fuqbvo308uogq1tvt4m2tmq6dar2uhpj&genewcomertasktoken=1cda28d43c1a7b2fcad9 Error: Call to a member function getRepoName() on boolean
Backtrace:
from /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataService.php(107)
#0 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php(291): GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataService->getApiMetadata(string)
#1 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(237): GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataProvider->getMetadata(array)
#2 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(165): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider::processApiResponseData(Title, string, array, GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataProvider)
#3 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HomepageHooks.php(362): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider->get(Title, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType)
#4 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(160): GrowthExperiments\HomepageHooks->onBeforePageDisplay(OutputPage, SkinMinerva)
#5 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(935): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#6 /srv/mediawiki/php-master/includes/OutputPage.php(2686): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinMinerva)
#7 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(158): OutputPage->output()
#8 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(77): MWExceptionRenderer::reportHTML(Error)
#9 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(107): MWExceptionRenderer::output(Error, integer)
#10 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(202): MWExceptionHandler::report(Error)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(581): MWExceptionHandler::handleException(Error, string)
#12 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Two others:

Original exception: [YY8OrShpPvLWdnunsy39sQAAAFg] /w/index.php?title=1982_in_aviation&getasktype=image-recommendation&gesuggestededit=1&veaction=edit&section=all&geclickid=f56fc343f62c6e5848df&genewcomertasktoken=c99c25def1a357cf71e9 Error: Call to a member function getRepoName() on boolean
Original exception: [YY8DBsFnBHc9bybZBwsH5gAAAAg] /w/index.php?title=Lilia_Sandulesu&getasktype=image-recommendation&gesuggestededit=1&veaction=edit&section=all&geclickid=496fcefad836d501f9f0&genewcomertasktoken=0d43a1160331ab041942 Error: Call to a member function getRepoName() on boolean

Details

SubjectRepoBranchLines +/-
Add Image: Fix handling of non-existent filesmediawiki/extensions/GrowthExperimentsmaster+8 -2
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Nov 16 2021, 1:18 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 16 2021, 1:18 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
gerritbot added a comment.Nov 16 2021, 3:10 AM

Change 739047 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Image: Fix handling of non-existent files

https://gerrit.wikimedia.org/r/739047

gerritbot added a project: Patch-For-Review.Nov 16 2021, 3:10 AM
Tgr claimed this task.Nov 16 2021, 3:10 AM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr added a comment.Nov 16 2021, 3:14 AM

Caused by the recommended file not existing (API example, file example).

Etonkovidova added a comment.Nov 18 2021, 10:39 PM

One error on testwiki wmf.9

Error
normalized_message
[{reqId}] {exception_url}   Error: Call to a member function getRepoName() on boolean
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataService.php(107)
#0 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php(291): GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataService->getApiMetadata(string)
#1 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(237): GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataProvider->getMetadata(array)
#2 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(165): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider::processApiResponseData(Title, string, array, GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationMetadataProvider)
#3 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/HomepageHooks.php(362): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider->get(Title, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType)
#4 /srv/mediawiki/php-1.38.0-wmf.9/includes/HookContainer/HookContainer.php(160): GrowthExperiments\HomepageHooks->onBeforePageDisplay(OutputPage, SkinMinerva)
#5 /srv/mediawiki/php-1.38.0-wmf.9/includes/HookContainer/HookRunner.php(935): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#6 /srv/mediawiki/php-1.38.0-wmf.9/includes/OutputPage.php(2686): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinMinerva)
#7 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(939): OutputPage->output(boolean)
#8 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(952): MediaWiki::{closure}()
#9 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(559): MediaWiki->main()
#10 /srv/mediawiki/php-1.38.0-wmf.9/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-1.38.0-wmf.9/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}
gerritbot added a comment.Nov 18 2021, 11:58 PM

Change 739047 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: Fix handling of non-existent files

https://gerrit.wikimedia.org/r/739047

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 19 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 19 2021, 12:10 AM
• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 19 2021, 5:05 PM
MMiller_WMF subscribed.Nov 22 2021, 6:08 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 22 2021, 6:12 PM
Etonkovidova added a comment.EditedDec 13 2021, 9:30 PM

The error is not present on wmf.12 - the issue is Resolved.

The last timestamp for the error was on testwiki wmf.9 - Nov 22, 2021 @ 15:31:57.076

Etonkovidova closed this task as Resolved.Dec 13 2021, 9:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits