Page MenuHomePhabricator

Add Image: Suggested edit workflow is aborted on page reload
Closed, ResolvedPublic

Description

Steps to reproduce:

  • open Add Image task
  • reload the page

I end up in the plain mobile editor.

Seen locally, can't reproduce in beta.


The issue is confirmed for the following steps:

  1. A user has Special:Preferences#mw-prefsection-editing set to "Remember my last editor".
  2. A user edits an article in source editor (or just opens the source editor)
  3. After that, a user goes to a structured task article ("add link" or "add image" ). An article page opens correctly with Suggestions surface.

A user reloads the page with the structured task - the article is open in the source editor:

  • the Suggestion surface is is not present as an option in the drop-down menu
  • clicking back browser button does not bring the suggestion surface back.

The Suggestion surface is brought back when the VE option is clicked - then an article will display suggestions. (VE won't load, the page just switches to the Suggestion mode).

Event Timeline

Stepping through with a debugger, nothing obvious seems to be wrong on our side. StructuredTaskPreEdit.loadEditModule() is called, but the ve.loadModules hook callback it adds never fires. Which also seems correct, as the editor loads in source mode. And after a mode switch the structured task indeed loads. So maybe it's related to the editor mode preferences? Or something broken in my setup?

Couldn't reproduce in beta. OTOH I can't find any relevant user preference differences either.

MMiller_WMF subscribed.

@Etonkovidova is going to check this. It could be useful to see if this is also happening for "add a link".

@Etonkovidova is going to check this. It could be useful to see if this is also happening for "add a link".

Added steps to reproduce the issue to the description.

Change 740906 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Structured Task: Make sure VisualEditor is loaded upon reload

https://gerrit.wikimedia.org/r/740906

Change 740906 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured Task: Make sure VisualEditor is loaded upon reload

https://gerrit.wikimedia.org/r/740906