[minor] Add image - add caption inactive Save button should not become active on a click
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Nov 19 2021, 10:45 PM

Description

Steps to reproduce:

On an add image article, click 'yes', to add an image
The Add caption will be displayed with inactive Save button
Without entering anything into the caption text box, click on the inactive button - the button becomes active.

(click on the animated gif)

The saving is still not possible when clicking on the active button, so the issue is minor.

Details

	Subject	Repo	Branch	Lines +/-
	Add an image: Prevent interaction with tools in disabled toolgroup	mediawiki/extensions/GrowthExperiments	master	+7 -0

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Nov 19 2021, 10:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2021, 10:45 PM

Hello! Can I work on this issue?

@Attreyee.m Hi and welcome! Please see https://www.mediawiki.org/wiki/New_Developers - thanks!

MMiller_WMF triaged this task as Medium priority.Dec 6 2021, 6:10 AM

MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

• mewoph claimed this task.Dec 6 2021, 10:31 PM

Change 744099 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: Prevent interaction with tools in disabled toolgroup

https://gerrit.wikimedia.org/r/744099

gerritbot added a project: Patch-For-Review.Dec 6 2021, 10:34 PM

Hi @Attreyee.m — thank you for your interest. I just posted a patch for this. Feel free to take a look at good first tasks for our team. The developer setup guide for GrowthExperiments extension can be found here. Please ping us if you have any questions!

With latest changes:

Okay @mewoph ma'am. Thank you for helping .🙂

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 8 2021, 8:40 PM

Change 744099 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: Prevent interaction with tools in disabled toolgroup

https://gerrit.wikimedia.org/r/744099

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 8 2021, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 8 2021, 10:10 PM

Etonkovidova closed this task as Resolved.Dec 17 2021, 1:06 AM

	F34850654: savedisabled.gif
	Dec 6 2021, 10:38 PM

[minor] Add image - add caption inactive Save button should not become active on a clickClosed, ResolvedPublicActions

Description

Details

Event Timeline

[minor] Add image - add caption inactive Save button should not become active on a click
Closed, ResolvedPublic
Actions