Page MenuHomePhabricator
Create Task
Maniphest T296937

use functions from function-schemata utils throughout the codebase
Closed, ResolvedPublic
Actions

Description

Use the utils functions in function-schemata in function-orchestrator, function-evaluator and WikiLambda extension. This requires a rename of the functions so they are more lint friendly

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

SimoneThisDot created this task.Dec 2 2021, 2:04 PM
• JKieserman claimed this task.Dec 3 2021, 1:54 PM
gerritbot added a comment.Dec 3 2021, 3:20 PM

Change 743405 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] make a deepCopy util to be shared across files

https://gerrit.wikimedia.org/r/743405

gerritbot added a project: Patch-For-Review.Dec 3 2021, 3:20 PM
• JKieserman added a comment.Dec 3 2021, 3:21 PM

pending conversation with Cory, would prefer to use the existing implementation in function-schemata if possible instead of the above patch.

gerritbot added a comment.Dec 6 2021, 3:01 PM

Change 743405 abandoned by Jkieserman:

[mediawiki/extensions/WikiLambda@master] make a deepCopy util to be shared across files

Reason:

using function-schemata utils instead

https://gerrit.wikimedia.org/r/743405

• JKieserman renamed this task from create a deepCopy method in utils to use functions from function-schemata utils throughout the codebase.Dec 6 2021, 3:03 PM
• JKieserman updated the task description. (Show Details)
gerritbot added a comment.Dec 6 2021, 3:09 PM

Change 744018 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/services/function-schemata@master] rename util functions so they do not cause linting problems

https://gerrit.wikimedia.org/r/744018

gerritbot added a comment.Dec 6 2021, 8:32 PM

Change 744089 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] shared utils

https://gerrit.wikimedia.org/r/744089

DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 7 2021, 5:16 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
gerritbot added a comment.Dec 7 2021, 5:59 PM

Change 744018 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] utils: Rename functions to camel case to avoid linting whine

https://gerrit.wikimedia.org/r/744018

Jdforrester-WMF mentioned this in rMSFSb38a5b2c77d8: utils: Rename functions to camel case to avoid linting whine.Dec 7 2021, 6:00 PM
gerritbot added a comment.Dec 7 2021, 6:38 PM

Change 743405 restored by Jkieserman:

[mediawiki/extensions/WikiLambda@master] make a deepCopy util to be shared across files

https://gerrit.wikimedia.org/r/743405

gerritbot added a comment.Dec 7 2021, 10:17 PM

Change 744083 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744083

gerritbot added a comment.Dec 7 2021, 10:18 PM

Change 744082 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744082

gerritbot added a comment.Dec 7 2021, 10:18 PM

Change 744084 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744084

gerritbot added a comment.Dec 7 2021, 10:34 PM

Change 743405 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] make a deepCopy util to be shared across files

Reason:

Per Julia.

https://gerrit.wikimedia.org/r/743405

gerritbot added a comment.Dec 9 2021, 4:51 PM

Change 745566 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/745566

gerritbot added a comment.Dec 9 2021, 4:57 PM

Change 744084 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744084

Jdforrester-WMF mentioned this in rMSFE79aa1b46f059: Update function-schemata sub-module to HEAD (e130e59).Dec 9 2021, 4:59 PM
gerritbot added a comment.Dec 9 2021, 6:42 PM

Change 745566 abandoned by Jforrester:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

Reason:

https://gerrit.wikimedia.org/r/745566

gerritbot added a comment.Dec 9 2021, 6:43 PM

Change 744082 merged by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744082

cmassaro mentioned this in rMSFOe08fe9d60da7: Update function-schemata sub-module to HEAD (e130e59).Dec 9 2021, 6:44 PM
Jdforrester-WMF subscribed.Dec 9 2021, 6:55 PM

Are there any other places we want to use utility functions right now, or can we call this done?

• JKieserman added a comment.Dec 9 2021, 6:57 PM

I'd call it done

Jdforrester-WMF closed this task as Resolved.Dec 9 2021, 6:59 PM

Good enough for me. :-)

gerritbot added a comment.Dec 9 2021, 7:08 PM

Change 744083 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744083

gerritbot added a comment.Dec 9 2021, 7:08 PM

Change 744089 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Use new 'deepEqual' and 'deepCopy' utilities from function-schemata

https://gerrit.wikimedia.org/r/744089

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 9 2021, 8:00 PM
gerritbot added a comment.Dec 9 2021, 10:30 PM

Change 745384 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Revert \"Use new 'deepEqual' and 'deepCopy' utilities from function-schemata\"

https://gerrit.wikimedia.org/r/745384

Jdforrester-WMF reopened this task as Open.Dec 9 2021, 10:30 PM

I spoke too soon. :-(

gerritbot added a comment.Dec 9 2021, 10:45 PM

Change 745384 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Revert \"Use new 'deepEqual' and 'deepCopy' utilities from function-schemata\"

https://gerrit.wikimedia.org/r/745384

• aishwaryavardhana edited projects, added Design; removed WikiLambda Front-end.Mar 15 2022, 6:45 PM
Jdforrester-WMF edited projects, added WikiLambda Front-end; removed Design, Patch-For-Review.Mar 15 2022, 7:57 PM
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:45 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:37 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF removed • JKieserman as the assignee of this task.Aug 7 2023, 8:19 PM
Jdforrester-WMF added a subscriber: • JKieserman.
CodeReviewBot added a comment.Feb 9 2024, 1:33 AM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/85

Draft: Allow utils to be imported and required as both ES6 and CommonJS.

CodeReviewBot added a comment.Feb 9 2024, 2:37 AM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/86

Move ZObjectKeyFactory to utils so it can be used by downstream consumers.

CodeReviewBot added a comment.Feb 9 2024, 2:37 AM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/87

Draft: Apine implement stable stringify

CodeReviewBot added a comment.Feb 9 2024, 5:28 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/86

Move ZObjectKeyFactory to utils so it can be used by downstream consumers.

gerritbot added a comment.Feb 12 2024, 3:04 PM

Change 1002570 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (786c586)

https://gerrit.wikimedia.org/r/1002570

gerritbot added a project: Patch-For-Review.Feb 12 2024, 3:04 PM
CodeReviewBot added a comment.Feb 12 2024, 5:42 PM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/87

Implement a stable stringify algorithm (keys are always sorted).

gerritbot added a comment.Feb 12 2024, 9:02 PM

Change 1002624 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-01-18-182456 to 2024-02-12-155846

https://gerrit.wikimedia.org/r/1002624

gerritbot added a comment.Feb 12 2024, 9:02 PM

Change 1002625 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222

https://gerrit.wikimedia.org/r/1002625

gerritbot added a comment.Feb 22 2024, 7:55 PM

Change 1002624 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-01-18-182456 to 2024-02-12-155846

https://gerrit.wikimedia.org/r/1002624

CodeReviewBot added a comment.Feb 26 2024, 3:02 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/171

Update function-schemata sub-module to HEAD (04c5c89)

gerritbot added a comment.Feb 28 2024, 3:06 PM

Change 1002625 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222

https://gerrit.wikimedia.org/r/1002625

gerritbot added a comment.Feb 28 2024, 3:17 PM

Change 1007353 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-12-160222 to 2024-02-26-150300

https://gerrit.wikimedia.org/r/1007353

gerritbot added a comment.Feb 28 2024, 3:21 PM

Change 1007353 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-12-160222 to 2024-02-26-150300

https://gerrit.wikimedia.org/r/1007353

CodeReviewBot added a comment.Mar 1 2024, 8:10 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/32

Update function-schemata sub-module to HEAD (04c5c89)

CodeReviewBot added a comment.Mar 1 2024, 8:15 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/137

Update function-schemata sub-module to HEAD (04c5c89)

gerritbot added a comment.Mar 5 2024, 2:44 PM

Change 1008874 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533

https://gerrit.wikimedia.org/r/1008874

gerritbot added a comment.Mar 5 2024, 7:59 PM

Change 1008874 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533

https://gerrit.wikimedia.org/r/1008874

gerritbot added a comment.Mar 5 2024, 8:34 PM

Change 1002570 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (97ea4cd)

https://gerrit.wikimedia.org/r/1002570

Sharvaniharan triaged this task as Low priority.May 2 2024, 4:51 PM
Sharvaniharan added a project: Abstract Wikipedia Fix-It tasks.
Sharvaniharan moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF closed this task as Resolved.Mon, Nov 18, 4:54 PM
Jdforrester-WMF claimed this task.

Good enough for now. Always more to do.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits