Page MenuHomePhabricator
Create Task
Maniphest T297318

PHP Notice: Undefined index: enable-toc
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined index: enable-toc
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.12/extensions/WikidataPageBanner/includes/WikidataPageBanner.php(208)
#0 /srv/mediawiki/php-1.38.0-wmf.12/extensions/WikidataPageBanner/includes/WikidataPageBanner.php(208): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.12/includes/HookContainer/HookContainer.php(338): WikidataPageBanner::onParserOutputPostCacheTransform(ParserOutput, string, array)
#2 /srv/mediawiki/php-1.38.0-wmf.12/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#3 /srv/mediawiki/php-1.38.0-wmf.12/includes/HookContainer/HookRunner.php(2931): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#4 /srv/mediawiki/php-1.38.0-wmf.12/includes/parser/ParserOutput.php(380): MediaWiki\HookContainer\HookRunner->onParserOutputPostCacheTransform(ParserOutput, string, array)
#5 /srv/mediawiki/php-1.38.0-wmf.12/includes/OutputPage.php(2047): ParserOutput->getText(array)
#6 /srv/mediawiki/php-1.38.0-wmf.12/includes/OutputPage.php(2060): OutputPage->addParserOutputText(ParserOutput, array)
#7 /srv/mediawiki/php-1.38.0-wmf.12/includes/page/Article.php(759): OutputPage->addParserOutput(ParserOutput, array)
#8 /srv/mediawiki/php-1.38.0-wmf.12/includes/page/Article.php(610): Article->doOutputFromParserCache(ParserOutput, OutputPage, array)
#9 /srv/mediawiki/php-1.38.0-wmf.12/includes/page/Article.php(517): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#10 /srv/mediawiki/php-1.38.0-wmf.12/includes/actions/ViewAction.php(74): Article->view()
#11 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(534): ViewAction->show()
#12 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#13 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(895): MediaWiki->performRequest()
#14 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(554): MediaWiki->main()
#15 /srv/mediawiki/php-1.38.0-wmf.12/index.php(53): MediaWiki->run()
#16 /srv/mediawiki/php-1.38.0-wmf.12/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}
Impact

Unknown.

Notes

3 of these in 1.38.0-wmf.12 (T293953) during brief time on group1. 2 oewikivoyage, 1 zhwikivoyage.

Details

Request URL
https://eo.wikivoyage.org/wiki/[page]
SubjectRepoBranchLines +/-
Make sure 'enable-toc' key is setmediawiki/extensions/WikidataPageBannermaster+1 -1
Make sure 'enable-toc' key is setmediawiki/extensions/WikidataPageBannerwmf/1.38.0-wmf.12+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedancyT293953 1.38.0-wmf.12 deployment blockers
 ResolvedPRODUCTION ERRORZabeT297318 PHP Notice: Undefined index: enable-toc

Event Timeline

brennen created this task.Dec 8 2021, 8:50 PM
Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptDec 8 2021, 8:50 PM
taavi added subscribers: Jdlrobson, cscott, taavi.Dec 8 2021, 8:53 PM

cc @Jdlrobson @cscott as this seems related to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikidataPageBanner/+/743268

Zabe subscribed.Dec 8 2021, 8:54 PM
gerritbot added a comment.Dec 8 2021, 8:54 PM

Change 745322 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/WikidataPageBanner@master] Make sure 'enable-toc' key is set

https://gerrit.wikimedia.org/r/745322

gerritbot added a project: Patch-For-Review.Dec 8 2021, 8:54 PM
dancy subscribed.Dec 8 2021, 8:55 PM
dancy added a parent task: T293953: 1.38.0-wmf.12 deployment blockers.Dec 8 2021, 8:58 PM
Ladsgroup subscribed.Dec 8 2021, 9:00 PM
Zabe triaged this task as Unbreak Now! priority.Dec 8 2021, 9:01 PM

As a train blocker.

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Dec 8 2021, 9:02 PM
gerritbot added a comment.Dec 8 2021, 9:03 PM

Change 745240 had a related patch set uploaded (by Ladsgroup; author: Zabe):

[mediawiki/extensions/WikidataPageBanner@wmf/1.38.0-wmf.12] Make sure 'enable-toc' key is set

https://gerrit.wikimedia.org/r/745240

gerritbot added a comment.Dec 8 2021, 9:25 PM

Change 745322 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@master] Make sure 'enable-toc' key is set

https://gerrit.wikimedia.org/r/745322

gerritbot added a comment.Dec 8 2021, 9:26 PM

Change 745240 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@wmf/1.38.0-wmf.12] Make sure 'enable-toc' key is set

https://gerrit.wikimedia.org/r/745240

Stashbot added a comment.Dec 8 2021, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2021-12-08T21:30:42Z] <ladsgroup@deploy1002> Synchronized php-1.38.0-wmf.12/extensions/WikidataPageBanner/includes/WikidataPageBanner.php: Backport: [[gerrit:745240|Make sure 'enable-toc' key is set (T297318)]] (duration: 01m 05s)

Ladsgroup closed this task as Resolved.Dec 8 2021, 9:31 PM
Ladsgroup assigned this task to Zabe.
Maintenance_bot added a project: Wikidata.Dec 8 2021, 9:45 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 8 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 8 2021, 10:10 PM
Stang unsubscribed.Dec 9 2021, 2:00 PM
Krinkle moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.Jan 13 2022, 6:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL