Page MenuHomePhabricator

Hard deprecate and remove the deprecated WikiPage instantiation methods
Open, LowPublic

Description

The following WikiPage methods are deprecated and should no longer be used.

  • WikiPage::factory()
  • WikiPage::newFromID()
  • WikiPage::newFromRow()

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbWiki(Category%7CFile)%3FPage%5Cs*%3A%3A%5Cs*(factory%7CnewFromID%7CnewFromRow)%5Cb&i=nope&files=&excludeFiles=&repos=

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+11 -0
mediawiki/coremaster+20 -20
mediawiki/skins/TuleapSkinmaster+21 -8
mediawiki/coremaster+4 -4
mediawiki/coremaster+103 -86
mediawiki/coremaster+212 -145
mediawiki/coremaster+11 -1
mediawiki/extensions/FileImportermaster+1 -3
mediawiki/extensions/DynamicPageListmaster+2 -2
mediawiki/extensions/CollaborationKitmaster+7 -4
mediawiki/extensions/WikispeechSpeechDataCollectormaster+7 -2
mediawiki/extensions/PagePropertiesmaster+18 -3
mediawiki/extensions/Formsmaster+31 -4
mediawiki/extensions/FileAnnotationsmaster+12 -1
mediawiki/extensions/PhpTagsWikimaster+18 -3
mediawiki/extensions/PhpTagsStoragemaster+26 -4
mediawiki/extensions/Workflowsmaster+20 -4
mediawiki/extensions/AccessControlmaster+18 -3
mediawiki/extensions/PageOwnershipmaster+13 -3
mediawiki/extensions/TEImaster+5 -3
mediawiki/skins/BlueSpiceCalummamaster+5 -4
mediawiki/extensions/BlueSpiceUserSidebarREL1_35-4.2.x+3 -3
mediawiki/extensions/BlueSpiceUserSidebarREL1_35+3 -3
mediawiki/extensions/BlueSpiceBookshelfmaster+10 -5
mediawiki/extensions/CognitiveProcessDesignermaster+76 -7
mediawiki/extensions/BlueSpiceUEModulePDFmaster+3 -2
mediawiki/extensions/BlueSpiceUserSidebarmaster+3 -3
mediawiki/extensions/BlueSpiceSocialmaster+5 -4
mediawiki/extensions/BlueSpiceSocialTopicsmaster+3 -3
mediawiki/extensions/BlueSpiceDistributionConnectormaster+2 -2
mediawiki/extensions/BlueSpiceExtendedSearchmaster+3 -2
mediawiki/extensions/BlueSpiceSocialProfilemaster+5 -5
mediawiki/extensions/BlueSpiceUEModuleTable2Excelmaster+1 -1
mediawiki/skins/BlueSpiceDiscoverymaster+8 -13
mediawiki/extensions/SemanticImageAnnotatormaster+10 -1
mediawiki/extensions/PerPageLicensemaster+8 -1
mediawiki/extensions/NewUserActionsmaster+14 -2
mediawiki/extensions/ParserMigrationmaster+7 -1
mediawiki/extensions/PageFormsmaster+86 -11
mediawiki/extensions/QuickSearchLookupmaster+6 -1
mediawiki/extensions/Commentboxmaster+6 -1
mediawiki/extensions/AControlImageLinkmaster+8 -1
mediawiki/extensions/AutoCategoriseUploadsmaster+6 -1
mediawiki/extensions/ContentTransfermaster+6 -1
mediawiki/extensions/DataTransfermaster+14 -2
mediawiki/extensions/CreatedPagesListmaster+37 -5
mediawiki/extensions/DynamicPageListEnginemaster+10 -2
mediawiki/extensions/EditNotifymaster+8 -1
mediawiki/extensions/ExternalDatamaster+16 -2
mediawiki/extensions/EnhancedUploadmaster+26 -4
mediawiki/extensions/OfflineImportLexiconmaster+8 -1
mediawiki/extensions/GroupWhitelistmaster+6 -1
mediawiki/extensions/Wikispeechmaster+37 -7
mediawiki/extensions/LDAPSyncAllmaster+6 -1
mediawiki/extensions/MergeArticlesmaster+12 -2
mediawiki/extensions/OnlineStatusBarmaster+11 -2
mediawiki/extensions/PageSchemasmaster+14 -2
mediawiki/extensions/Patrollermaster+6 -1
mediawiki/extensions/Polyglotmaster+6 -1
mediawiki/extensions/TitleKeymaster+6 -1
mediawiki/extensions/SplitPrivateWikimaster+14 -2
mediawiki/extensions/WatchSubpagesmaster+12 -1
mediawiki/extensions/CirrusSearchmaster+2 -1
mediawiki/extensions/ArticleRatingsmaster+6 -1
mediawiki/extensions/HAWelcomemaster+19 -3
mediawiki/extensions/PictureGamemaster+12 -2
mediawiki/extensions/UnusedRedirectsmaster+7 -1
mediawiki/extensions/BlogPagemaster+7 -1
mediawiki/extensions/LinkFiltermaster+7 -1
mediawiki/extensions/FanBoxesmaster+14 -2
mediawiki/extensions/Videomaster+12 -2
mediawiki/extensions/ImageRatingmaster+10 -1
mediawiki/extensions/PollNYmaster+22 -3
mediawiki/extensions/MintyDocsmaster+64 -10
mediawiki/extensions/SpamDiffToolmaster+14 -2
mediawiki/extensions/DisplayTitlemaster+20 -3
mediawiki/extensions/SocialProfilemaster+35 -7
mediawiki/extensions/Formmaster+18 -2
mediawiki/extensions/Cargomaster+45 -14
mediawiki/extensions/WikiSEOmaster+12 -1
mediawiki/extensions/ApprovedRevsmaster+32 -5
mediawiki/extensions/CategoryWatchmaster+8 -1
mediawiki/extensions/DataTable2master+12 -1
mediawiki/extensions/DidYouKnowmaster+6 -1
mediawiki/extensions/S5SlideShowmaster+13 -1
mediawiki/extensions/WhoIsWatchingmaster+14 -2
mediawiki/extensions/BlueSpiceChecklistmaster+7 -4
mediawiki/extensions/BlueSpiceFoundationmaster+42 -29
mediawiki/extensions/PrivateDomainsmaster+4 -2
mediawiki/extensions/Athenamaster+17 -4
mediawiki/extensions/DeleteBatchmaster+1 -1
mediawiki/extensions/MassEditRegexmaster+1 -1
mediawiki/extensions/WebDAVmaster+5 -4
mediawiki/extensions/BlueSpiceArticleInfomaster+1 -1
mediawiki/extensions/BlueSpiceAvatarsmaster+1 -1
mediawiki/extensions/BlueSpiceDashboardsmaster+2 -1
mediawiki/extensions/BlueSpiceEchoConnectormaster+2 -2
mediawiki/extensions/BlueSpiceGroupManagermaster+3 -2
mediawiki/extensions/BlueSpiceInsertCategorymaster+2 -2
mediawiki/extensions/BlueSpiceSMWConnectormaster+11 -3
mediawiki/extensions/BlueSpiceInsertTemplatemaster+4 -1
mediawiki/extensions/BlueSpiceReadConfirmationmaster+1 -2
mediawiki/extensions/FileExportermaster+3 -3
mediawiki/extensions/ArticleFeedbackv5master+2 -2
mediawiki/coremaster+5 -1
mediawiki/extensions/CommonsMetadatamaster+7 -1
mediawiki/extensions/GrowthExperimentsmaster+4 -5
mediawiki/extensions/WikiLambdamaster+9 -13
mediawiki/extensions/Newslettermaster+2 -1
mediawiki/extensions/SpamBlacklistmaster+5 -1
mediawiki/extensions/CirrusSearchmaster+5 -5
mediawiki/extensions/TemplateDatamaster+2 -2
mediawiki/extensions/Babelmaster+1 -2
mediawiki/extensions/CentralNoticemaster+8 -5
mediawiki/extensions/PageTriagemaster+12 -8
mediawiki/extensions/UploadWizardmaster+6 -3
mediawiki/extensions/WikibaseMediaInfomaster+7 -7
mediawiki/extensions/GWToolsetmaster+5 -4
mediawiki/extensions/Flowmaster+40 -44
mediawiki/extensions/EntitySchemamaster+36 -21
mediawiki/extensions/LiquidThreadsmaster+42 -18
mediawiki/extensions/Translatemaster+52 -42
mediawiki/extensions/VisualEditormaster+14 -10
mediawiki/extensions/AbuseFiltermaster+8 -5
mediawiki/extensions/FlaggedRevsmaster+29 -26
mediawiki/coremaster+2 -2
mediawiki/coremaster+4 -1
mediawiki/skins/DuskToDawnmaster+8 -1
mediawiki/extensions/Echomaster+10 -7
mediawiki/extensions/CheckUsermaster+11 -4
mediawiki/extensions/Collectionmaster+2 -1
mediawiki/extensions/MassMessagemaster+36 -31
mediawiki/extensions/RSSmaster+4 -2
mediawiki/extensions/ActiveAbstractmaster+1 -1
mediawiki/extensions/SecurePollmaster+5 -1
mediawiki/extensions/CirrusSearchmaster+18 -8
mediawiki/extensions/Babelmaster+4 -3
mediawiki/extensions/TimedMediaHandlermaster+16 -6
mediawiki/extensions/Cognatemaster+7 -8
mediawiki/extensions/GeoCrumbsmaster+5 -1
mediawiki/extensions/EventBusmaster+9 -2
mediawiki/extensions/Kartographermaster+4 -1
mediawiki/extensions/Graphmaster+46 -10
mediawiki/extensions/Scribuntomaster+5 -3
mediawiki/extensions/JsonConfigmaster+4 -2
mediawiki/extensions/ORESmaster+2 -2
mediawiki/extensions/GeoDatamaster+1 -1
mediawiki/extensions/TextExtractsmaster+20 -4
mediawiki/extensions/TemplateSandboxmaster+4 -4
mediawiki/extensions/TitleBlacklistmaster+1 -1
mediawiki/extensions/UserMergemaster+1 -1
mediawiki/extensions/ContentTranslationmaster+5 -1
mediawiki/extensions/Lintermaster+1 -2
mediawiki/extensions/WikimediaMaintenancemaster+6 -5
mediawiki/extensions/TemplateStylesmaster+1 -1
mediawiki/extensions/NewUserMessagemaster+1 -1
mediawiki/extensions/ActiveAbstractmaster+9 -7
mediawiki/extensions/AbuseFiltermaster+17 -12
mediawiki/extensions/SecurePollmaster+34 -17
mediawiki/extensions/GrowthExperimentsmaster+3 -2
mediawiki/extensions/ProofreadPagemaster+8 -3
mediawiki/extensions/Thanksmaster+5 -2
mediawiki/extensions/TwoColConflictmaster+12 -3
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 808521 merged by jenkins-bot:

[mediawiki/extensions/Polyglot@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808521

Change 808516 merged by jenkins-bot:

[mediawiki/extensions/Patroller@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808516

Change 808515 merged by jenkins-bot:

[mediawiki/extensions/ParserMigration@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808515

Change 808514 merged by jenkins-bot:

[mediawiki/extensions/PageSchemas@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808514

Change 808512 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatusBar@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808512

Change 808505 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808505

Change 808503 merged by jenkins-bot:

[mediawiki/extensions/LDAPSyncAll@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808503

Change 808500 merged by jenkins-bot:

[mediawiki/extensions/GroupWhitelist@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808500

Change 808507 merged by jenkins-bot:

[mediawiki/extensions/OfflineImportLexicon@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808507

Change 808495 merged by jenkins-bot:

[mediawiki/extensions/EnhancedUpload@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808495

Change 808496 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808496

Change 808494 merged by jenkins-bot:

[mediawiki/extensions/EditNotify@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808494

Change 808493 merged by jenkins-bot:

[mediawiki/extensions/DynamicPageListEngine@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808493

Change 808491 merged by jenkins-bot:

[mediawiki/extensions/CreatedPagesList@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808491

Change 808492 merged by jenkins-bot:

[mediawiki/extensions/DataTransfer@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808492

Change 808490 merged by jenkins-bot:

[mediawiki/extensions/ContentTransfer@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808490

Change 808487 merged by jenkins-bot:

[mediawiki/extensions/AutoCategoriseUploads@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808487

Change 808485 merged by jenkins-bot:

[mediawiki/extensions/AControlImageLink@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808485

Change 808489 merged by jenkins-bot:

[mediawiki/extensions/Commentbox@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808489

Change 808473 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Replace deprecated WikiPage::factory/Use WikiPageFactory

https://gerrit.wikimedia.org/r/808473

Change 808506 merged by jenkins-bot:

[mediawiki/extensions/NewUserActions@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808506

Change 808517 merged by jenkins-bot:

[mediawiki/extensions/PerPageLicense@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808517

Change 808523 merged by jenkins-bot:

[mediawiki/extensions/SemanticImageAnnotator@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808523

Change 808279 merged by jenkins-bot:

[mediawiki/skins/BlueSpiceDiscovery@master] Remove use of deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808279

Change 808400 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceUEModuleTable2Excel@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808400

Change 808397 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceSocialProfile@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808397

Change 808389 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808389

Change 808387 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceDistributionConnector@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808387

Change 808398 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceSocialTopics@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808398

Change 808396 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceSocial@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808396

Change 808401 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceUserSidebar@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808401

Change 809558 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/BlueSpiceUserSidebar@REL1_35] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/809558

Change 809558 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceUserSidebar@REL1_35] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/809558

Change 809559 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/BlueSpiceUserSidebar@REL1_35-4.2.x] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/809559

Change 809559 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceUserSidebar@REL1_35-4.2.x] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/809559

Change 808399 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceUEModulePDF@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808399

Change 808354 merged by Robert Vogel:

[mediawiki/extensions/CognitiveProcessDesigner@master] Replace deprecated WikiPage::newFromID/factory

https://gerrit.wikimedia.org/r/808354

Change 808356 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceBookshelf@master] Replace deprecated WikiPage::newFromID/factory

https://gerrit.wikimedia.org/r/808356

Change 808281 merged by Robert Vogel:

[mediawiki/skins/BlueSpiceCalumma@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808281

Change 808378 abandoned by Umherirrender:

[mediawiki/extensions/TEI@master] Replace deprecated WikiPage::factory

Reason:

No longer calls of the deprecated function

https://gerrit.wikimedia.org/r/808378

Change 808513 merged by Umherirrender:

[mediawiki/extensions/PageOwnership@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808513

Change 808484 merged by Umherirrender:

[mediawiki/extensions/AccessControl@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808484

Change 808531 merged by Umherirrender:

[mediawiki/extensions/Workflows@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808531

Change 808530 merged by Umherirrender:

[mediawiki/extensions/WikispeechSpeechDataCollector@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808530

Change 808518 merged by Umherirrender:

[mediawiki/extensions/PhpTagsStorage@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808518

Change 808519 merged by Umherirrender:

[mediawiki/extensions/PhpTagsWiki@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808519

Change 808498 merged by Umherirrender:

[mediawiki/extensions/FileAnnotations@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808498

Change 808499 merged by Umherirrender:

[mediawiki/extensions/Forms@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808499

Change 808463 merged by Umherirrender:

[mediawiki/extensions/PageProperties@master] Replace deprecated WikiPage::factory/Use WikiPageFactory

https://gerrit.wikimedia.org/r/808463

Change 808353 merged by Umherirrender:

[mediawiki/extensions/CollaborationKit@master] Replace deprecated WikiPage::newFromID/factory

https://gerrit.wikimedia.org/r/808353

Change 808369 merged by jenkins-bot:

[mediawiki/extensions/DynamicPageList@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/808369

Change 808303 merged by jenkins-bot:

[mediawiki/core@master] DerivativeContext: Create WikiPage from derivated title

https://gerrit.wikimedia.org/r/808303

Change 808298 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Defer create of WikiFilePage object to RequestContext

https://gerrit.wikimedia.org/r/808298

Change 748319 abandoned by Zabe:

[mediawiki/core@master] Avoid using deprecated WikiPage instantiation methods

Reason:

https://gerrit.wikimedia.org/r/748319

Change 829069 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/829069

Change 829069 merged by jenkins-bot:

[mediawiki/core@master] tests: Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/829069

Change 847045 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/skins/TuleapSkin@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/847045

Change 847074 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Replace deprecated WikiPage::factory in RevisionStoreDbTest

https://gerrit.wikimedia.org/r/847074

Change 847096 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate WikiPage::factory/newFromID/newFromRow

https://gerrit.wikimedia.org/r/847096

Change 847109 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Replace deprecated WikiPage::factory in WikiCategoryPageTest

https://gerrit.wikimedia.org/r/847109

Change 847109 merged by jenkins-bot:

[mediawiki/core@master] tests: Replace deprecated WikiPage::factory in WikiCategoryPageTest

https://gerrit.wikimedia.org/r/847109

Change 847045 merged by Umherirrender:

[mediawiki/skins/TuleapSkin@master] Replace deprecated WikiPage::factory

https://gerrit.wikimedia.org/r/847045

Change 847074 merged by jenkins-bot:

[mediawiki/core@master] tests: Replace deprecated WikiPage::factory in RevisionStoreDbTest

https://gerrit.wikimedia.org/r/847074