Separate Vector into 2 separate skins
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 14 2021, 9:49 PM

Description

Vector will be broken into 2 separate skins with 2 keys that represent the legacy (vector key) and the modern version (vector-2022 key). The two skins (legacy aka Vector and modern aka Vector 2022) will be marked in such a way that they are hidden on Special:Preferences.

With 2 skins and a migration plan, we can manage the change iteratively, e.g. QA the 2 skins and change the defaults on different wikis as we wean ourselves off the old skin.

Acceptance criteria

Vector will be broken into two internal skins that are hidden in user preferences. These will have skin keys vector and vector-2022
Vector will be the default skin. The Vector constructor, will make use of SkinFactory::getSkinOptions to work out which skins to apply
The skin key for Vector will be "vector"
No change to end user experience.

QA steps

Visit preferences. I should only see one Vector skin listed.
When I visit wiki/Special:Preferences?useskin=vector-2022 I see an additional Vector skin in preferences
When I visit wiki/Special:Preferences?useskin=vector I see only one Vector skin in preferences

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T273473 [Epic] Improve the table of contents
Resolved	Jdrewniak	T291098 [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys
Resolved	Edtadros	T297756 Separate Vector into 2 separate skins

Event Timeline

Jdlrobson created this task.Dec 14 2021, 9:49 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptDec 14 2021, 9:49 PM

Jdlrobson triaged this task as High priority.Dec 14 2021, 10:15 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

ovasileva subscribed.Dec 15 2021, 1:27 PM

LGoto set the point value for this task to 5.Jan 4 2022, 6:38 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson updated the task description. (Show Details)Jan 4 2022, 6:44 PM

Jdlrobson removed the point value for this task.

Jdlrobson set the point value for this task to 5.

Jdlrobson claimed this task.Jan 4 2022, 7:23 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson removed Jdlrobson as the assignee of this task.Jan 5 2022, 11:04 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

After some more analysis I think we can do this migration with just 2 skins which is preferable as we can retain the existing vector key. Since I upgraded PHP to 8 my local PHPUnit is not working, so bear with me while I work those out.

cjming claimed this task.Jan 7 2022, 4:29 PM

cjming updated the task description. (Show Details)Jan 7 2022, 8:12 PM

cjming renamed this task from Separate Vector into 3 separate skins to Separate Vector into 2 separate skins.Jan 7 2022, 8:21 PM

cjming reassigned this task from cjming to Edtadros.

cjming updated the task description. (Show Details)

cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming subscribed.

Jdlrobson mentioned this in T291098: [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys.Jan 13 2022, 1:19 AM

Wellverywell subscribed.Jan 13 2022, 4:40 AM

This can no longer be QAed given other changes. There is a dedicated QA task T299110

Jdlrobson updated the task description. (Show Details)Jan 13 2022, 7:34 PM

Separate Vector into 2 separate skinsClosed, ResolvedPublic5 Estimated Story PointsActions