| Tacsipacsi | |
| Jan 2 2022, 9:45 PM |
| F34923830: Screenshot 2022-01-20 at 01.36.05.png | |
| Jan 20 2022, 1:01 AM |
| F34923829: Screenshot 2022-01-20 at 01.35.30.png | |
| Jan 20 2022, 1:01 AM |
| F34923828: Screenshot 2022-01-20 at 01.33.03.png | |
| Jan 20 2022, 1:01 AM |
| F34923836: Screenshot 2022-01-20 at 01.58.50.png | |
| Jan 20 2022, 1:01 AM |
| F34917212: Screenshot 2022-01-13 at 18.16.48.png | |
| Jan 13 2022, 5:27 PM |
Change 751151 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Treat user talk subpages like normal talk pages in empty state text
(And, by the way, I’d also expect that it’s not an <h3>, as there’s no <h2> level heading on the page. Either an <h2>, or a semantically meaningless <div>.)
It was done this way as a trade-off between using semantic markup, and having compatibility with different skins without a bajillion of CSS overrides (that we'd have to maintain forever). Unless it's causing actual issues, I'd rather leave it unchanged.
Change 751151 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Treat user talk subpages like normal talk pages in empty state text
It says Start a discussion about TestUserEsther/test:
@matmarex, confirm that Start a discussion about TestUserEsther/test can replace the expected Start a discussion about User:TestUserEsther/test result.
Next steps
So, the namespace name is missing. I can't figure out if that was an intentional decision or a mistake. It was specced in T274832 but I don't see anything there describing how titles in other namespaces should be shown, all examples are using the main namespace. (I'm leaning towards thinking that it should be included, since that's how titles are usually displayed everywhere in MediaWiki.)
I don’t use assistive technology myself, and I’m not familiar with them enough to judge this. Then let’s keep the <h3> until someone reports an issue.
Change 753863 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Include namespace when referring to page title in empty state messages
Change 753863 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Include namespace when referring to page title in empty state messages
For our future selves, the patch above introduces the following changes...
| Current Behavior | Behavior after 753863 |
|---|---|
| Empty states for all talk pages, across all namespaces do NOT include the page's namespace (e.g. User:) within the empty state's copy | Empty states for all talk pages, except those in the User: or Main: namespaces WILL include the page's namespace (e.g. Help:) within the empty state's copy and empty states for all subpage talk pages, across all namespaces, WILL include the page's namespace (e.g. Help:) within the empty state's copy |
Observation: it says "Start a discussion about {{NAMESPACE}}:Tacsipacsi/test" for all other discussion(or "talk") namespaces (https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces)
except Talk(index 1). See:
@matmarex , is this the expected behaviour for Talk?