Page MenuHomePhabricator

New Discussion Tool empty page message refers to the page title as a user name on user talk subpages
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Open https://meta.wikimedia.org/wiki/User_talk:Tacsipacsi/test?dtenable=1 and look at the <h3> text.

Actual result

  1. It says Start a discussion with Tacsipacsi/test.

Expected result

  1. It says either Start a discussion with Tacsipacsi or Start a discussion about User:Tacsipacsi/test. There’s no user named Tacsipacsi/test. (And, by the way, I’d also expect that it’s not an <h3>, as there’s no <h2> level heading on the page. Either an <h2>, or a semantically meaningless <div>.)

Event Timeline

Change 751151 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Treat user talk subpages like normal talk pages in empty state text

https://gerrit.wikimedia.org/r/751151

(And, by the way, I’d also expect that it’s not an <h3>, as there’s no <h2> level heading on the page. Either an <h2>, or a semantically meaningless <div>.)

It was done this way as a trade-off between using semantic markup, and having compatibility with different skins without a bajillion of CSS overrides (that we'd have to maintain forever). Unless it's causing actual issues, I'd rather leave it unchanged.

Change 751151 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Treat user talk subpages like normal talk pages in empty state text

https://gerrit.wikimedia.org/r/751151

It says Start a discussion about TestUserEsther/test:

Screenshot 2022-01-13 at 18.16.48.png (932×2 px, 183 KB)

@matmarex, confirm that Start a discussion about TestUserEsther/test can replace the expected Start a discussion about User:TestUserEsther/test result.

Next steps

  • @ppelberg to express opinion about whether the namespace (e.g. Wikipedia:) ought to be included within the empty states. If yes, file a ticket to do this work.

@matmarex, confirm that Start a discussion about TestUserEsther/test can replace the expected Start a discussion about User:TestUserEsther/test result.

So, the namespace name is missing. I can't figure out if that was an intentional decision or a mistake. It was specced in T274832 but I don't see anything there describing how titles in other namespaces should be shown, all examples are using the main namespace. (I'm leaning towards thinking that it should be included, since that's how titles are usually displayed everywhere in MediaWiki.)

(And, by the way, I’d also expect that it’s not an <h3>, as there’s no <h2> level heading on the page. Either an <h2>, or a semantically meaningless <div>.)

It was done this way as a trade-off between using semantic markup, and having compatibility with different skins without a bajillion of CSS overrides (that we'd have to maintain forever). Unless it's causing actual issues, I'd rather leave it unchanged.

I don’t use assistive technology myself, and I’m not familiar with them enough to judge this. Then let’s keep the <h3> until someone reports an issue.

Change 753863 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Include namespace when referring to page title in empty state messages

https://gerrit.wikimedia.org/r/753863

Change 753863 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Include namespace when referring to page title in empty state messages

https://gerrit.wikimedia.org/r/753863

Change 753863 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Include namespace when referring to page title in empty state messages

https://gerrit.wikimedia.org/r/753863

For our future selves, the patch above introduces the following changes...

Current BehaviorBehavior after 753863
Empty states for all talk pages, across all namespaces do NOT include the page's namespace (e.g. User:) within the empty state's copyEmpty states for all talk pages, except those in the User: or Main: namespaces WILL include the page's namespace (e.g. Help:) within the empty state's copy and empty states for all subpage talk pages, across all namespaces, WILL include the page's namespace (e.g. Help:) within the empty state's copy

Observation: it says "Start a discussion about {{NAMESPACE}}:Tacsipacsi/test" for all other discussion(or "talk") namespaces (https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces)

Screenshot 2022-01-20 at 01.36.05.png (1×2 px, 223 KB)

Screenshot 2022-01-20 at 01.35.30.png (1×2 px, 232 KB)

Screenshot 2022-01-20 at 01.33.03.png (864×1 px, 176 KB)

except Talk(index 1). See:

Screenshot 2022-01-20 at 01.58.50.png (730×2 px, 157 KB)

@matmarex , is this the expected behaviour for Talk?

Yes, that’s what I expected. Thanks!