VectorPrefDiffInstrumentation should work for skin changes
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 5 2022, 7:19 PM

Description

Currently the VectorPrefDiffInstrumentation instrumentation checks for changes to the skinVersion key when the current skin is the skin key vector

With Vector being modelled as 2 separate skins, this logic will also need to consider the case where the skin is changed (instead of the skin version preference)

QA

IF
I go to http://localhost:8888/wiki/Special:Preferences?useskin=vector-2022 and chose the legacy 2010 version of Vector and hit save
THEN
VectorPrefDiffInstrumentation should log that I am going from skin version latest to skin version legacy.

IF
I go to http://localhost:8888/wiki/Special:Preferences?useskin=vector-2022 and chose Monobook and hit save
THEN
VectorPrefDiffInstrumentation should not log.

IF
I go to http://localhost:8888/wiki/Special:Preferences?useskin=vector and chose Vector (2022 version) and hit save
THEN
VectorPrefDiffInstrumentation should log that I am going from skin version legacy to skin version latest.

IF I go to http://localhost:8888/wiki/Special:Preferences?useskin=vector and modify the "Use Legacy Vector" preference and hit save
THEN
VectorPrefDiffInstrumentation should log

Developer notes

The method VectorPrefDiffInstrumentation::createEventIfNecessary should be updated to always inspect the vector key. It should look for the following scenarios:

skin was "vector" before, now "vector-2022" then initial_state = 'vector1', final_state = 'vector2'
skin was "vector-2022" before, now "vector" then initial_state = 'vector2', final_state = 'vector1'

It should check this before checking the skin version field.

Note, we can drop any events for any preference changes that change both the skin and skin version keys in the same change. These should be impossible with the UI, so would indicate someone testing/hacking.

Details

	Subject	Repo	Branch	Lines +/-
	Add support for Vector2022 skin option to VectorPrefDiffInstrumentation	mediawiki/extensions/WikimediaEvents	master	+161 -21

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T273473 [Epic] Improve the table of contents
Resolved	Jdrewniak	T291098 [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys
Resolved	Jdlrobson	T298650 VectorPrefDiffInstrumentation should work for skin changes

Event Timeline

Jdlrobson created this task.Jan 5 2022, 7:19 PM

Jdlrobson moved this task from Backlog to [active] Remove Special:MobileContributions on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 5 2022, 9:30 PM

ovasileva subscribed.Jan 6 2022, 10:34 AM

Jdlrobson moved this task from [active] Remove Special:MobileContributions to [active] Split Vector skins on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 6 2022, 6:52 PM

Jdlrobson triaged this task as High priority.Jan 6 2022, 10:30 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).

Jdlrobson updated the task description. (Show Details)Jan 7 2022, 6:30 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

LGoto set the point value for this task to 3.Jan 10 2022, 6:39 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

• nray claimed this task.Jan 10 2022, 6:46 PM

• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 753594 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/WikimediaEvents@master] Add support for Vector2022 skin option to VectorPrefDiffInstrumentation

https://gerrit.wikimedia.org/r/753594

gerritbot added a project: Patch-For-Review.Jan 13 2022, 12:12 AM

• nray removed • nray as the assignee of this task.Jan 13 2022, 12:14 AM

• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

• nray subscribed.

Jdlrobson claimed this task.Jan 13 2022, 6:06 PM

Change 753594 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Add support for Vector2022 skin option to VectorPrefDiffInstrumentation

https://gerrit.wikimedia.org/r/753594

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 14 2022, 9:48 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 14 2022, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2022, 10:10 PM

(I will QA this one)

Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 28 2022, 12:01 AM

I am not seeing any validation errors show up so that's good.

I checked data for the month of January. Looking at mediawiki.org, itwiki and euwiki to check that there is nothing unusual in the groups over this week. Due to an issue with the instrumentation earlier in the month, I limited my data to after 20th.
I used this query:

select * from mediawiki_skin_diff WHERE year = 2022 AND month = 1
AND ((normalized_host.project_class = 'wikipedia' 
AND (normalized_host.project = 'eu' OR normalized_host.project = 'it' )) OR normalized_host.project_class = 'mediawiki' ) AND day > 20

Events of significance:
On 24th we enabled on eu.wiki
On 25th we enabled on it.wiki

Events are pretty low for these wikis, so can't glean too much from the data other than we're still logging data despite the transition.
Looks like there was a bit of a spike (if you can call it) around then which could relate to people (myself) testing it.

Screen Shot 2022-01-31 at 2.24.05 PM.png (750×1 px, 52 KB)

Will continue to monitor this table during the week as I roll out further.

Work sheet (WMF only): https://docs.google.com/spreadsheets/d/1yEI1qmIFjXKA0bed2gAwuO0IfnKVzxyYzm6USxzGhPY/edit#gid=0

This is working as evidenced by the 1000s of people that opted out due to T300757.

	F34938646: Screen Shot 2022-01-31 at 2.24.05 PM.png
	Jan 31 2022, 10:26 PM

VectorPrefDiffInstrumentation should work for skin changesClosed, ResolvedPublic3 Estimated Story PointsActions