Page MenuHomePhabricator

"welcome" message for logged in mobile users lacking translations
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • login to your account
  • access the mobile version of a wiki
  • select a language other than English in your preferences

What happens?:
The "welcome" only appears in English.

What should have happened instead?:
It should appear according to the user's language; I've already selected Portuguese and Spanish, but it didn't appear

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Screenshot_20220106-130234~2.jpg (745×540 px, 70 KB)

Spanish Wikivoyage

Screenshot_20220106-130315~2.jpg (761×540 px, 55 KB)

Portuguese Wikivoyage

QA in production

Make sure you haven't changed the language to English for these tests.
Visit https://it.m.wikipedia.org/wiki/Speciale:GlobalPreferences#mw-prefsection-personal and make sure "Make this setting global" is unchecked.

Jan 13th (PM):
Visit https://it.m.wikipedia.org/wiki/Pagina_principale and confirm the text at top says "Welcome, <username>" in Italian.

From Jan 14th:
Log in and visit https://fr.m.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal and confirm the text at top says "Welcome, <username>" in French.

Event Timeline

Pcoombe subscribed.

Can reproduce this on https://pt.m.wikivoyage.org/ and https://ca.m.wikipedia.org/ which are on 1.38.0-wmf.16, and use the message wikimedia-mobile-mainpage-title-loggedin

Can't reproduce on https://pt.m.wikipedia.org/ or other wikipedias currently on 1.38.0-wmf.13, which use the message mobile-frontend-logged-in-homepage-notification

This is coming from WikimediaMessages. The message wikimedia-mobile-mainpage-title-loggedin seems to be lacking translations. Not sure how to expedite this...

https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/tree/master/i18n/

Jdlrobson renamed this task from "welcome" is not being translated on mobile to "welcome" message for logged in mobile users lacking translations .Jan 6 2022, 10:07 PM
Jdlrobson added a project: I18n.

@Nikerabbit do we have any way of batch updating message keys that got renamed?

@Raymond handles message processing for MediaWiki.

@Nikerabbit do we have any way of batch updating message keys that got renamed?

What was the old message key? I can try to move these translations to the new key.

Current translations: https://translatewiki.net/wiki/Special:Translations?message=MediaWiki%3Awikimedia-mobile-mainpage-title-loggedin&namespace=8

mobile-frontend-logged-in-homepage-notification -> wikimedia-mobile-mainpage-title-loggedin

mobile-frontend-logged-in-homepage-notification -> wikimedia-mobile-mainpage-title-loggedin

Thanks. Existing, old translations moved to the new key: https://translatewiki.net/wiki/Special:Log?type=move&user=Raymond&page=&wpdate=2022-01-07&tagfilter=&subtype=

Will be exported on Monday and go live with the next deployment train.

Thanks a bunch @Raymond and @Nikerabbit !

To avoid this happening again, is there a more formal way to request moves prior to the train to avoid this sort of thing happening?
I can imagine it might be helpful for when we deploy Extension:NearbyPages which has a bunch of messages in MobileFrontend.

Given this is logged in only and wikis can override the message, I think it's okay to wait on this particular issue until next week. Sorry for the inconvenience to everyone who reported this.

Thanks a bunch @Raymond and @Nikerabbit !

To avoid this happening again, is there a more formal way to request moves prior to the train to avoid this sort of thing happening?

Add me as reviewer so we can coordinate such tasks.

I can imagine it might be helpful for when we deploy Extension:NearbyPages which has a bunch of messages in MobileFrontend.

A caveat: Moving messages from one extension to another while the old extension is still enabled on WMF cluster will result in missing translations there. If there is a timeframe where both extensions are enabled it would be the best to duplicate the messages per Gerrit.

it would be the best to duplicate the messages per Gerrit.

Thanks for the guidance here! Noted for future.

For those just joining us:

  • The translation problem will be fixed next week on the train.

*This bug impacts logged in users only.

  • If you can't wait until next week's train you can edit MediaWiki:wikimedia-mobile-mainpage-title-loggedin to change this text or remove the message altogether.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: frwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Log in and visit https://fr.m.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal and confirm the text at top says "Welcome, <username>" in French.

Screen Shot 2022-01-30 at 8.43.37 PM.png (355×797 px, 96 KB)