Page MenuHomePhabricator

"Change visibility of selected revisions" button out of alignment on revision history on Minerva
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

See below screenshots from the the revision history page:

Top of page:

change_visibility_minerva_top.png (260×855 px, 31 KB)

Bottom of page:

change_visibility_minerva.png (175×635 px, 15 KB)

Steps to reproduce problem
  1. Login as an admin user
  2. Go to https://test.wikipedia.org/w/index.php?title=Main_Page&action=history&useskin=minerva
Environment

Browser: Firefox 78 and Chromium 87
Wiki(s): https://test.wikipedia.org MinervaNeue – (8ff3890) 07:13, 3 January 2022.

Event Timeline

Jdlrobson subscribed.

(Contributions page code is in core and I believe maintained by growth team). Not sure which team should be responsible for fixing.

Issue doesn't seem to impact mobile devices:

Screenshot_20220111-112204_Chrome.jpg (2×1 px, 418 KB)

@dom_walden - how can an admin user reach to the page without using that specific link? I tried on betalabs - the admin user with enabled Minerva skin (or using &useskin=minerva) clicks on Hisotry and gets redirected to e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:History/Zilant22 which doesn't have the "Compare the selected revisions" etc controls.

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Zilant22&action=history will display the misalgned controls.

@dom_walden - how can an admin user reach to the page without using that specific link? I tried on betalabs - the admin user with enabled Minerva skin (or using &useskin=minerva) clicks on Hisotry and gets redirected to e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:History/Zilant22 which doesn't have the "Compare the selected revisions" etc controls.

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Zilant22&action=history will display the misalgned controls.

That's interesting. In that case I don't know. While testing I had ?title=Main_Page&action=history open, changed my skin in Special:Preferences and reloaded the history page.

I didn't realise Minerva had a different endpoint. Is it an option you can set?

@dom_walden - how can an admin user reach to the page without using that specific link? I tried on betalabs - the admin user with enabled Minerva skin (or using &useskin=minerva) clicks on Hisotry and gets redirected to e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:History/Zilant22 which doesn't have the "Compare the selected revisions" etc controls.

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Zilant22&action=history will display the misalgned controls.

That's interesting. In that case I don't know. While testing I had ?title=Main_Page&action=history open, changed my skin in Special:Preferences and reloaded the history page.

I didn't realise Minerva had a different endpoint. Is it an option you can set?

My test user's rights:

ug_group
abusefilter
bureaucrat
confirmed
filemover
oversight
patroller
reviewer
sysop

To summarize the steps I tested:

  • an admin user changes the UI skin to Minerva in Preferences (or use &useskin=minerva, or goes to mobile)
  • an admin user goes to the article and click on View history link/ button (on mobile
  • an admin user is directed to Special:History page which doesn't have the "Compare the selected revisions" etc controls.

Two important notes

    • on Desktop (without Minerva skin) my test users sees the "Compare the selected revisions" etc controls.
  • with ?w/index.php?title=Zilant22&action=history and Minerva skin enabled, my test user will see the "Compare the selected revisions" etc controls.

    The question is: can admin users see "Compare the selected revisions" etc without manipulating the url?

https://en.wikipedia.beta.wmflabs.org/wiki/Spain?action=history&useskin=minerva is the URL you need but I don't have sufficient permissions to see the additional buttons.

Special:History is the minerva mobile history page and this appears to be about the desktop one (which is also available in the advanced mobile contributions mode).

I can replicate on https://test.wikipedia.org/wiki/Spain?action=history&useskin=minerva

Issue appears to be the rule .action-history .mw-history-revisiondelete-button { margin-bottom: 1em; } so I guess this is in Minerva and actually a readers web issue:
https://gerrit.wikimedia.org/g/mediawiki/skins/MinervaNeue/+/6f18417fab72ad5574d6fba65fbf2fe09581f557/skinStyles/mediawiki.action.history.styles.less#70

Jdlrobson claimed this task.

This appears to have been fixed. Likely by T305113 and T240624.