The section in question is w:ru:Википедия:Форум/Общий#*_или_:
The Echo/Notification message said the editor replied in the section или :
It should have said * или :
• Whatamidoing-WMF | |
Jan 19 2022, 6:46 PM |
F34925047: image.png | |
Jan 20 2022, 11:18 PM |
F34925062: image.png | |
Jan 20 2022, 11:18 PM |
F34925064: image.png | |
Jan 20 2022, 11:18 PM |
F34925052: image.png | |
Jan 20 2022, 11:18 PM |
F34923480: Screen Shot 2022-01-19 at 9.50.04 AM.png | |
Jan 19 2022, 6:46 PM |
The section in question is w:ru:Википедия:Форум/Общий#*_или_:
The Echo/Notification message said the editor replied in the section или :
It should have said * или :
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T276497 Scale DiscussionTools to all projects | |||
Open | None | T251207 [Epic] Scale DiscussionTools to all Wikipedias | |||
Resolved | ppelberg | T284489 Deploy topic subscriptions (desktop) as opt-out feature at all projects | |||
Open | None | T233447 [OKR] Increase response rates | |||
Resolved | ppelberg | T274833 [RELEASE TICKET] Enable topic subscriptions as opt-out at partner wikis | |||
Resolved | matmarex | T299572 Echo Notification stripped first character of section heading (an asterisk) |
It looks like we're parsing the section title as wikitext (which results in a bullet list here), and then we remove all HTML markup, leaving just the text you see. The section titles in subscription notifications are plain text.
For other Echo notifications, e.g. mentions, the section title in the notification is actually wikitext, and should be parsed and then markup removed. But this case is also handled wrong there, with the asterisk treated as a bullet list. It should be parsed as if it wasn't at the start of a line.
Change 755820 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/Echo@master] Parse section titles in notifs as if they weren't at the start of line
Change 755822 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Don't try to parse section titles as wikitext in subscription notifs
I've been using the following section titles for testing locally:
== <nowiki><b>not bold</b></nowiki> == == Topic with template {{echo|hi}} == == Topic with <script>alert(1)</script> == == title with [[link]] test == == RFC 3 == == '' oh no '' == == ** oh no ** == == title [[file:logo.png|20px|huh]] ''with'' <sup>more</sup> formatting ==
Summary of the fixes, note the incorrect entries in the "Before" screenshots marked in red:
Before | After | |
---|---|---|
Subscriptions | ||
Mentions |
Change 755820 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Parse section titles in notifs as if they weren't at the start of line
Change 755822 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Don't try to parse section titles as wikitext in subscription notifs