Notice about new langlinks location is shown on pages where it shouldn't be
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Huji
	Jan 19 2022, 8:39 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Go to a special page on fawiki (such as https://fa.wikipedia.org/wiki/Special:Watchlist after logging in, or https://fa.wikipedia.org/wiki/Special:Search even logged out)

What happens?:

On the right side of the page, under "زبان‌ها" (which means "Languages") you will see a message "On this Wikipedia the language links are at the top of the page across from the article title."

What should have happened instead?:

This notice should only be shown on pages that can have a langlink (content pages). It should not be shown on special pages.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:MW 1.38.0-wmf.17 (rMWa7e96ffb7ddc)
with Vector 1.0.0 (948f039) ‏with Desktop Improvements (Vector 2022) features enabled.

Developer Notes

Should be straightforward to exclude language alert on special pages by leveraging SkinVector::isLanguagesInContentAt('top') as one of the conditions for determining the value of the 'is-vector-table-of-contents-visible' variable

QA Results - Beta

AC	Status	Details
1	✅	T299581#7702787

QA Results - Prod

AC	Status	Details
1	✅	T299581#7702795

Details

Subject	Repo	Branch	Lines +/-
Don't show language alert on main page if it has no languages	mediawiki/skins/Vector	master	+1 -1
Fix issues with language alert in sidebar:	mediawiki/skins/Vector	master	+8 -3
Exclude special pages from language alert	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rSVEC948f0392c94f: Merge "Fix TypeError: document.querySelectorAll(...).forEach is not a function"
rMWa7e96ffb7ddc: Update git submodules

Event Timeline

Huji created this task.Jan 19 2022, 8:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2022, 8:39 PM

Huji updated the task description. (Show Details)Jan 19 2022, 9:57 PM

Jdlrobson added a project: Web-Team-Backlog.Jan 21 2022, 9:07 PM

Jdlrobson moved this task from Incoming to Language Switching on the Desktop Improvements (Vector 2022) board.Jan 21 2022, 9:13 PM

ovasileva triaged this task as High priority.Jan 24 2022, 4:18 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

LGoto assigned this task to cjming.Jan 24 2022, 6:15 PM

Change 757033 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Exclude special pages from language alert

https://gerrit.wikimedia.org/r/757033

gerritbot added a project: Patch-For-Review.Jan 25 2022, 4:54 PM

cjming removed cjming as the assignee of this task.Jan 25 2022, 4:56 PM

cjming updated the task description. (Show Details)

cjming moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming subscribed.

LGoto set the point value for this task to 2.Jan 25 2022, 6:28 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming claimed this task.Jan 26 2022, 7:15 AM

cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 757379 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Fix issues with language alert in sidebar:

https://gerrit.wikimedia.org/r/757379

Change 757033 abandoned by Clare Ming:

[mediawiki/skins/Vector@master] Exclude special pages from language alert

Reason:

abandoning in favor of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/757379

https://gerrit.wikimedia.org/r/757033

cjming removed cjming as the assignee of this task.Jan 26 2022, 8:03 AM

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming updated the task description. (Show Details)Jan 26 2022, 4:43 PM

Test wiki created on Patch demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/cfcea0c737/w/

Test wiki on Patch demo by CMing (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/cfcea0c737/w/~~

Test wiki created on Patch demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/67c1cb0322/w/

cjming claimed this task.Jan 26 2022, 6:46 PM

cjming moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Test wiki on Patch demo by CMing (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/67c1cb0322/w/~~

Test wiki created on Patch demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/77691bf641/w/

hi @ovasileva @Jdlrobson - I'm wondering about what I'm seeing on patchdemo (with an unmerged fix that checks for special pages to not display language alert/notice) and a few live pilot wikis (fr + ko) -- it seems like the language header in sidebar shouldn't be showing when there isn't anything beneath it? Weirdly I can't seem to replicate on my local environment.

As for possible fixes, at first glance I think it's generated by Skin::buildSidebar - would a hook (onSkinBuildSidebar, or onSidebarBeforeOutput) be the right approach to prevent it? I can also log a separate ticket for this issue because I think the original issue in this ticket is resolved by the patch (i.e. language alert doesn't appear on special pages even tho the header still does)

Screen Shot 2022-01-28 at 10.12.23 AM.png (1×1 px, 279 KB)

Screen Shot 2022-01-28 at 10.13.54 AM.png (1×1 px, 187 KB)

addendum: I also see it on en with legacy + modern vector, logged-in + logged-out - https://en.wikipedia.org/wiki/Special:SpecialPages

cjming removed cjming as the assignee of this task.Jan 28 2022, 5:38 PM

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

hi @ovasileva @Jdlrobson - I'm wondering about what I'm seeing on patchdemo (with an unmerged fix that checks for special pages to not display language

Not a problem. @cjming it's showing because of the settings cog from ULS and due to the fact Vector's default configuration defaults to the sidebar. (Let's fix that - https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/757970)

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 28 2022, 8:00 PM

Change 757379 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix issues with language alert in sidebar:

https://gerrit.wikimedia.org/r/757379

One remaining edge case - the language alert shows on the main page, when the main page has no languages.

Screen Shot 2022-01-28 at 2.12.25 PM.png (1×2 px, 538 KB)

I'm using the following config:

$wgVectorLanguageInMainPageHeader = [
	"logged_in" => true,
	"logged_out" => true
];

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2022, 11:10 PM

In T299581#7660926, @Jdlrobson wrote:

One remaining edge case - the language alert shows on the main page, when the main page has no languages.

so even if with that config being true, we should not show the alert?

or only hide if main page has no languages even if wgVectorLanguageInMainPageHeader is true?

and show alert if main page does have languages and wgVectorLanguageInMainPageHeader is true?

addendum: hopefully i got it right in this patch https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/758516

Change 758516 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Don't show language alert on main page if it has no languages

https://gerrit.wikimedia.org/r/758516

gerritbot added a project: Patch-For-Review.Jan 31 2022, 4:44 PM

Jdlrobson assigned this task to Edtadros.Jan 31 2022, 5:58 PM

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 758516 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Don't show language alert on main page if it has no languages

https://gerrit.wikimedia.org/r/758516

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 31 2022, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 31 2022, 7:11 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Language notice should not appear on Special Pages:

Screen Shot 2022-02-10 at 3.41.40 PM.png (761×641 px, 138 KB)

Screen Shot 2022-02-10 at 3.41.54 PM.png (761×641 px, 152 KB)

Screen Shot 2022-02-10 at 3.42.28 PM.png (761×641 px, 91 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki, fawiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Language notice should not appear on Special Pages:

Screen Shot 2022-02-10 at 3.44.44 PM.png (761×641 px, 63 KB)

Screen Shot 2022-02-10 at 3.43.47 PM.png (761×641 px, 134 KB)

Screen Shot 2022-02-10 at 3.43.38 PM.png (761×641 px, 81 KB)

Screen Shot 2022-02-10 at 3.44.33 PM.png (761×641 px, 107 KB)

Screen Shot 2022-02-10 at 3.44.03 PM.png (761×641 px, 148 KB)

Edtadros updated the task description. (Show Details)Feb 10 2022, 11:48 PM

Looks good!

Test wiki on Patch demo by CMing (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/77691bf641/w/~~

	F34947943: Screen Shot 2022-02-10 at 3.43.47 PM.png
	Feb 10 2022, 11:47 PM

	F34947945: Screen Shot 2022-02-10 at 3.44.33 PM.png
	Feb 10 2022, 11:47 PM

	F34947942: Screen Shot 2022-02-10 at 3.44.44 PM.png
	Feb 10 2022, 11:47 PM

	F34947946: Screen Shot 2022-02-10 at 3.44.03 PM.png
	Feb 10 2022, 11:47 PM

	F34947944: Screen Shot 2022-02-10 at 3.43.38 PM.png
	Feb 10 2022, 11:47 PM

	F34947936: Screen Shot 2022-02-10 at 3.42.28 PM.png
	Feb 10 2022, 11:43 PM

	F34947935: Screen Shot 2022-02-10 at 3.41.54 PM.png
	Feb 10 2022, 11:43 PM

	F34947934: Screen Shot 2022-02-10 at 3.41.40 PM.png
	Feb 10 2022, 11:43 PM

Notice about new langlinks location is shown on pages where it shouldn't beClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

Developer Notes

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Notice about new langlinks location is shown on pages where it shouldn't be
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions