PHP Deprecated: Use of Wikimedia\Rdbms\DBConnRef::numRows was deprecated in MediaWiki 1.37. [Called from FlaggedRevsStats::getEditReviewTimes]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	thcipriani
	Jan 20 2022, 4:28 PM

Description

Error

mwversion: 1.38.0-wmf.18
reqId: a959d1342902d7b29200bee1
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Deprecated: Use of Wikimedia\Rdbms\DBConnRef::numRows was deprecated in MediaWiki 1.37. [Called from FlaggedRevsStats::getEditReviewTimes]

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.18/extensions/FlaggedRevs/backend/FlaggedRevsStats.php(425)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.18/includes/debug/MWDebug.php(377): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.18/includes/debug/MWDebug.php(353): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.18/includes/debug/MWDebug.php(232): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.18/includes/GlobalFunctions.php(1005): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.18/includes/libs/rdbms/database/DBConnRef.php(249): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.38.0-wmf.18/extensions/FlaggedRevs/backend/FlaggedRevsStats.php(425): Wikimedia\Rdbms\DBConnRef->numRows(Wikimedia\Rdbms\MysqliResultWrapper)
#7 /srv/mediawiki/php-1.38.0-wmf.18/extensions/FlaggedRevs/backend/FlaggedRevsStats.php(90): FlaggedRevsStats::getEditReviewTimes(MemcachedPeclBagOStuff, string)
#8 /srv/mediawiki/php-1.38.0-wmf.18/extensions/FlaggedRevs/maintenance/updateStats.php(28): FlaggedRevsStats::updateCache()
#9 /srv/mediawiki/php-1.38.0-wmf.18/maintenance/doMaintenance.php(108): UpdateFlaggedRevsStats->execute()
#10 /srv/mediawiki/php-1.38.0-wmf.18/extensions/FlaggedRevs/maintenance/updateStats.php(37): require_once(string)
#11 /srv/mediawiki/multiversion/MWScript.php(116): require_once(string)
#12 {main}

Notes

Happening 25 times every two hours on our maintenance server
Related to T286694: Drop legacy cruft arising from introduction of ResultWrapper (adding @Ladsgroup)

Details

	Subject	Repo	Branch	Lines +/-
	Avoid using deprecated function IDatabase::numRows()	mediawiki/extensions/FlaggedRevs	master	+1 -1
	Fix using deprecated function IDatabase::numRows()	mediawiki/extensions/FlaggedRevs	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	brennen	T293960 1.38.0-wmf.19 deployment blockers
		Resolved	PRODUCTION ERROR	Ladsgroup	T299659 PHP Deprecated: Use of Wikimedia\Rdbms\DBConnRef::numRows was deprecated in MediaWiki 1.37. [Called from FlaggedRevsStats::getEditReviewTimes]

Event Timeline

thcipriani created this task.Jan 20 2022, 4:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2022, 4:28 PM

thcipriani added a parent task: T293960: 1.38.0-wmf.19 deployment blockers.Jan 20 2022, 4:30 PM

Change 755727 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Fix using deprecated function IDatabase::numRows()

https://gerrit.wikimedia.org/r/755727

gerritbot added a project: Patch-For-Review.Jan 20 2022, 4:39 PM

Ladsgroup claimed this task.Jan 20 2022, 4:40 PM

Ladsgroup added a project: DBA.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 20 2022, 4:40 PM

Ladsgroup triaged this task as High priority.Jan 20 2022, 4:40 PM

Ladsgroup moved this task from Triage to In progress on the DBA board.

Change 755736 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Avoid using deprecated function IDatabase::numRows()

https://gerrit.wikimedia.org/r/755736

Change 755727 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Fix using deprecated function IDatabase::numRows()

https://gerrit.wikimedia.org/r/755727

Change 755736 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Avoid using deprecated function IDatabase::numRows()

https://gerrit.wikimedia.org/r/755736

There are probably some more deprecation warnings here and there. I took note and will make patches against in the parent ticket, FlaggedRevs is cleaned now.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 20 2022, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2022, 6:10 PM

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Jan 20 2022, 6:15 PM

Krinkle moved this task from Untriaged to Jan 2022 on the Wikimedia-production-error board.Feb 4 2022, 12:46 AM