Page MenuHomePhabricator

1.38.0-wmf.19 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease

Details

Backup Train Conductor
jeena
Release Version
1.38.0-wmf.19
Release Date
Jan 24 2022, 12:00 AM

2022 week 04 1.38-wmf.19 Changes wmf/1.38.0-wmf.19

This MediaWiki Train Deployment is scheduled for the week of Monday, January 24th:

Monday January 24thTuesday, January 25thWednesday, January 26thThursday, January 27thFriday
Backports only.Branch wmf.19 and deploy to Group 0 Wikis.Deploy wmf.19 to Group 1 Wikis.Deploy wmf.19 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.19 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.38.0-wmf.18
Next: 1.38.0-wmf.20

Related Objects

StatusSubtypeAssignedTask
ResolvedReleasebrennen
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORtstarling
ResolvedLucas_Werkmeister_WMDE
ResolvedPRODUCTION ERRORLadsgroup
ResolvedSecurityZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORtstarling

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
thcipriani changed Release Date from Jan 18 2021, 12:00 AM to Jan 18 2022, 12:00 AM.Oct 21 2021, 12:33 AM
thcipriani changed Release Date from Jan 18 2022, 12:00 AM to Jan 24 2022, 12:00 AM.Oct 21 2021, 12:43 AM
thcipriani reassigned this task from jeena to brennen.
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: dduvall.
thcipriani updated Other Assignee, added: jeena; removed: dduvall.
thcipriani set the point value for this task to 5.
thcipriani added a subscriber: jeena.
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/753131
  • Summary:
    • Deprecating a particular calling pattern of ParserOutput::addModules()/::addModuleStyles(). Code search finds calls to this method hard to distinguish from OutputPage::addModules()/::addModuleStyles() therefore it's quite possible some calls with the deprecated argument pattern may sneak through, resulting in deprecation logspam.
  • Test plan:
    • Watch for deprecation warnings in the logs.
  • Places to monitor:
  • Revert plan: Safe to revert patch, although hopefully after enough deprecation warnings have been logged to identify the remaining code locations which need updates. If there aren't too many and logspam is manageable, backporting patches to fix individual extensions can be done.
  • Affected wikis: All
  • IRC contact: cscott, (also ping @cscott on slack, since Matrix keeps getting my IRC nick kicked); backup subbu
  • UBN Task Projects/tags: Parsoid

Mentioned in SAL (#wikimedia-operations) [2022-01-25T18:14:56Z] <brennen> train 1.38.0-wmf.19 (T293960): no open blockers, starting stage-train script shortly

Change 757055 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757055

Change 757055 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757055

Mentioned in SAL (#wikimedia-operations) [2022-01-25T18:58:34Z] <brennen@deploy1002> Started scap: testwikis wikis to 1.38.0-wmf.19 refs T293960

Mentioned in SAL (#wikimedia-operations) [2022-01-25T19:50:35Z] <brennen@deploy1002> Finished scap: testwikis wikis to 1.38.0-wmf.19 refs T293960 (duration: 52m 01s)

Mentioned in SAL (#wikimedia-operations) [2022-01-25T20:01:22Z] <brennen> train 1.38.0-wmf.19 (T293960): testwiki sync finished, still no open blockers, proceeding to group0

Change 757077 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757077

Change 757077 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757077

Mentioned in SAL (#wikimedia-operations) [2022-01-25T20:05:07Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.38.0-wmf.19 refs T293960

I added T300100: In Timeless categories are showing up where page/action tabs are as a UBN blocker, and identified the core change which should probably be reverted as an unannounced breaking change.

Thanks all for blockers and patches. I'm juggling leading a couple of meetings this morning, but I'll do any pending backports prior to rolling train forward.

Mentioned in SAL (#wikimedia-operations) [2022-01-26T20:01:21Z] <brennen> train 1.38.0-wmf.19 (T293960): all known blockers patched, logs for wmf.19 quiet - proceeding to group1

Change 757518 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757518

Change 757518 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757518

Mentioned in SAL (#wikimedia-operations) [2022-01-26T20:06:42Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.19 refs T293960

Mentioned in SAL (#wikimedia-operations) [2022-01-26T20:07:37Z] <brennen@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.19 refs T293960 (duration: 00m 54s)

Mentioned in SAL (#wikimedia-operations) [2022-01-26T20:20:44Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: Revert "group1 wikis to 1.38.0-wmf.19 refs T293960"

Mentioned in SAL (#wikimedia-operations) [2022-01-26T20:21:50Z] <brennen> train 1.38.0-wmf.19 (T293960): rolling back due to increase in DBTransactionSizeErrors

Mentioned in SAL (#wikimedia-operations) [2022-01-26T23:34:35Z] <brennen> train 1.38.0-wmf.19 (T293960): parking the train at group0 until US morning; we have a probable fix for T300194 but CI is having issues

@Krinkle found a missed case for the ParserOutput::addModules() deprecation mentioned above, with a patch in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/757529. Most likely doesn't merit a backport, it will go away in wmf.20, but mentioning it in case the related deprecation warning shows up in the logs.

Mentioned in SAL (#wikimedia-operations) [2022-01-27T15:52:21Z] <brennen> train 1.38.0-wmf.19 (T293960): no current blockers; rolling train forward to group1 before log triage meeting

Change 757676 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757676

Change 757676 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757676

Mentioned in SAL (#wikimedia-operations) [2022-01-27T15:56:20Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.19 refs T293960

Mentioned in SAL (#wikimedia-operations) [2022-01-27T15:57:12Z] <brennen@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.19 refs T293960 (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2022-01-27T20:03:23Z] <brennen> train 1.38.0-wmf.19 (T293960): no current blockers; logs clean-ish, rolling train forward to group2

Change 757738 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757738

Change 757738 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.19 refs T293960

https://gerrit.wikimedia.org/r/757738

Mentioned in SAL (#wikimedia-operations) [2022-01-27T20:06:19Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.38.0-wmf.19 refs T293960

End-of-workday notes before I head out for an appointment: Currently seems stable on all wikis. Logs are currently noisy, but don't seem notably more so than for wmf.18.

Still looking stable. Optimistically calling this resolved. Thanks, as ever, to the many folks who helped out this week.