Page MenuHomePhabricator

1.38.0-wmf.20 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease

Details

Backup Train Conductor
brennen
Release Version
1.38.0-wmf.20
Release Date
Jan 31 2022, 12:00 AM

2022 week 05 1.38-wmf.20 Changes wmf/1.38.0-wmf.20

This MediaWiki Train Deployment is scheduled for the week of Monday, January 31st:

Monday January 31stTuesday, February 1stWednesday, February 2ndThursday, February 3rdFriday
Backports only.Branch wmf.20 and deploy to Group 0 Wikis.Deploy wmf.20 to Group 1 Wikis.Deploy wmf.20 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.20 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.38.0-wmf.19
Next: 1.38.0-wmf.21

Event Timeline

thcipriani changed Release Date from Jan 25 2021, 12:00 AM to Jan 25 2022, 12:00 AM.Oct 21 2021, 12:33 AM
thcipriani changed Release Date from Jan 25 2022, 12:00 AM to Jan 31 2022, 12:00 AM.Oct 21 2021, 12:43 AM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: brennen.
thcipriani set the point value for this task to 5.

Not a risky patch, but please note this week that we'll be rolling out the new Vector 2022 skin via some configuration changes (T299927). If there are any bugs about gadgets not working in Vector, or users seeing the new Vector skin when they don't expect to, please ping me to see if they're related. No need to roll back or block the train if you encounter these as we can roll back via configuration change.

Change 758947 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.20 refs T293961

https://gerrit.wikimedia.org/r/758947

Change 758947 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.20 refs T293961

https://gerrit.wikimedia.org/r/758947

Mentioned in SAL (#wikimedia-operations) [2022-02-01T19:20:32Z] <dancy@deploy1002> Started scap: testwikis wikis to 1.38.0-wmf.20 refs T293961

Mentioned in SAL (#wikimedia-operations) [2022-02-01T20:12:15Z] <dancy@deploy1002> Finished scap: testwikis wikis to 1.38.0-wmf.20 refs T293961 (duration: 51m 42s)

Change 758958 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.20 refs T293961

https://gerrit.wikimedia.org/r/758958

Change 758958 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.20 refs T293961

https://gerrit.wikimedia.org/r/758958

Mentioned in SAL (#wikimedia-operations) [2022-02-01T20:38:23Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.38.0-wmf.20 refs T293961

I am not sure how Wikimedia wikis use wgUseInstantCommons, but maybe someone should check if group0 wikis are affected by T300751: InstantCommons is broken .

I don't believe wikimedia wikis use instant commons

It is used on labswiki and labtestwiki.

And we can see the magic that is in place via https://www.mediawiki.org/wiki/MediaWiki seems to be working

Most content on wikitech is apparently locally uploaded so it should be fine to proceed

I remembered that WantedFiles shows instant commons usages. There's ~650 uploads.

https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page shows a bunch of red image links.

https://codesearch.wmcloud.org/operations/?q=wgUseInstantCommons&i=nope&files=&excludeFiles=&repos= indicates that wikitech and beta cluster wikis use instant commons.

It seems that no production wikis should be affected apart from wikitech.

Change 759305 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.20 refs T293961

https://gerrit.wikimedia.org/r/759305

Change 759305 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.20 refs T293961

https://gerrit.wikimedia.org/r/759305

Mentioned in SAL (#wikimedia-operations) [2022-02-02T20:03:24Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.20 refs T293961

Mentioned in SAL (#wikimedia-operations) [2022-02-02T20:04:14Z] <dancy@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.20 refs T293961 (duration: 00m 49s)

T300831: Cannot thank a Flow post on mediawiki.org: "Uncaught TypeError: elem is undefined" doesn't seem worth blocking the train over, but just noting it here. There are 5 reports in Logstash in the last two days.

Change 759580 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] group2 wikis to 1.38.0-wmf.20 refs T293961

https://gerrit.wikimedia.org/r/759580

Change 759580 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.38.0-wmf.20 refs T293961

https://gerrit.wikimedia.org/r/759580

Mentioned in SAL (#wikimedia-operations) [2022-02-03T20:11:31Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.38.0-wmf.20 refs T293961

I'm declaring this train done!